Issues in CustomerGalleryPage.php (master) - Issues in master - sunnysideup/silverstripe-user_image_upload - Measure and Improve Code Quality continuously with Scrutinizer

Issues (76)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/CustomerGalleryPage.php (22 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class CustomerGalleryPage extends Page
namespace YourVendor;

class YourClass { }
{
    private static $icon = 'mysite/images/treeicons/CustomerGalleryPage';


    private static $description = 'Gallery of Customer Feedback and Images';


    private static $can_be_root = false;


    private static $allow_children = 'none';


    public function canCreate($member = null)
    {
        return CustomerGalleryPage::get()->count() ? true : false;
    }

    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        $fields->removeByName('FolderID');
        $fields->removeByName('Extensions');
        return $fields;
    }
}

class CustomerGalleryPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    private static $allowed_actions = array(

        "show",
        "Form"
    );

    protected $filter = '', $filterType = '', $filterValue = '', $join = '';


    public function init()
    {
        parent::init();
        PrettyPhoto::include_code();
        Requirements::javascript("mysite/javascript/MediaArticles.js");
    }

    public function PhotoUploadPage()

    {
        return PhotoUploadPage::get()->First();
    }


    public function HasFilter()
    {
        return $this->filter ? true : false;
    }

    public function Location()
    {
        $countries = DB::query("SELECT DISTINCT(\"PictureLocation\") FROM \"CustomerImage\" WHERE \"CustomerImage\".\"Status\" = 'Approved' ORDER BY \"PictureLocation\" ")->keyedColumn();
        return $this->makeDos("location", $countries);
    }

    /*

    function MyPictures() {
        $mypictures = array();
        $member = Member::currentUser();
        if($member) {
            $dos = CustomerImage::get()->filter(array("Status" => 'Approved', "OwnerID" => $member->ID));
            if($dos->count()) {
                foreach($dos as $do) {
                    $mypictures[$member->ID] = "My pictures (".$dos->count().")";
                }
                return $this->makeDos("mypictures", $mypictures);
            }
        }
    }
    */

    public function Product()
    {
        $stage = Versioned::current_stage();
        $productTable = "SiteTree";
        if ($stage) {
            $productTable .= "_".$stage;
        }
        $row = DB::query("SELECT DISTINCT(\"ProductPageID\") AS ProductPageID FROM \"CustomerImage\" INNER JOIN \"$productTable\" ON \"$productTable\".\"ID\" = \"CustomerImage\".\"ProductPageID\" WHERE \"CustomerImage\".\"Status\" = 'Approved' ORDER BY \"$productTable\".\"Title\"");
        $newArray = array();
        foreach ($row as $dataArray) {
            $page = SiteTree::get()->byID($dataArray["ProductPageID"]);

            if ($page) {
                $key = $page->ID;
                $value = $page->Title;
            }
            $newArray[$key] = $value;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
        return $this->makeDos("product", $newArray);
    }

    public function Years()
    {
        $years = DB::query("SELECT DISTINCT(YEAR(\"Created\")) FROM \"CustomerImage\" INNER JOIN \"File\" ON \"File\".\"ID\" = \"CustomerImage\".\"ID\" WHERE \"CustomerImage\".\"Status\" = 'Approved' ORDER BY \"Created\" DESC")->keyedColumn();
        return $this->makeDos("year", $years);
    }

    protected function makeDos($title, $data)
    {
        $dos = new ArrayList();
        //sort($data);
        if ($data && count($data)) {
            foreach ($data as $key => $value) {
                if ($key && $value) {
                    $key = urlencode(preg_replace("/[^a-zA-Z0-9\s]/", "", $key));
                    $do = new DataObject();
                    $do->Code = $key;
                    $do->Name = $value;
                    $do->LinkingMode = (($this->filterType == $title) && ($this->filterValue == $key)) ? "current" : "link";
                    $do->filter = (($this->filterType == $title) && ($this->filterValue == $key)) ? "alwaysfilter" : "filter";
                    $do->Link = $this->Link("show/$title/".$key."/");
                    $dos->push($do);
                }
            }
        }
        if ($dos->count()) {
            return $dos;
        }
        return null;
    }


    public function Items($limit = 0)

    {
        if ($this->SortBy == 'Title') {
            $sort = array("File.Title", "ASC");
        } elseif ($this->SortBy == 'UploadDate ASC') {
            $sort = array("File.Created", "ASC");
        } elseif ($this->SortBy == 'UploadDate DESC') {
            $sort = array("File.Created", "DESC");
        } else {
            $sort = array();
        }
        if ($this->filter) {
            $this->filter .= " AND ";
        }
        $this->filter .= "\"CustomerImage\".\"Status\" = 'Approved' ";
        return CustomerImage::get()->where($this->filter)->sort($sort)->limit($limit);

    }



    public function Form()
    {
        $fields = new FieldList(
            new TextField('Keyword', 'Keyword(s)', $this->value)
            //$date = new DateField('Date')

        );
        //$date->setConfig('showcalendar', true);

        $actions = new FieldList(new FormAction('search', 'Search'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return new Form($this, 'Form', $fields, $actions);
    }


    public function search($data, $form)
    {
        user_error("Not yet updated to 3.0");
        $this->value = $data['Keyword'];
        $data = Convert::raw2sql($data);
        if ($data['Keyword']) {
            $stage = Versioned::current_stage();
            $productTable = "SiteTree";
            if ($stage) {
                $productTable .= "_".$stage;
            }
            $kwords = trim($data['Keyword']);
            $kwordsKWArray=split(" ", $kwords);//Breaking the string to array of words
            // Now let us generate the sql
            $kwordsFilter = array();
            while (list($key, $val) = each($kwordsKWArray)) {
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                $val = trim($val);
                if ($val<>" " and strlen($val) > 0) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    $kwordsFilter[] = " \"Member\".\"ScreenName\" LIKE '%$val%' OR \"$productTable\".\"Title\" LIKE '%$val%' OR \"PictureLocation\" LIKE '%$val%' ";
                }
            }
            $this->filter = " (". implode(" AND ", $kwordsFilter).") ";
            $this->join .= " LEFT JOIN \"$productTable\" ON \"ProductPageID\" = \"$productTable\".\"ID\" " ;
            $this->join .= " INNER JOIN \"Member\" ON \"OwnerID\" = \"Member\".\"ID\" " ;
        }
        return array();
    }

    public function show($request)
    {
        $action = $request->param("ID");
        $value = Convert::raw2sql($request->param("OtherID"));
        switch ($action) {
            case "year":
                $where = "Year(\"File\".\"Created\") = '$value'";
                break;
            case "location":
                $where = "\"PictureLocation\" = '$value'";
                break;
            case "product":
                $where = "\"ProductPageID\" = '$value'";
                break;
            case "mypictures":
                $where = "\"OwnerID\" = '$value'";
                break;
            default:
                $where = "";
        }
        $this->filter = $where;
        $this->filterType = $action;
        $this->filterValue = $value;
        return array();
    }
}


Issues (76)

Security Analysis not enabled

code/CustomerGalleryPage.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Logical Operators are used for Control-Flow

sunnysideup / silverstripe-user_image_upload

Issues (76)

Security Analysis not enabled

code/CustomerGalleryPage.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like