CustomerGalleryPage_Controller

Complexity

Total Complexity

38

Size/Duplication

Total Lines	186
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	6	1
A	PhotoUploadPage()	0	4	1
A	HasFilter()	0	4	2
A	Location()	0	5	1
A	Product()	0	19	4
A	Years()	0	5	1
C	makeDos()	0	23	11
B	Items()	0	17	5
A	Form()	0	10	1
B	search()	0	27	6
B	show()	0	25	5

<?php

class CustomerGalleryPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = 'mysite/images/treeicons/CustomerGalleryPage';

The property $icon is not used and could be removed.

    private static $description = 'Gallery of Customer Feedback and Images';

The property $description is not used and could be removed.

    private static $can_be_root = false;

The property $can_be_root is not used and could be removed.

    private static $allow_children = 'none';

The property $allow_children is not used and could be removed.

    public function canCreate($member = null)
    {
        return CustomerGalleryPage::get()->count() ? true : false;
    }

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->removeByName('FolderID');
        $fields->removeByName('Extensions');
        return $fields;
    }
}

class CustomerGalleryPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        "show",
        "Form"
    );

    protected $filter = '', $filterType = '', $filterValue = '', $join = '';

It is generally advisable to only define one property per statement.

    public function init()
    {
        parent::init();
        PrettyPhoto::include_code();
        Requirements::javascript("mysite/javascript/MediaArticles.js");
    }

    public function PhotoUploadPage()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return PhotoUploadPage::get()->First();
    }


    public function HasFilter()
    {
        return $this->filter ? true : false;
    }

    public function Location()
    {
        $countries = DB::query("SELECT DISTINCT(\"PictureLocation\") FROM \"CustomerImage\" WHERE \"CustomerImage\".\"Status\" = 'Approved' ORDER BY \"PictureLocation\" ")->keyedColumn();
        return $this->makeDos("location", $countries);
    }

    /*

60% of this comment could be valid code. Did you maybe forget this after debugging?

    function MyPictures() {
        $mypictures = array();
        $member = Member::currentUser();
        if($member) {
            $dos = CustomerImage::get()->filter(array("Status" => 'Approved', "OwnerID" => $member->ID));
            if($dos->count()) {
                foreach($dos as $do) {
                    $mypictures[$member->ID] = "My pictures (".$dos->count().")";
                }
                return $this->makeDos("mypictures", $mypictures);
            }
        }
    }
    */

    public function Product()
    {
        $stage = Versioned::current_stage();
        $productTable = "SiteTree";
        if ($stage) {
            $productTable .= "_".$stage;
        }
        $row = DB::query("SELECT DISTINCT(\"ProductPageID\") AS ProductPageID FROM \"CustomerImage\" INNER JOIN \"$productTable\" ON \"$productTable\".\"ID\" = \"CustomerImage\".\"ProductPageID\" WHERE \"CustomerImage\".\"Status\" = 'Approved' ORDER BY \"$productTable\".\"Title\"");
        $newArray = array();
        foreach ($row as $dataArray) {
            $page = SiteTree::get()->byID($dataArray["ProductPageID"]);

The call to get() misses a required argument $callerClass.

            if ($page) {
                $key = $page->ID;
                $value = $page->Title;
            }
            $newArray[$key] = $value;

The variable $key does not seem to be defined for all execution paths leading up to this point.

The variable $value does not seem to be defined for all execution paths leading up to this point.

        }
        return $this->makeDos("product", $newArray);
    }

    public function Years()
    {
        $years = DB::query("SELECT DISTINCT(YEAR(\"Created\")) FROM \"CustomerImage\" INNER JOIN \"File\" ON \"File\".\"ID\" = \"CustomerImage\".\"ID\" WHERE \"CustomerImage\".\"Status\" = 'Approved' ORDER BY \"Created\" DESC")->keyedColumn();
        return $this->makeDos("year", $years);
    }

    protected function makeDos($title, $data)
    {
        $dos = new ArrayList();
        //sort($data);
        if ($data && count($data)) {
            foreach ($data as $key => $value) {
                if ($key && $value) {
                    $key = urlencode(preg_replace("/[^a-zA-Z0-9\s]/", "", $key));
                    $do = new DataObject();
                    $do->Code = $key;
                    $do->Name = $value;
                    $do->LinkingMode = (($this->filterType == $title) && ($this->filterValue == $key)) ? "current" : "link";
                    $do->filter = (($this->filterType == $title) && ($this->filterValue == $key)) ? "alwaysfilter" : "filter";
                    $do->Link = $this->Link("show/$title/".$key."/");
                    $dos->push($do);
                }
            }
        }
        if ($dos->count()) {
            return $dos;
        }
        return null;
    }


    public function Items($limit = 0)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($this->SortBy == 'Title') {
            $sort = array("File.Title", "ASC");
        } elseif ($this->SortBy == 'UploadDate ASC') {
            $sort = array("File.Created", "ASC");
        } elseif ($this->SortBy == 'UploadDate DESC') {
            $sort = array("File.Created", "DESC");
        } else {
            $sort = array();
        }
        if ($this->filter) {
            $this->filter .= " AND ";
        }
        $this->filter .= "\"CustomerImage\".\"Status\" = 'Approved' ";
        return CustomerImage::get()->where($this->filter)->sort($sort)->limit($limit);

The call to get() misses a required argument $callerClass.

    }



    public function Form()
    {
        $fields = new FieldList(
            new TextField('Keyword', 'Keyword(s)', $this->value)
            //$date = new DateField('Date')

50% of this comment could be valid code. Did you maybe forget this after debugging?

        );
        //$date->setConfig('showcalendar', true);

80% of this comment could be valid code. Did you maybe forget this after debugging?

        $actions = new FieldList(new FormAction('search', 'Search'));

'search' is of type string, but the function expects a object<The>.

        return new Form($this, 'Form', $fields, $actions);
    }


    public function search($data, $form)
    {
        user_error("Not yet updated to 3.0");
        $this->value = $data['Keyword'];
        $data = Convert::raw2sql($data);
        if ($data['Keyword']) {
            $stage = Versioned::current_stage();
            $productTable = "SiteTree";
            if ($stage) {
                $productTable .= "_".$stage;
            }
            $kwords = trim($data['Keyword']);
            $kwordsKWArray=split(" ", $kwords);//Breaking the string to array of words
            // Now let us generate the sql
            $kwordsFilter = array();
            while (list($key, $val) = each($kwordsKWArray)) {

The assignment to $key is unused. Consider omitting it like so list($first,,$third).

                $val = trim($val);
                if ($val<>" " and strlen($val) > 0) {

Using logical operators such as and instead of && is generally not recommended.

                    $kwordsFilter[] = " \"Member\".\"ScreenName\" LIKE '%$val%' OR \"$productTable\".\"Title\" LIKE '%$val%' OR \"PictureLocation\" LIKE '%$val%' ";
                }
            }
            $this->filter = " (". implode(" AND ", $kwordsFilter).") ";
            $this->join .= " LEFT JOIN \"$productTable\" ON \"ProductPageID\" = \"$productTable\".\"ID\" " ;
            $this->join .= " INNER JOIN \"Member\" ON \"OwnerID\" = \"Member\".\"ID\" " ;
        }
        return array();
    }

    public function show($request)
    {
        $action = $request->param("ID");
        $value = Convert::raw2sql($request->param("OtherID"));
        switch ($action) {
            case "year":
                $where = "Year(\"File\".\"Created\") = '$value'";
                break;
            case "location":
                $where = "\"PictureLocation\" = '$value'";
                break;
            case "product":
                $where = "\"ProductPageID\" = '$value'";
                break;
            case "mypictures":
                $where = "\"OwnerID\" = '$value'";
                break;
            default:
                $where = "";
        }
        $this->filter = $where;
        $this->filterType = $action;
        $this->filterValue = $value;
        return array();
    }
}