Issues in UpdateNote.php (master) - Issues in master - sunnysideup/silverstripe-update_note - Measure and Improve Code Quality continuously with Scrutinizer

Issues (64)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/UpdateNote.php (41 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


class UpdateNote extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $fields_to_remove_in_the_cms_fields = [];


    private static $singular_name = 'Update Note';


    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Update Notes';


    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    private static $db = array(

        'Note' => 'Varchar',
        'FutureReminderDate' => 'Date',
        'FutureReminderNote' => 'Varchar',
        'FutureReminderCompleted' => 'Boolean',
        'UpdateNoteRecordID' => 'Int',
        'UpdateNoteRecordClass' => 'Varchar(100)'
    );

    private static $has_one = array(

        'UpdatedBy' => 'Member',
        'UpdateNoteRecord' => 'DataObject'
    );

    private static $casting = array(

        'Title' => 'Varchar'
    );

    private static $indexes = array(

        'UpdateNoteRecordID' => true,
        'UpdateNoteRecordClass' => true,
        'FutureReminderNote' => true,
        'FutureReminderDate' => true
    );

    private static $default_sort = array(

        'IF("ClassName" = \'UpdateNoteToBeCompleted\' AND "FutureReminderCompleted" = 0, 0, 1)' => 'ASC',
        'FutureReminderDate' => 'ASC',
        'Created' => 'DESC'
    );

    // private static $required_fields = array();


    private static $summary_fields = array(

        'Created.Nice' => 'When',
        'LastEdited.Nice' => 'Last Edited',
        'UpdateNoteRecord.Title' => 'What',
        'Note' => 'Note',
        'UpdatedBy.Email' => 'Editor',
        'FutureReminderDate.Nice' => 'Future Reminder',
        'FutureReminderNote' => 'Reminder Note'
    );

    private static $field_labels = array(

        'Note' => 'Note',
        'FutureReminderDate' => 'Future Reminder Date',
        'FutureReminderNote' => 'Future Reminder Note',
        'UpdateNoteRecord' => 'What',
        'UpdateNoteRecordClass' => 'Record Type',
        'UpdateNoteRecordID' => 'Record ID',
        'UpdatedBy' => 'Editor'
    );

    /**
     *
     * PartialMatchFilter
     */
    private static $searchable_fields = array(

        'UpdatedByID'  => array(
            'field' => 'UpdateNoteSearchField',
            'filter' => 'ExactMatchFilter',
            'title' => 'Edited By'
        ),
        'Note' => 'PartialMatchFilter',
        'FutureReminderDate' => 'PartialMatchFilter',
        'FutureReminderNote' => 'PartialMatchFilter',
    );


    protected function getEditorsDropdown()
    {
        $admins = EcommerceRole::list_of_admins(true);
        return DropdownField::create(
            'UpdatedByID',
            'Edited By',
            $admins
        );
    }

    /**
     * e.g.
     *    $controller = singleton("MyModelAdmin");
     *    return $controller->Link().$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/edit";
      */
    public function CMSEditLink()
    {
        return Controller::join_links(
            Director::baseURL(),
            "/admin/updatenotes/".$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/edit"
        );
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->insertBefore(ReadonlyField::create('Created'), 'Note');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $fields->insertBefore(ReadonlyField::create('LastEdited'), 'Note');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $fieldLabels = $this->fieldLabels();
        $fields->removeByName('UpdateNoteRecordClass');
        $fields->removeByName('UpdateNoteRecordID');

        $otherFieldsToRemove = $this->Config()->get('fields_to_remove_in_the_cms_fields');
        foreach ($otherFieldsToRemove as $field) {
            $fields->removeByName($field);
            // code...
        }
        $fields->insertBefore(
            ReadonlyField::create(
                'Created'
            ),
            'Note'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $fields->insertBefore(
            ReadonlyField::create(
                'LastEdited'
            ),
            'Note'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        if ($whoField = $fields->dataFieldByName('UpdatedByID')) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $fields->removeFieldFromTab('Root.Main', 'UpdatedByID');
            $who = $this->UpdatedBy();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($who && $who->exists()) {
                if ($who->hasMethod('CMSEditLink')) {

                    $fields->addFieldToTab(
                        'Root.Main',
                        $whoField = ReadonlyField::create(
                            'UpdatedByLink',
                            $fieldLabels['UpdatedBy'],
                            '<h2><a href="'.$who->CMSEditLink().'" target="_blank">'.$who->getTitle().'</a></h2>'
                        )
                    );
                } else {
                    $fields->addFieldToTab(
                        'Root.Main',
                        $whoField = ReadonlyField::create(
                            'UpdatedByLink',
                            $fieldLabels['UpdatedBy'],
                            '<h2>'.$who->getTitle().'.</h2>'
                        )
                    );
                }
            } else {
                $fields->addFieldToTab(
                    'Root.Main',
                    $whoField = ReadonlyField::create(
                        'UpdatedByLink',
                        $fieldLabels['UpdatedBy'],
                        '<p class="message warning">no editor found</p>'
                    )
                );
            }
            $whoField->dontEscape = true;
        }

        if ($parent = $this->getParent()) {
            if ($parent->hasMethod('CMSEditLink')) {

                $fields->addFieldToTab(
                    'Root.Main',
                    $parentField = ReadonlyField::create(
                        'ParentLink',
                        $fieldLabels['UpdateNoteRecord'],
                        '<h2><a href="'.$parent->CMSEditLink().'" target="_blank">'.$parent->getTitle().'</a></h2>'
                    )
                );
            } else {
                $fields->addFieldToTab(
                    'Root.Main',
                    $parentField = ReadonlyField::create(
                        'ParentLink',
                        $fieldLabels['UpdateNoteRecord'],
                        '<h2>'.$parent->getTitle().'</h2>'
                    )
                );
            }
            $parentField->dontEscape = true;
        }
        return $fields;
    }

    public function getParentField($fieldLabels = null, $linkMethod = 'CMSEditLink')
    {
        if ($fieldLabels === null) {
            $fieldLabels = $this->fieldLabels();
        }
        $parentField = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($parent = $this->owner->getParent()) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($parent->hasMethod($linkMethod)) {
                $parentField = ReadonlyField::create(
                    'ParentLink',
                    $fieldLabels['UpdateNoteRecord'],
                    '<p><a href="'.$parent->$linkMethod().'" target="_blank">'.$parent->getTitle().'</a></p>'
                );
            } else {
                $parentField = ReadonlyField::create(
                    'ParentLink',
                    $fieldLabels['UpdateNoteRecord'],
                    '<p>'.$parent->getTitle().'</p>'
                );
            }
            $parentField->dontEscape = true;
        } else {
            $parentField = LiteralField::create('ParentLink', '<p class="message bad">No parent found</p>');
        }
        return $parentField;
    }

    public function getParent()

    {
        if ($obj = $this->UpdateNoteRecord()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $obj;
        } else {
            $className = $this->UpdateNoteRecordClass;

            if ($className && class_exists($className)) {
                $id =  intval($this->UpdateNoteRecordID);

                if ($id) {
                    return $className::get()->byID($id);
                }
            }
        }
    }


    /**
     * Event handler called before writing to the database.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->FutureReminderCompleted && $this instanceof UpdateNoteToBeCompleted) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ClassName = 'UpdateNote';
        } elseif ($this->FutureReminderDate && ! $this instanceof UpdateNoteToBeCompleted) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ClassName = 'UpdateNoteToBeCompleted';
        } elseif (!$this->FutureReminderDate && $this instanceof UpdateNoteToBeCompleted) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ClassName = 'UpdateNote';
        }
    }
    /**
     * Creating Permissions
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * Editing Permissions
     * @return bool

     */
    public function canEdit($member = null)
    {
        return parent::canEdit();
    }

    /**
     * Deleting Permissions
     * @return bool
     */
    public function canDelete($member = null)
    {
        return false;
    }

    public function getTitle()
    {
        $obj = $this->getParent();
        if ($obj && $obj->exists()) {
            $titleArray = array($this->Created, $obj->getTitle());
            if ($this->Note) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                array_push($titleArray, $this->Note);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return implode(' - ', $titleArray);
        }
    }
}


1			<?php
2
3
4			class UpdateNote extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $fields_to_remove_in_the_cms_fields = [];
			0 ignored issues – show Unused Code introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$fields_to_remove_in_the_cms_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7
8			private static $singular_name = 'Update Note';
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
9
10			public function i18n_singular_name()
11			{
12			return self::$singular_name;
13			}
14
15			private static $plural_name = 'Update Notes';
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
16
17			public function i18n_plural_name()
18			{
19			return self::$plural_name;
20			}
21
22			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
23			'Note' => 'Varchar',
24			'FutureReminderDate' => 'Date',
25			'FutureReminderNote' => 'Varchar',
26			'FutureReminderCompleted' => 'Boolean',
27			'UpdateNoteRecordID' => 'Int',
28			'UpdateNoteRecordClass' => 'Varchar(100)'
29			);
30
31			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
32			'UpdatedBy' => 'Member',
33			'UpdateNoteRecord' => 'DataObject'
34			);

sunnysideup / silverstripe-update_note

Issues (64)

Security Analysis not enabled

code/model/UpdateNote.php (41 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like