UpdateNote - Code Metrics - sunnysideup/silverstripe-update_note - Measure and Improve Code Quality continuously with Scrutinizer

UpdateNote A
last analyzed 2018-05-25 05:54 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	297
Duplicated Lines	12.79 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes

Metric	Value
wmc	35
lcom	2
cbo	7
dl	38
loc	297
rs	9
c	0
b	0
f	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	getEditorsDropdown()	0	9	1
A	CMSEditLink()	0	7	1
C	getCMSFields()	38	86	8
B	getParentField()	0	26	4
B	getParent()	0	14	5
B	onBeforeWrite()	0	11	7
A	canCreate()	0	4	1
A	canEdit()	0	4	1
A	canDelete()	0	4	1
A	getTitle()	0	11	4

How to fix Duplicated Code

<?php


class UpdateNote extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $fields_to_remove_in_the_cms_fields = [];


    private static $singular_name = 'Update Note';


    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Update Notes';


    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    private static $db = array(

        'Note' => 'Varchar',
        'FutureReminderDate' => 'Date',
        'FutureReminderNote' => 'Varchar',
        'FutureReminderCompleted' => 'Boolean',
        'UpdateNoteRecordID' => 'Int',
        'UpdateNoteRecordClass' => 'Varchar(100)'
    );

    private static $has_one = array(

        'UpdatedBy' => 'Member',
        'UpdateNoteRecord' => 'DataObject'
    );

    private static $casting = array(

        'Title' => 'Varchar'
    );

    private static $indexes = array(

        'UpdateNoteRecordID' => true,
        'UpdateNoteRecordClass' => true,
        'FutureReminderNote' => true,
        'FutureReminderDate' => true
    );

    private static $default_sort = array(

        'IF("ClassName" = \'UpdateNoteToBeCompleted\' AND "FutureReminderCompleted" = 0, 0, 1)' => 'ASC',
        'FutureReminderDate' => 'ASC',
        'Created' => 'DESC'
    );

    // private static $required_fields = array();


    private static $summary_fields = array(

        'Created.Nice' => 'When',
        'LastEdited.Nice' => 'Last Edited',
        'UpdateNoteRecord.Title' => 'What',
        'Note' => 'Note',
        'UpdatedBy.Email' => 'Editor',
        'FutureReminderDate.Nice' => 'Future Reminder',
        'FutureReminderNote' => 'Reminder Note'
    );

    private static $field_labels = array(

        'Note' => 'Note',
        'FutureReminderDate' => 'Future Reminder Date',
        'FutureReminderNote' => 'Future Reminder Note',
        'UpdateNoteRecord' => 'What',
        'UpdateNoteRecordClass' => 'Record Type',
        'UpdateNoteRecordID' => 'Record ID',
        'UpdatedBy' => 'Editor'
    );

    /**
     *
     * PartialMatchFilter
     */
    private static $searchable_fields = array(

        'UpdatedByID'  => array(
            'field' => 'UpdateNoteSearchField',
            'filter' => 'ExactMatchFilter',
            'title' => 'Edited By'
        ),
        'Note' => 'PartialMatchFilter',
        'FutureReminderDate' => 'PartialMatchFilter',
        'FutureReminderNote' => 'PartialMatchFilter',
    );


    protected function getEditorsDropdown()
    {
        $admins = EcommerceRole::list_of_admins(true);
        return DropdownField::create(
            'UpdatedByID',
            'Edited By',
            $admins
        );
    }

    /**
     * e.g.
     *    $controller = singleton("MyModelAdmin");
     *    return $controller->Link().$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/edit";
      */
    public function CMSEditLink()
    {
        return Controller::join_links(
            Director::baseURL(),
            "/admin/updatenotes/".$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/edit"
        );
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->insertBefore(ReadonlyField::create('Created'), 'Note');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $fields->insertBefore(ReadonlyField::create('LastEdited'), 'Note');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $fieldLabels = $this->fieldLabels();
        $fields->removeByName('UpdateNoteRecordClass');
        $fields->removeByName('UpdateNoteRecordID');

        $otherFieldsToRemove = $this->Config()->get('fields_to_remove_in_the_cms_fields');
        foreach ($otherFieldsToRemove as $field) {
            $fields->removeByName($field);
            // code...
        }
        $fields->insertBefore(
            ReadonlyField::create(
                'Created'
            ),
            'Note'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $fields->insertBefore(
            ReadonlyField::create(
                'LastEdited'
            ),
            'Note'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        if ($whoField = $fields->dataFieldByName('UpdatedByID')) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $fields->removeFieldFromTab('Root.Main', 'UpdatedByID');
            $who = $this->UpdatedBy();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($who && $who->exists()) {
                if ($who->hasMethod('CMSEditLink')) {

                    $fields->addFieldToTab(
                        'Root.Main',
                        $whoField = ReadonlyField::create(
                            'UpdatedByLink',
                            $fieldLabels['UpdatedBy'],
                            '<h2><a href="'.$who->CMSEditLink().'" target="_blank">'.$who->getTitle().'</a></h2>'
                        )
                    );
                } else {
                    $fields->addFieldToTab(
                        'Root.Main',
                        $whoField = ReadonlyField::create(
                            'UpdatedByLink',
                            $fieldLabels['UpdatedBy'],
                            '<h2>'.$who->getTitle().'.</h2>'
                        )
                    );
                }
            } else {
                $fields->addFieldToTab(
                    'Root.Main',
                    $whoField = ReadonlyField::create(
                        'UpdatedByLink',
                        $fieldLabels['UpdatedBy'],
                        '<p class="message warning">no editor found</p>'
                    )
                );
            }
            $whoField->dontEscape = true;
        }

        if ($parent = $this->getParent()) {
            if ($parent->hasMethod('CMSEditLink')) {

                $fields->addFieldToTab(
                    'Root.Main',
                    $parentField = ReadonlyField::create(
                        'ParentLink',
                        $fieldLabels['UpdateNoteRecord'],
                        '<h2><a href="'.$parent->CMSEditLink().'" target="_blank">'.$parent->getTitle().'</a></h2>'
                    )
                );
            } else {
                $fields->addFieldToTab(
                    'Root.Main',
                    $parentField = ReadonlyField::create(
                        'ParentLink',
                        $fieldLabels['UpdateNoteRecord'],
                        '<h2>'.$parent->getTitle().'</h2>'
                    )
                );
            }
            $parentField->dontEscape = true;
        }
        return $fields;
    }

    public function getParentField($fieldLabels = null, $linkMethod = 'CMSEditLink')
    {
        if ($fieldLabels === null) {
            $fieldLabels = $this->fieldLabels();
        }
        $parentField = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($parent = $this->owner->getParent()) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($parent->hasMethod($linkMethod)) {
                $parentField = ReadonlyField::create(
                    'ParentLink',
                    $fieldLabels['UpdateNoteRecord'],
                    '<p><a href="'.$parent->$linkMethod().'" target="_blank">'.$parent->getTitle().'</a></p>'
                );
            } else {
                $parentField = ReadonlyField::create(
                    'ParentLink',
                    $fieldLabels['UpdateNoteRecord'],
                    '<p>'.$parent->getTitle().'</p>'
                );
            }
            $parentField->dontEscape = true;
        } else {
            $parentField = LiteralField::create('ParentLink', '<p class="message bad">No parent found</p>');
        }
        return $parentField;
    }

    public function getParent()

    {
        if ($obj = $this->UpdateNoteRecord()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $obj;
        } else {
            $className = $this->UpdateNoteRecordClass;

            if ($className && class_exists($className)) {
                $id =  intval($this->UpdateNoteRecordID);

                if ($id) {
                    return $className::get()->byID($id);
                }
            }
        }
    }


    /**
     * Event handler called before writing to the database.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->FutureReminderCompleted && $this instanceof UpdateNoteToBeCompleted) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ClassName = 'UpdateNote';
        } elseif ($this->FutureReminderDate && ! $this instanceof UpdateNoteToBeCompleted) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ClassName = 'UpdateNoteToBeCompleted';
        } elseif (!$this->FutureReminderDate && $this instanceof UpdateNoteToBeCompleted) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ClassName = 'UpdateNote';
        }
    }
    /**
     * Creating Permissions
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * Editing Permissions
     * @return bool

     */
    public function canEdit($member = null)
    {
        return parent::canEdit();
    }

    /**
     * Deleting Permissions
     * @return bool
     */
    public function canDelete($member = null)
    {
        return false;
    }

    public function getTitle()
    {
        $obj = $this->getParent();
        if ($obj && $obj->exists()) {
            $titleArray = array($this->Created, $obj->getTitle());
            if ($this->Note) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                array_push($titleArray, $this->Note);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return implode(' - ', $titleArray);
        }
    }
}


1			<?php
2
3
4			class UpdateNote extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $fields_to_remove_in_the_cms_fields = [];
			0 ignored issues – show Unused Code introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report The property `$fields_to_remove_in_the_cms_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7
8			private static $singular_name = 'Update Note';
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
9
10			public function i18n_singular_name()
11			{
12			return self::$singular_name;
13			}
14
15			private static $plural_name = 'Update Notes';
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
16
17			public function i18n_plural_name()
18			{
19			return self::$plural_name;
20			}
21
22			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
23			'Note' => 'Varchar',
24			'FutureReminderDate' => 'Date',
25			'FutureReminderNote' => 'Varchar',
26			'FutureReminderCompleted' => 'Boolean',
27			'UpdateNoteRecordID' => 'Int',
28			'UpdateNoteRecordClass' => 'Varchar(100)'
29			);
30
31			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-05-23 17:38 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
32			'UpdatedBy' => 'Member',
33			'UpdateNoteRecord' => 'DataObject'
34			);

sunnysideup / silverstripe-update_note

UpdateNote A last analyzed 2018-05-25 05:54 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

UpdateNote A
last analyzed 2018-05-25 05:54 UTC