TrainingMemberDecorator::createOrMerge() - Code Metrics - sunnysideup/silverstripe-traininglistingsandsignup - Measure and Improve Code Quality continuously with Scrutinizer

TrainingMemberDecorator::createOrMerge() C
last analyzed 2018-03-20 01:36 UTC

↳ Parent: TrainingMemberDecorator

Complexity

Conditions	8
Paths	14

Size

Total Lines	28
Code Lines	14

Duplication

Lines	12
Ratio	42.86 %

Importance

Changes

Metric	Value
dl	12
loc	28
rs	5.3846
c	0
b	0
f	0
cc	8
eloc	14
nc	14
nop	1

<?php
/**
 *
 * @author nicolaas [at] sunnysideup.co.nz
 */
class TrainingMemberDecorator extends DataExtension
namespace YourVendor;

class YourClass { }
{
    private static $belongs_many_many = array(

        'Training' => 'TrainingPage'
    );
    private static $db = array(

        'Organisation' => 'Varchar',
        'Phone' => 'Varchar'
    );



    public function getTrainingFields()
    {
        $fields = new FieldList(
            new TextField('FirstName', 'First Name'),
            new TextField('Surname', 'Surname'),
            new TextField('Organisation'),
            new EmailField('Email', 'Email'),
            new TextField('Phone')
        );
        return $fields;
    }

    public function getTrainingRequiredFields()
    {
        $fields = array(
            'FirstName',
            'Surname',
            'Organisation',
            'Email',
            'Phone'
        );
        return $fields;
    }

    public static function createOrMerge($data)
    {
        // Because we are using a ConfirmedPasswordField, the password will
        // be an array of two fields
        if (isset($data['Password']) && is_array($data['Password'])) {

            $data['Password'] = $data['Password']['_Password'];
        }

        // We need to ensure that the unique field is never overwritten
        $uniqueField = Member::get_unique_identifier_field();

        if (isset($data[$uniqueField])) {

            $SQL_unique = Convert::raw2sql($data[$uniqueField]);
            $existingUniqueMember = Member::get()->filter(array($uniqueField => $SQL_unique))->first();
            if ($existingUniqueMember && $existingUniqueMember->exists()) {
                if (Member::currentUserID() != $existingUniqueMember->ID) {
                    return false;
                }
            }
        }

        if (!$member = Member::currentUser()) {
            $member = new Member();
        }

        $member->update($data);

        return $member;
    }
}


1		<?php
2		/**
3		*
4		* @author nicolaas [at] sunnysideup.co.nz
5		*/
6		class TrainingMemberDecorator extends DataExtension
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:37 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		private static $belongs_many_many = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:37 UTC by Report Bug Copy Issue Report The property `$belongs_many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9		'Training' => 'TrainingPage'
10		);
11		private static $db = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:37 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12		'Organisation' => 'Varchar',
13		'Phone' => 'Varchar'
14		);
15
16
17
18		public function getTrainingFields()
19		{
20		$fields = new FieldList(
21		new TextField('FirstName', 'First Name'),
22		new TextField('Surname', 'Surname'),
23		new TextField('Organisation'),
24		new EmailField('Email', 'Email'),
25		new TextField('Phone')
26		);
27		return $fields;
28		}
29
30		public function getTrainingRequiredFields()
31		{
32		$fields = array(
33		'FirstName',
34		'Surname',
35		'Organisation',
36		'Email',
37		'Phone'
38		);
39		return $fields;
40		}
41
42		public static function createOrMerge($data)
43		{
44		// Because we are using a ConfirmedPasswordField, the password will
45		// be an array of two fields
46	View Code Duplication	if (isset($data['Password']) && is_array($data['Password'])) {
		0 ignored issues – show Duplication introduced 2017-01-03 01:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		$data['Password'] = $data['Password']['_Password'];
48		}
49
50		// We need to ensure that the unique field is never overwritten
51		$uniqueField = Member::get_unique_identifier_field();
		0 ignored issues – show Deprecated Code introduced 2017-01-03 01:37 UTC by Report Bug Copy Issue Report The method `Member::get_unique_identifier_field()` has been deprecated with message: 4.0 Use the "Member.unique_identifier_field" config setting instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
52	View Code Duplication	if (isset($data[$uniqueField])) {
		0 ignored issues – show Duplication introduced 2017-01-03 01:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		$SQL_unique = Convert::raw2sql($data[$uniqueField]);
54		$existingUniqueMember = Member::get()->filter(array($uniqueField => $SQL_unique))->first();
55		if ($existingUniqueMember && $existingUniqueMember->exists()) {
56		if (Member::currentUserID() != $existingUniqueMember->ID) {
57		return false;
58		}
59		}
60		}
61
62		if (!$member = Member::currentUser()) {
63		$member = new Member();
64		}
65
66		$member->update($data);
67
68		return $member;
69		}
70		}
71

sunnysideup / silverstripe-traininglistingsandsignup

TrainingMemberDecorator::createOrMerge() C last analyzed 2018-03-20 01:36 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TrainingMemberDecorator::createOrMerge() C
last analyzed 2018-03-20 01:36 UTC