TrainingMemberDecorator

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	18.46 %

Coupling/Cohesion

Components	0
Dependencies	8

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getTrainingFields()	0	11	1
A	getTrainingRequiredFields()	0	11	1
C	createOrMerge()	12	28	8

<?php
/**
 *
 * @author nicolaas [at] sunnysideup.co.nz
 */
class TrainingMemberDecorator extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $belongs_many_many = array(

The property $belongs_many_many is not used and could be removed.

        'Training' => 'TrainingPage'
    );
    private static $db = array(

The property $db is not used and could be removed.

        'Organisation' => 'Varchar',
        'Phone' => 'Varchar'
    );



    public function getTrainingFields()
    {
        $fields = new FieldList(
            new TextField('FirstName', 'First Name'),
            new TextField('Surname', 'Surname'),
            new TextField('Organisation'),
            new EmailField('Email', 'Email'),
            new TextField('Phone')
        );
        return $fields;
    }

    public function getTrainingRequiredFields()
    {
        $fields = array(
            'FirstName',
            'Surname',
            'Organisation',
            'Email',
            'Phone'
        );
        return $fields;
    }

    public static function createOrMerge($data)
    {
        // Because we are using a ConfirmedPasswordField, the password will
        // be an array of two fields
        if (isset($data['Password']) && is_array($data['Password'])) {

This code seems to be duplicated across your project.

            $data['Password'] = $data['Password']['_Password'];
        }

        // We need to ensure that the unique field is never overwritten
        $uniqueField = Member::get_unique_identifier_field();

The method Member::get_unique_identifier_field() has been deprecated with message: 4.0 Use the "Member.unique_identifier_field" config setting instead

        if (isset($data[$uniqueField])) {

This code seems to be duplicated across your project.

            $SQL_unique = Convert::raw2sql($data[$uniqueField]);
            $existingUniqueMember = Member::get()->filter(array($uniqueField => $SQL_unique))->first();
            if ($existingUniqueMember && $existingUniqueMember->exists()) {
                if (Member::currentUserID() != $existingUniqueMember->ID) {
                    return false;
                }
            }
        }

        if (!$member = Member::currentUser()) {
            $member = new Member();
        }

        $member->update($data);

        return $member;
    }
}