Issues in MemberRoleSmartChimpExtension.php (master) - Issues in master - sunnysideup/silverstripe-smartchimp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/security/MemberRoleSmartChimpExtension.php (7 issues)

Labels

Severity

Minor 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 * @author nicolaas[at]sunnysideup.co.nz
 * @description: adds a newsletter tickbox to member
 *
 **/

class MemberRoleSmartChimpExtension extends DataObjectDecorator
namespace YourVendor;

class YourClass { }
{
    protected static $sign_up_checkbox_label = 'Sign-up for newsletter';
    public static function set_sign_up_checkbox_label($v)
    {
        self::$sign_up_checkbox_label = $v;
    }
    public static function get_sign_up_checkbox_label()
    {
        return self::$sign_up_checkbox_label;
    }


    public function extraDBFields()
    {
        return array(
            'db' => array(
                'SignUpForMailChimpNewsletter' => 'Boolean'
            )
        );
    }


    public function updateCMSFields($fields)

    {
        if ($this->signupPage()) {
            $fields->addFieldToTab('Root.Main', new CheckboxField('SignUpForMailChimpNewsletter', self::get_sign_up_checkbox_label()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return $fields;
    }

    /**
     * Return the member fields to be shown on {@link OrderForm}.
     * @return FieldSet
     */
    public function augmentEcommerceFields($fields)
    {
        if ($this->signupPage()) {
            $fields = $fields->push(new CheckboxField('SignUpForMailChimpNewsletter', self::get_sign_up_checkbox_label()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return $fields;
    }


    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->owner->changed) {

            if (isset($this->owner->changed["SignUpForMailChimpNewsletter"])) {
                if ($page = $this->signupPage()) {
                    if ($this->owner->SignUpForMailChimpNewsletter) {
                        $outcome = $page->subscribe($this->owner->Email, $this->owner->FirstName, $this->owner->Surname);
                        if ($outcome !== true) {
                            $subject = "error subscribing ".$this->owner->Email.' ('.$this->owner->ID.'): -- '.$outcome.' -- on '.$page->Title.' ACTION REQUIRED';
                            USER_ERROR($subject, E_USER_WARNING);
                            $e = new Email($from = Email::getAdminEmail(), $to = Email::getAdminEmail(), $subject, $subject);
                            $e->send();
                        }
                    } else {
                        $outcome = $page->unsubscribe($this->owner->Email, $this->owner->FirstName, $this->owner->Surname);
                        if ($outcome !== true) {
                            $subject = "error unsubscribing ".$this->owner->Email.' ('.$this->owner->ID.'): -- '.$outcome.' -- on '.$page->Title.' ACTION REQUIRED';
                            USER_ERROR($subject, E_USER_WARNING);
                            mail(Email::getAdminEmail(), $subject, $subject);
                            $e = new Email($from = Email::getAdminEmail(), $to = Email::getAdminEmail(), $subject, $subject);
                            $e->send();
                        }
                    }
                } else {
                    USER_ERROR("There is no default newsletter page setup. This means the person can not be subscribed to the newsletter", E_USER_WARNING);
                }
            }
        }
    }

    public function signupPage()
    {
        return DataObject::get_one("SmartChimpSignupPage", "`IsDefaultList` = 1");
    }
}


1			<?php
2			/**
3			*
4			* @author nicolaas[at]sunnysideup.co.nz
5			* @description: adds a newsletter tickbox to member
6			*
7			**/
8
9			class MemberRoleSmartChimpExtension extends DataObjectDecorator
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			protected static $sign_up_checkbox_label = 'Sign-up for newsletter';
12			public static function set_sign_up_checkbox_label($v)
13			{
14			self::$sign_up_checkbox_label = $v;
15			}
16			public static function get_sign_up_checkbox_label()
17			{
18			return self::$sign_up_checkbox_label;
19			}
20
21
22			public function extraDBFields()
23			{
24			return array(
25			'db' => array(
26			'SignUpForMailChimpNewsletter' => 'Boolean'
27			)
28			);
29			}
30
31
32			public function updateCMSFields($fields)
			0 ignored issues – show Documentation introduced 2018-02-21 04:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
33			{
34			if ($this->signupPage()) {
35			$fields->addFieldToTab('Root.Main', new CheckboxField('SignUpForMailChimpNewsletter', self::get_sign_up_checkbox_label()));
			0 ignored issues – show Documentation introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'SignUpForMailChimpNewsletter'` is of type `string`, but the function expects a `object<The>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `self::get_sign_up_checkbox_label()` is of type `string`, but the function expects a `object<The>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			}
37			return $fields;
38			}
39
40			/**
41			* Return the member fields to be shown on {@link OrderForm}.
42			* @return FieldSet
43			*/
44			public function augmentEcommerceFields($fields)
45			{
46			if ($this->signupPage()) {
47			$fields = $fields->push(new CheckboxField('SignUpForMailChimpNewsletter', self::get_sign_up_checkbox_label()));
			0 ignored issues – show Documentation introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'SignUpForMailChimpNewsletter'` is of type `string`, but the function expects a `object<The>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `self::get_sign_up_checkbox_label()` is of type `string`, but the function expects a `object<The>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			}
49			return $fields;
50			}
51
52
53			public function onAfterWrite()
54			{
55			parent::onAfterWrite();
56			if ($this->owner->changed) {
			0 ignored issues – show Bug Best Practice introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->owner->changed` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
57			if (isset($this->owner->changed["SignUpForMailChimpNewsletter"])) {
58			if ($page = $this->signupPage()) {
59			if ($this->owner->SignUpForMailChimpNewsletter) {
60			$outcome = $page->subscribe($this->owner->Email, $this->owner->FirstName, $this->owner->Surname);
61			if ($outcome !== true) {
62			$subject = "error subscribing ".$this->owner->Email.' ('.$this->owner->ID.'): -- '.$outcome.' -- on '.$page->Title.' ACTION REQUIRED';
63			USER_ERROR($subject, E_USER_WARNING);
64			$e = new Email($from = Email::getAdminEmail(), $to = Email::getAdminEmail(), $subject, $subject);
65			$e->send();
66			}
67			} else {
68			$outcome = $page->unsubscribe($this->owner->Email, $this->owner->FirstName, $this->owner->Surname);
69			if ($outcome !== true) {
70			$subject = "error unsubscribing ".$this->owner->Email.' ('.$this->owner->ID.'): -- '.$outcome.' -- on '.$page->Title.' ACTION REQUIRED';
71			USER_ERROR($subject, E_USER_WARNING);
72			mail(Email::getAdminEmail(), $subject, $subject);
73			$e = new Email($from = Email::getAdminEmail(), $to = Email::getAdminEmail(), $subject, $subject);
74			$e->send();
75			}
76			}
77			} else {
78			USER_ERROR("There is no default newsletter page setup. This means the person can not be subscribed to the newsletter", E_USER_WARNING);
79			}
80			}
81			}
82			}
83
84			public function signupPage()
85			{
86			return DataObject::get_one("SmartChimpSignupPage", "`IsDefaultList` = 1");
87			}
88			}
89

sunnysideup / silverstripe-smartchimp

Issues (56)

Security Analysis not enabled

code/security/MemberRoleSmartChimpExtension.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like