MemberRoleSmartChimpExtension

Complexity

Total Complexity

15

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	set_sign_up_checkbox_label()	0	4	1
A	get_sign_up_checkbox_label()	0	4	1
A	extraDBFields()	0	8	1
A	updateCMSFields()	0	7	2
A	augmentEcommerceFields()	0	7	2
C	onAfterWrite()	0	30	7
A	signupPage()	0	4	1

<?php
/**
 *
 * @author nicolaas[at]sunnysideup.co.nz
 * @description: adds a newsletter tickbox to member
 *
 **/

class MemberRoleSmartChimpExtension extends DataObjectDecorator

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected static $sign_up_checkbox_label = 'Sign-up for newsletter';
    public static function set_sign_up_checkbox_label($v)
    {
        self::$sign_up_checkbox_label = $v;
    }
    public static function get_sign_up_checkbox_label()
    {
        return self::$sign_up_checkbox_label;
    }


    public function extraDBFields()
    {
        return array(
            'db' => array(
                'SignUpForMailChimpNewsletter' => 'Boolean'
            )
        );
    }


    public function updateCMSFields($fields)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($this->signupPage()) {
            $fields->addFieldToTab('Root.Main', new CheckboxField('SignUpForMailChimpNewsletter', self::get_sign_up_checkbox_label()));

'SignUpForMailChimpNewsletter' is of type string, but the function expects a object<The>.

self::get_sign_up_checkbox_label() is of type string, but the function expects a object<The>|null.

        }
        return $fields;
    }

    /**
     * Return the member fields to be shown on {@link OrderForm}.
     * @return FieldSet
     */
    public function augmentEcommerceFields($fields)
    {
        if ($this->signupPage()) {
            $fields = $fields->push(new CheckboxField('SignUpForMailChimpNewsletter', self::get_sign_up_checkbox_label()));

'SignUpForMailChimpNewsletter' is of type string, but the function expects a object<The>.

self::get_sign_up_checkbox_label() is of type string, but the function expects a object<The>|null.

        }
        return $fields;
    }


    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->owner->changed) {

The expression $this->owner->changed of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            if (isset($this->owner->changed["SignUpForMailChimpNewsletter"])) {
                if ($page = $this->signupPage()) {
                    if ($this->owner->SignUpForMailChimpNewsletter) {
                        $outcome = $page->subscribe($this->owner->Email, $this->owner->FirstName, $this->owner->Surname);
                        if ($outcome !== true) {
                            $subject = "error subscribing ".$this->owner->Email.' ('.$this->owner->ID.'): -- '.$outcome.' -- on '.$page->Title.' ACTION REQUIRED';
                            USER_ERROR($subject, E_USER_WARNING);
                            $e = new Email($from = Email::getAdminEmail(), $to = Email::getAdminEmail(), $subject, $subject);
                            $e->send();
                        }
                    } else {
                        $outcome = $page->unsubscribe($this->owner->Email, $this->owner->FirstName, $this->owner->Surname);
                        if ($outcome !== true) {
                            $subject = "error unsubscribing ".$this->owner->Email.' ('.$this->owner->ID.'): -- '.$outcome.' -- on '.$page->Title.' ACTION REQUIRED';
                            USER_ERROR($subject, E_USER_WARNING);
                            mail(Email::getAdminEmail(), $subject, $subject);
                            $e = new Email($from = Email::getAdminEmail(), $to = Email::getAdminEmail(), $subject, $subject);
                            $e->send();
                        }
                    }
                } else {
                    USER_ERROR("There is no default newsletter page setup. This means the person can not be subscribed to the newsletter", E_USER_WARNING);
                }
            }
        }
    }

    public function signupPage()
    {
        return DataObject::get_one("SmartChimpSignupPage", "`IsDefaultList` = 1");
    }
}