Passed
Push — master ( 0b9e04...7d8f18 )
by Nicolaas
03:46
created
src/Tasks/SiteWideSearch.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,12 +40,12 @@
 block discarded – undo
40 40
         Environment::increaseMemoryLimitTo(-1);
41 41
         $debug = $request->postVar('debug') ? 'checked="checked"' : '';
42 42
         $word = Convert::raw2sql($request->requestVar('word'));
43
-        if (! is_string($word)) {
43
+        if (!is_string($word)) {
44 44
             $word = '';
45 45
         }
46 46
 
47 47
         $replace = Convert::raw2sql($request->requestVar('replace'));
48
-        if (! is_string($replace)) {
48
+        if (!is_string($replace)) {
49 49
             $replace = '';
50 50
         }
51 51
 
Please login to merge, or discard this patch.
src/Helpers/FindEditableObjects.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -285,8 +285,8 @@
 block discarded – undo
285 285
 
286 286
     protected function classCanBeIncluded(string $dataObjectClassName): bool
287 287
     {
288
-        if(count($this->excludedClasses) || count($this->includedClasses)) {
289
-            if(!class_exists($dataObjectClassName)) {
288
+        if (count($this->excludedClasses) || count($this->includedClasses)) {
289
+            if (!class_exists($dataObjectClassName)) {
290 290
                 return false;
291 291
             }
292 292
             if (count($this->includedClasses)) {
Please login to merge, or discard this patch.
src/Admin/SearchAdmin.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
                 _t(__CLASS__ . '.ReplaceToggle', 'Replace with ... (optional - make a backup first!)'),
91 91
                 [
92 92
                     (new CheckboxField('ApplyReplace', 'Run replace (please make sure to make a backup first!)', $this->applyReplace))
93
-                      ->setDescription('Check this to replace the searched value set above with its replacement value. Note that searches ignore uppercase / lowercase, but replace actions will only search and replace values with the same upper / lowercase.'),
93
+                        ->setDescription('Check this to replace the searched value set above with its replacement value. Note that searches ignore uppercase / lowercase, but replace actions will only search and replace values with the same upper / lowercase.'),
94 94
                     (new TextField('ReplaceWith', 'Replace (optional - careful!)', $this->replace ?? ''))
95 95
                         ->setAttribute('placeholder', 'e.g. contract - make sure to also tick checkbox below'),
96 96
                 ]
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
56 56
 
57 57
     protected function init()
58 58
     {
59
-        if($this->request->param('Action')) {
60
-            if(empty($this->request->postVars())) {
59
+        if ($this->request->param('Action')) {
60
+            if (empty($this->request->postVars())) {
61 61
                 $this->redirect('/admin/find');
62 62
             }
63 63
         }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         if (!$this->getRequest()->requestVar('Keywords')) {
112 112
             $lastResults = $this->lastSearchResults();
113
-            if($lastResults) {
113
+            if ($lastResults) {
114 114
                 $resultsTitle = 'Last Results';
115 115
             } else {
116 116
                 $resultsTitle = 'Last Edited';
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
         Environment::increaseTimeLimitTo(300);
181 181
         Environment::setMemoryLimitMax(-1);
182 182
         Environment::increaseMemoryLimitTo(-1);
183
-        if(empty($this->rawData)) {
183
+        if (empty($this->rawData)) {
184 184
             $lastResults = $this->lastSearchResults();
185
-            if($lastResults) {
185
+            if ($lastResults) {
186 186
                 return $lastResults;
187 187
             }
188 188
         }
@@ -208,14 +208,14 @@  discard block
 block discarded – undo
208 208
             ->setWordsAsString($this->keywords)
209 209
             ->getLinks()
210 210
         ;
211
-        if($results->count() === 1) {
211
+        if ($results->count() === 1) {
212 212
             $result = $results->first();
213 213
             $this->redirect($result->CMSEditLink);
214 214
             return null;
215 215
         }
216 216
         // Accessing the session
217 217
         $session = $this->getRequest()->getSession();
218
-        if($session) {
218
+        if ($session) {
219 219
             $session->set('QuickSearchLastResults', serialize($results->toArray()));
220 220
         }
221 221
         return $results;
@@ -246,16 +246,16 @@  discard block
 block discarded – undo
246 246
     {
247 247
         // Accessing the session
248 248
         $session = $this->getRequest()->getSession();
249
-        if($this->quickSearchType) {
249
+        if ($this->quickSearchType) {
250 250
             $session->set('QuickSearchType', $this->quickSearchType);
251
-        } elseif($session) {
251
+        } elseif ($session) {
252 252
             $this->quickSearchType = $session->get('QuickSearchType');
253
-            if(isset($_GET['flush'])) {
253
+            if (isset($_GET['flush'])) {
254 254
                 $this->quickSearchType = '';
255 255
                 $session->set('QuickSearchType', '');
256 256
             }
257 257
         }
258
-        if(!$this->quickSearchType) {
258
+        if (!$this->quickSearchType) {
259 259
             $this->quickSearchType = $this->Config()->get('default_quick_search_type');
260 260
         }
261 261
         return (string) $this->quickSearchType;
@@ -265,15 +265,15 @@  discard block
 block discarded – undo
265 265
     {
266 266
         // Accessing the session
267 267
         $session = $this->getRequest()->getSession();
268
-        if($session) {
269
-            if(isset($_GET['flush'])) {
268
+        if ($session) {
269
+            if (isset($_GET['flush'])) {
270 270
                 $session->clear('QuickSearchLastResults');
271 271
             } else {
272 272
                 $data = $session->get('QuickSearchLastResults');
273
-                if($data) {
273
+                if ($data) {
274 274
                     $array = unserialize($data);
275 275
                     $al = ArrayList::create();
276
-                    foreach($array as $item) {
276
+                    foreach ($array as $item) {
277 277
                         $al->push($item);
278 278
                     }
279 279
                     return $al;
Please login to merge, or discard this patch.
src/QuickSearches/QuickSearchBaseClass.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@
 block discarded – undo
32 32
             'limited' => 'Limited search',
33 33
         ];
34 34
         $availableSearchClasses = self::available_quick_searches();
35
-        if(!empty($availableSearchClasses) > 0) {
36
-            foreach($availableSearchClasses as $availableSearchClass) {
37
-                $array[$availableSearchClass] =  Injector::inst()->get($availableSearchClass)->getTitle();
35
+        if (!empty($availableSearchClasses) > 0) {
36
+            foreach ($availableSearchClasses as $availableSearchClass) {
37
+                $array[$availableSearchClass] = Injector::inst()->get($availableSearchClass)->getTitle();
38 38
             }
39 39
         }
40 40
         return $array;
Please login to merge, or discard this patch.
src/Api/SearchApi.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -135,13 +135,13 @@  discard block
 block discarded – undo
135 135
 
136 136
     public function setQuickSearchType(string $s): SearchApi
137 137
     {
138
-        if($s === 'all') {
138
+        if ($s === 'all') {
139 139
             $this->isQuickSearch = false;
140 140
             $this->quickSearchType = '';
141
-        } elseif($s === 'limited') {
141
+        } elseif ($s === 'limited') {
142 142
             $this->isQuickSearch = true;
143 143
             $this->quickSearchType = '';
144
-        } elseif(class_exists($s)) {
144
+        } elseif (class_exists($s)) {
145 145
             $this->quickSearchType = $s;
146 146
             $object = Injector::inst()->get($s);
147 147
             $this->setIncludedClasses($object->getClassesToSearch());
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
                 if ($this->debug) {
341 341
                     DB::alteration_message(' ... Searching in ' . $className);
342 342
                 }
343
-                if(count($this->includedClasses) && !in_array($className, $this->includedClasses, true)) {
343
+                if (count($this->includedClasses) && !in_array($className, $this->includedClasses, true)) {
344 344
                     continue;
345 345
                 }
346 346
                 if (!in_array($className, $this->excludedClasses, true)) {
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
                     $fields = $this->getAllValidFields($className);
349 349
                     $filterAny = [];
350 350
                     foreach ($fields as $field) {
351
-                        if(count($this->includedFields) && !in_array($field, $this->includedFields, true)) {
351
+                        if (count($this->includedFields) && !in_array($field, $this->includedFields, true)) {
352 352
                             continue;
353 353
                         }
354 354
 
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
         $array = [];
412 412
         $classNames = $this->getAllDataObjects();
413 413
         foreach ($classNames as $className) {
414
-            if(count($this->includedClasses) && !in_array($className, $this->includedClasses, true)) {
414
+            if (count($this->includedClasses) && !in_array($className, $this->includedClasses, true)) {
415 415
                 continue;
416 416
             }
417 417
             if (!in_array($className, $this->excludedClasses, true)) {
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
         $items = $this->turnArrayIntoObjects($matches);
483 483
         foreach ($items as $item) {
484 484
             $link = $finder->getLink($item, $this->excludedClasses);
485
-            if($item->canView()) {
485
+            if ($item->canView()) {
486 486
                 $cmsEditLink = $item->canEdit() ? $finder->getCMSEditLink($item) : '';
487 487
                 $list->push(
488 488
                     ArrayData::create(
Please login to merge, or discard this patch.