View GitHub Repository silverstripe-simple-template-caching

Schedule Inspection
Subscribe
Passed
Push — master ( 05892b...595d66 )
by Nicolaas
03:39
created
Status
Category
Toggle Patches
src/Extensions/SimpleTemplateCachingSiteConfigExtension.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -80,7 +80,7 @@  discard block
 
 block discarded – undo
80 80 
     public static function update_cache_key(?string $className = '')
81 81 
     {
82 82 
         // important - avoid endless loop!
83 
-        if(SiteConfig::get()->exists()) {
83 
+        if (SiteConfig::get()->exists()) {
84 84 
             $howOldIsIt = DB::query('SELECT Created FROM SiteConfig LIMIT 1')->value();
85 85 
             if ($howOldIsIt && strtotime((string) $howOldIsIt) > strtotime('-5 minutes')) {
86 86 
                 return;
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
         }
103 103 
         if ($obj->RecordCacheUpdates) {
104 104 
             $recordId = Injector::inst()
105 
-                ->create(ObjectsUpdated::class, ['ClassNameLastEdited' => $className])
105 
+                ->create(ObjectsUpdated::class, [ 'ClassNameLastEdited' => $className ])
106 106 
                 ->write()
107 107 
             ;
108 108 
             DB::query('DELETE FROM ObjectsUpdated WHERE ID < ' . (int) ($recordId - self::MAX_OBJECTS_UPDATED));
 
@@ -111,9 +111,9 @@  discard block
 
 block discarded – undo
111 111
112 112 
     public function requireDefaultRecords()
113 113 
     {
114 
-        if((int) SiteConfig::get()->count() > 100) {
114 
+        if ((int) SiteConfig::get()->count() > 100) {
115 115 
             $currentSiteConfig = SiteConfig::current_site_config();
116 
-            if($currentSiteConfig) {
116 
+            if ($currentSiteConfig) {
117 117 
                 DB::alteration_message('Deleting all SiteConfig records except for the current one.', 'deleted');
118 118 
                 DB::query('DELETE FROM "SiteConfig" WHERE ID <> ' . $currentSiteConfig->ID);
119 119 
             }
Please login to merge, or discard this patch.
src/Extensions/ControllerExtension.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -16,7 +16,7 @@  discard block
 
 block discarded – undo
16 16 
 {
17 17 
     public function onBeforeInit()
18 18 
     {
19 
-        if(Security::getCurrentUser()) {
19 
+        if (Security::getCurrentUser()) {
20 20 
             return;
21 21 
         }
22 22 
         if (Versioned::LIVE !== Versioned::get_stage()) {
 
@@ -28,20 +28,20 @@  discard block
 
 block discarded – undo
28 28 
             if (empty($dataRecord)) {
29 29 
                 return;
30 30 
             }
31 
-            if($dataRecord->NeverCachePublicly) {
31 
+            if ($dataRecord->NeverCachePublicly) {
32 32 
                 HTTPCacheControlMiddleware::singleton()
33 33 
                     ->disableCache()
34 34 
                 ;
35 35 
                 return;
36 36 
             }
37 
-            if($dataRecord->PublicCacheDurationInSeconds === -1 || $dataRecord->PublicCacheDurationInSeconds === 0) {
37 
+            if ($dataRecord->PublicCacheDurationInSeconds === -1 || $dataRecord->PublicCacheDurationInSeconds === 0) {
38 38 
                 HTTPCacheControlMiddleware::singleton()
39 39 
                     ->disableCache()
40 40 
                 ;
41 41 
                 return;
42 42 
             }
43 43 
             $sc = SiteConfig::current_site_config();
44 
-            if($sc->HasCaching) {
44 
+            if ($sc->HasCaching) {
45 45 
                 $cacheTime = $dataRecord->PublicCacheDurationInSecond ?: $sc->PublicCacheDurationInSeconds;
46 46 
                 HTTPCacheControlMiddleware::singleton()
47 47 
                     ->enableCache()
Please login to merge, or discard this patch.