ShareThisSimpleExtension::ShareThisSimpleProvider() - Code Metrics - Inspection of "Update .scrutinizer.yml" - sunnysideup/silverstripe-share_this_simple - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9218bf...b9966f )

by Nicolaas

created 2019-07-16 02:23 UTC

ShareThisSimpleProvider() A

↳ Parent: ShareThisSimpleExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	0
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace Sunnysideup\ShareThisSimple\Model;

use Sunnysideup\ShareThisSimple\Api\ShareThisSimpleProvider;
use SilverStripe\ORM\DataExtension;

/**
  * ### @@@@ START REPLACEMENT @@@@ ###
  * WHY: upgrade to SS4
  * OLD:  extends DataExtension (ignore case)
  * NEW:  extends DataExtension (COMPLEX)
  * EXP: Check for use of $this->anyVar and replace with $this->anyVar[$this->owner->ID] or consider turning the class into a trait
  * ### @@@@ STOP REPLACEMENT @@@@ ###
  */
class ShareThisSimpleExtension extends DataExtension
{
    private static $_share_this_simple_provider = [];

    /**
     * use in your templates like this:
     *     $ShareThisSimpleProvider.FacebookLink
     *
     * @return ShareThisSimpleProvider
     */
    public function ShareThisSimpleProvider()
    {
        if (!isset($_share_this_simple_provider[$this->owner->ID])) {

            $_share_this_simple_provider[$this->owner->ID] = ShareThisSimpleProvider::create($this->owner);

        }

        return $_share_this_simple_provider[$this->owner->ID];
    }
}


1			<?php
2
3			namespace Sunnysideup\ShareThisSimple\Model;
4
5			use Sunnysideup\ShareThisSimple\Api\ShareThisSimpleProvider;
6			use SilverStripe\ORM\DataExtension;
7
8			/**
9			* ### @@@@ START REPLACEMENT @@@@ ###
10			* WHY: upgrade to SS4
11			* OLD: extends DataExtension (ignore case)
12			* NEW: extends DataExtension (COMPLEX)
13			* EXP: Check for use of $this->anyVar and replace with $this->anyVar[$this->owner->ID] or consider turning the class into a trait
14			* ### @@@@ STOP REPLACEMENT @@@@ ###
15			*/
16			class ShareThisSimpleExtension extends DataExtension
17			{
18			private static $_share_this_simple_provider = [];
			0 ignored issues – show introduced 2019-07-16 02:27 UTC by Report Bug Copy Issue Report The private property `$_share_this_simple_provider` is not used, and could be removed. Loading history...
19			/**
20			* use in your templates like this:
21			* $ShareThisSimpleProvider.FacebookLink
22			*
23			* @return ShareThisSimpleProvider
24			*/
25			public function ShareThisSimpleProvider()
26			{
27			if (!isset($_share_this_simple_provider[$this->owner->ID])) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-16 02:27 UTC by Report Bug Copy Issue Report The variable `$_share_this_simple_provider` seems to never exist and therefore `isset` should always be `false`. Loading history...
28			$_share_this_simple_provider[$this->owner->ID] = ShareThisSimpleProvider::create($this->owner);
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-16 02:27 UTC by Report Bug Copy Issue Report `$_share_this_simple_provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$_share_this_simple_provider = array();` before regardless. Loading history...
29			}
30
31			return $_share_this_simple_provider[$this->owner->ID];
32			}
33			}
34

sunnysideup / silverstripe-share_this_simple

Push — master ( 9218bf...b9966f )

ShareThisSimpleProvider() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like