Sunnysideup\ShareThisSimple\Model\ShareThisSimpleExtension

Complexity

Total Complexity

2

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ShareThisSimpleProvider()	0	7	2

<?php

namespace Sunnysideup\ShareThisSimple\Model;

use Sunnysideup\ShareThisSimple\Api\ShareThisSimpleProvider;
use SilverStripe\ORM\DataExtension;

/**
  * ### @@@@ START REPLACEMENT @@@@ ###
  * WHY: upgrade to SS4
  * OLD:  extends DataExtension (ignore case)
  * NEW:  extends DataExtension (COMPLEX)
  * EXP: Check for use of $this->anyVar and replace with $this->anyVar[$this->owner->ID] or consider turning the class into a trait
  * ### @@@@ STOP REPLACEMENT @@@@ ###
  */
class ShareThisSimpleExtension extends DataExtension
{
    private static $_share_this_simple_provider = [];

The private property $_share_this_simple_provider is not used, and could be removed.

    /**
     * use in your templates like this:
     *     $ShareThisSimpleProvider.FacebookLink
     *
     * @return ShareThisSimpleProvider
     */
    public function ShareThisSimpleProvider()
    {
        if (!isset($_share_this_simple_provider[$this->owner->ID])) {

The variable $_share_this_simple_provider seems to never exist and therefore isset should always be false.

            $_share_this_simple_provider[$this->owner->ID] = ShareThisSimpleProvider::create($this->owner);

$_share_this_simple_provider was never initialized. Although not strictly required by PHP, it is generally a good practice to add $_share_this_simple_provider = array(); before regardless.

        }

        return $_share_this_simple_provider[$this->owner->ID];
    }
}