PreviewPageRow::PageRowsReadyForPublication() - Code Metrics - sunnysideup/silverstripe-pagerows - Measure and Improve Code Quality continuously with Scrutinizer

PreviewPageRow::PageRowsReadyForPublication() A
last analyzed 2018-05-02 23:01 UTC

↳ Parent: PreviewPageRow

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php


class PreviewPageRow extends ContentController
namespace YourVendor;

class YourClass { }
{
    private static $url_segment = 'preview-page-row';


    private static $allowed_actions = [

        'preview' => 'ADMIN',
        'view' => true
    ];

    private $pageRows = null;

    public function preview($request)
    {
        return $notFoundResponse = $this->processRequest($request, false);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     *
     * @param string | null $action
     * @return string
     */
    public function Link($action = null)
    {
        $link = '/'.$this->Config()->get('url_segment').'/';
        if ($action) {
            $link .= $action . '/';
        }

        return $link;
    }

    public function view($request)
    {
        return $this->processRequest($request, true);
    }

    protected function processRequest($request, $readyForPublic)
    {
        $id = $request->param('ID');
        $pageRowClassNames = ClassInfo::subclassesFor('PageRow');
        $listOfClasses = [];
        foreach ($pageRowClassNames as $key => $class) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $listOfClasses[strtolower($class)] = $class;
        }
        $errorResponse = null;
        PageRow::set_current_page_object(Page::get()->first());
        if ($id == 'all') {
            $this->pageRows = PageRow::get();
        } elseif ($id == 'oneofeach') {
            $tempList = PageRow::get()->sort('RAND()');
            $oneIDPerClassNameArray = [];
            foreach ($tempList as $obj) {
                $oneIDPerClassNameArray[$obj->ClassName] = $obj->ID;
            }
            $this->pageRows = PageRow::get()->filter(['ID' => $oneIDPerClassNameArray]);
        } elseif (isset($listOfClasses[$id])) {
            $this->pageRows = PageRow::get()->filter(['ClassName' => $listOfClasses[$id]]);
        } else {
            $id = intval($id);
            $this->pageRows = PageRow::get()->filter(['ID' =>$id]);
        }
        if ($readyForPublic) {
            $this->pageRows = $this->pageRows->filter(['ReadyForPublication' => 1]);
        }
        $this->pageRows = $this->pageRows->exclude(['ClassName' => 'DownloadBlock']);
        if (! $this->pageRows->count()) {
            $errorResponse = $this->httpError(404, 'The requested page block could not be found.');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }
        if ($errorResponse) {
            return $errorResponse;
        } else {
            return $this->renderWith('PreviewPageRow');
        }
    }


    public function PageRowsReadyForPublication()
    {
        return $this->pageRows;
    }
}


1			<?php
2
3
4			class PreviewPageRow extends ContentController
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $url_segment = 'preview-page-row';
			0 ignored issues – show Unused Code introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report The property `$url_segment` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7
8			private static $allowed_actions = [
			0 ignored issues – show Comprehensibility introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9			'preview' => 'ADMIN',
10			'view' => true
11			];
12
13			private $pageRows = null;
14
15			public function preview($request)
16			{
17			return $notFoundResponse = $this->processRequest($request, false);
			0 ignored issues – show Unused Code introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report `$notFoundResponse` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
18			}
19
20			/**
21			*
22			* @param string \| null $action
23			* @return string
24			*/
25			public function Link($action = null)
26			{
27			$link = '/'.$this->Config()->get('url_segment').'/';
28			if ($action) {
29			$link .= $action . '/';
30			}
31
32			return $link;
33			}
34
35			public function view($request)
36			{
37			return $this->processRequest($request, true);
38			}
39
40			protected function processRequest($request, $readyForPublic)
41			{
42			$id = $request->param('ID');
43			$pageRowClassNames = ClassInfo::subclassesFor('PageRow');
44			$listOfClasses = [];
45			foreach ($pageRowClassNames as $key => $class) {
			0 ignored issues – show Bug introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report The expression `$pageRowClassNames` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
46			$listOfClasses[strtolower($class)] = $class;
47			}
48			$errorResponse = null;
49			PageRow::set_current_page_object(Page::get()->first());
50			if ($id == 'all') {
51			$this->pageRows = PageRow::get();
52			} elseif ($id == 'oneofeach') {
53			$tempList = PageRow::get()->sort('RAND()');
54			$oneIDPerClassNameArray = [];
55			foreach ($tempList as $obj) {
56			$oneIDPerClassNameArray[$obj->ClassName] = $obj->ID;
57			}
58			$this->pageRows = PageRow::get()->filter(['ID' => $oneIDPerClassNameArray]);
59			} elseif (isset($listOfClasses[$id])) {
60			$this->pageRows = PageRow::get()->filter(['ClassName' => $listOfClasses[$id]]);
61			} else {
62			$id = intval($id);
63			$this->pageRows = PageRow::get()->filter(['ID' =>$id]);
64			}
65			if ($readyForPublic) {
66			$this->pageRows = $this->pageRows->filter(['ReadyForPublication' => 1]);
67			}
68			$this->pageRows = $this->pageRows->exclude(['ClassName' => 'DownloadBlock']);
69			if (! $this->pageRows->count()) {
70			$errorResponse = $this->httpError(404, 'The requested page block could not be found.');
			0 ignored issues – show Bug introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$errorResponse` is correct as `$this->httpError(404, 'T...k could not be found.')` (which targets `ContentController::httpError()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
71			}
72			if ($errorResponse) {
73			return $errorResponse;
74			} else {
75			return $this->renderWith('PreviewPageRow');
76			}
77			}
78
79
80			public function PageRowsReadyForPublication()
81			{
82			return $this->pageRows;
83			}
84			}
85

sunnysideup / silverstripe-pagerows

PreviewPageRow::PageRowsReadyForPublication() A last analyzed 2018-05-02 23:01 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PreviewPageRow::PageRowsReadyForPublication() A
last analyzed 2018-05-02 23:01 UTC