PreviewPageRow

Complexity

Total Complexity

14

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	preview()	0	4	1
A	Link()	0	9	2
A	view()	0	4	1
D	processRequest()	0	38	9
A	PageRowsReadyForPublication()	0	4	1

<?php


class PreviewPageRow extends ContentController

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $url_segment = 'preview-page-row';

The property $url_segment is not used and could be removed.

    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'preview' => 'ADMIN',
        'view' => true
    ];

    private $pageRows = null;

    public function preview($request)
    {
        return $notFoundResponse = $this->processRequest($request, false);

$notFoundResponse is not used, you could remove the assignment.

    }

    /**
     *
     * @param string | null $action
     * @return string
     */
    public function Link($action = null)
    {
        $link = '/'.$this->Config()->get('url_segment').'/';
        if ($action) {
            $link .= $action . '/';
        }

        return $link;
    }

    public function view($request)
    {
        return $this->processRequest($request, true);
    }

    protected function processRequest($request, $readyForPublic)
    {
        $id = $request->param('ID');
        $pageRowClassNames = ClassInfo::subclassesFor('PageRow');
        $listOfClasses = [];
        foreach ($pageRowClassNames as $key => $class) {

The expression $pageRowClassNames of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            $listOfClasses[strtolower($class)] = $class;
        }
        $errorResponse = null;
        PageRow::set_current_page_object(Page::get()->first());
        if ($id == 'all') {
            $this->pageRows = PageRow::get();
        } elseif ($id == 'oneofeach') {
            $tempList = PageRow::get()->sort('RAND()');
            $oneIDPerClassNameArray = [];
            foreach ($tempList as $obj) {
                $oneIDPerClassNameArray[$obj->ClassName] = $obj->ID;
            }
            $this->pageRows = PageRow::get()->filter(['ID' => $oneIDPerClassNameArray]);
        } elseif (isset($listOfClasses[$id])) {
            $this->pageRows = PageRow::get()->filter(['ClassName' => $listOfClasses[$id]]);
        } else {
            $id = intval($id);
            $this->pageRows = PageRow::get()->filter(['ID' =>$id]);
        }
        if ($readyForPublic) {
            $this->pageRows = $this->pageRows->filter(['ReadyForPublication' => 1]);
        }
        $this->pageRows = $this->pageRows->exclude(['ClassName' => 'DownloadBlock']);
        if (! $this->pageRows->count()) {
            $errorResponse = $this->httpError(404, 'The requested page block could not be found.');

Are you sure the assignment to $errorResponse is correct as $this->httpError(404, 'The requested page block could not be found.') (which targets ContentController::httpError()) seems to always return null.

        }
        if ($errorResponse) {
            return $errorResponse;
        } else {
            return $this->renderWith('PreviewPageRow');
        }
    }


    public function PageRowsReadyForPublication()
    {
        return $this->pageRows;
    }
}