Completed
Push — master ( bf91ef...1385c4 )
by Nicolaas
02:53
created
code/api/AddFileToModule.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -116,9 +116,8 @@  discard block
 block discarded – undo
116 116
      * `$sourceLocation` or you can just have a string here
117 117
      * that returns the data directly....
118 118
      *
119
-     * @param string $fileContent
120 119
      *
121
-     * @return bool - true on success, false on failure
120
+     * @return string|false - true on success, false on failure
122 121
      */
123 122
     protected function getStandardFile()
124 123
     {
@@ -153,7 +152,8 @@  discard block
 block discarded – undo
153 152
      * takes the standard file and adds any
154 153
      * customisations to it from the module
155 154
      *
156
-     * @return bool - true on success, false on failure
155
+     * @param string|false $fileContent
156
+     * @return boolean|null - true on success, false on failure
157 157
      */
158 158
     protected function customiseStandardFile($fileContent)
159 159
     {
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      *
167 167
      * @param string $fileContent
168 168
      *
169
-     * @return bool - true on success, false on failure
169
+     * @return null|false - true on success, false on failure
170 170
      */
171 171
     protected function saveFile($fileContent)
172 172
     {
@@ -216,6 +216,9 @@  discard block
 block discarded – undo
216 216
     }
217 217
 
218 218
 
219
+    /**
220
+     * @param string $componentName
221
+     */
219 222
     protected function getReadMeComponent($componentName)
220 223
     {
221 224
         $temp_dir = GitHubModule::Config()->get('absolute_temp_folder');
@@ -287,8 +290,6 @@  discard block
 block discarded – undo
287 290
 
288 291
 
289 292
     /**
290
-     * @param string $file
291
-     * @param GitHubModule $gitObject
292 293
      *
293 294
      * @return string
294 295
      */
Please login to merge, or discard this patch.
code/model/GitHubModule.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -175,6 +175,9 @@
 block discarded – undo
175 175
         return 'https://github.com/'.$username.'/'.$this->ModuleName;
176 176
     }
177 177
 
178
+    /**
179
+     * @param string|null $directory
180
+     */
178 181
     protected function IsDirGitRepo ($directory) {
179 182
         return file_exists($directory."/.git");
180 183
     }
Please login to merge, or discard this patch.
code/tasks/ModuleChecks.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
      *
117 117
      * @param string $name
118 118
      * @param string $variable
119
-     * @return boolean
119
+     * @return boolean|null
120 120
      */
121 121
     protected function checkForDetailsInComposerFile($name, $variable)
122 122
     {
Please login to merge, or discard this patch.
code/objects/GitHubModule.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -175,6 +175,9 @@
 block discarded – undo
175 175
         return 'https://github.com/'.$username.'/'.$this->ModuleName;
176 176
     }
177 177
 
178
+    /**
179
+     * @param string|null $directory
180
+     */
178 181
     protected function IsDirGitRepo ($directory) {
179 182
         return file_exists($directory."/.git");
180 183
     }
Please login to merge, or discard this patch.
code/tasks/UpdateModules.php 1 patch
Doc Comments   +18 added lines patch added patch discarded remove patch
@@ -360,12 +360,18 @@  discard block
 block discarded – undo
360 360
 
361 361
     }
362 362
 
363
+    /**
364
+     * @param DataObject $module
365
+     */
363 366
     protected function checkConfigYML($module)
364 367
     {
365 368
         $configYml = ConfigYML::create($module)->reWrite();
366 369
 
367 370
     }
368 371
 
372
+    /**
373
+     * @param string $filename
374
+     */
369 375
     private function checkFile($module, $filename) {
370 376
         $folder = GitHubModule::Config()->get('absolute_temp_folder');
371 377
         return file_exists($folder.'/'.$module.'/'.$filename);
@@ -375,6 +381,9 @@  discard block
 block discarded – undo
375 381
         return $this->checkFile($module, "README.MD");
376 382
     }
377 383
 
384
+    /**
385
+     * @param string $directory
386
+     */
378 387
     private function checkDirExcludedWords($directory, $wordArray) {
379 388
         $filesAndFolders = scandir ($directory);
380 389
 
@@ -404,6 +413,9 @@  discard block
 block discarded – undo
404 413
         return $problem_files;
405 414
     }
406 415
 
416
+    /**
417
+     * @param string $fileName
418
+     */
407 419
     private function checkFileExcludedWords($fileName, $wordArray) {
408 420
 
409 421
 
@@ -442,6 +454,9 @@  discard block
 block discarded – undo
442 454
 
443 455
     }
444 456
 
457
+    /**
458
+     * @param DataObject $moduleObject
459
+     */
445 460
     private function checkUpdateTag($moduleObject) {
446 461
 
447 462
         $tagDelayString = $this->Config()->get('tag_delay');
@@ -530,6 +545,9 @@  discard block
 block discarded – undo
530 545
         return $newTagString;
531 546
     }
532 547
 
548
+    /**
549
+     * @param DataObject $moduleObject
550
+     */
533 551
     protected function moveOldReadMe($moduleObject) {
534 552
         $tempDir = GitHubModule::Config()->get('absolute_temp_folder');
535 553
         $oldReadMe = $tempDir . '/' .  $moduleObject->ModuleName . '/' .'README.md';
Please login to merge, or discard this patch.