Completed
Push — master ( 115aec...11e20f )
by Jack
02:31
created
code/api/AddFileToModule.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -116,9 +116,8 @@  discard block
 block discarded – undo
116 116
      * `$sourceLocation` or you can just have a string here
117 117
      * that returns the data directly....
118 118
      *
119
-     * @param string $fileContent
120 119
      *
121
-     * @return bool - true on success, false on failure
120
+     * @return string|false - true on success, false on failure
122 121
      */
123 122
     protected function getStandardFile()
124 123
     {
@@ -153,7 +152,8 @@  discard block
 block discarded – undo
153 152
      * takes the standard file and adds any
154 153
      * customisations to it from the module
155 154
      *
156
-     * @return bool - true on success, false on failure
155
+     * @param string|false $fileContent
156
+     * @return boolean|null - true on success, false on failure
157 157
      */
158 158
     protected function customiseStandardFile($fileContent)
159 159
     {
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      *
167 167
      * @param string $fileContent
168 168
      *
169
-     * @return bool - true on success, false on failure
169
+     * @return null|false - true on success, false on failure
170 170
      */
171 171
     protected function saveFile($fileContent)
172 172
     {
@@ -216,6 +216,9 @@  discard block
 block discarded – undo
216 216
     }
217 217
 
218 218
 
219
+    /**
220
+     * @param string $componentName
221
+     */
219 222
     protected function getReadMeComponent($componentName)
220 223
     {
221 224
         $temp_dir = GitHubModule::Config()->get('absolute_temp_folder');
@@ -287,8 +290,6 @@  discard block
 block discarded – undo
287 290
 
288 291
 
289 292
     /**
290
-     * @param string $file
291
-     * @param GitHubModule $gitObject
292 293
      *
293 294
      * @return string
294 295
      */
Please login to merge, or discard this patch.
code/tasks/ModuleChecks.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
      *
117 117
      * @param string $name
118 118
      * @param string $variable
119
-     * @return boolean
119
+     * @return boolean|null
120 120
      */
121 121
     protected function checkForDetailsInComposerFile($name, $variable)
122 122
     {
Please login to merge, or discard this patch.