sunnysideup / silverstripe-migration-task

src/Tasks/ReviewInternalLinks.php

Spacing +6 added lines, -6 removed lines

@@ -95,7 +95,7 @@ 
                     $objects = SiteTree::get()->sort(['ID' => 'ASC'])->limit($this->step, $i + $start);
                 }
                 $filter = $this->Config()->get('filtered_class_names');
-                if (! empty($filter)) {
+                if (!empty($filter)) {
                     $objects = $objects->filter($filter);
                 }
                 foreach ($objects as $object) {
@@ -149,7 +149,7 @@ 
         ++$this->count;
         $links = [];
         foreach ($this->fieldsToTest as $field) {
-            if (! empty($object->{$field})) {
+            if (!empty($object->{$field})) {
                 $dom = new \DOMDocument();
 
                 @$dom->loadHTML(
@@ -161,7 +161,7 @@ 
                 //
                 //     continue;
                 // }
-                if (! $this->type || 'a' === strtolower($this->type)) {
+                if (!$this->type || 'a' === strtolower($this->type)) {
                     $hrefs = $dom->getElementsByTagName('a');
                     for ($i = 0; $i < $hrefs->length; ++$i) {
                         $href = $hrefs->item($i);
@@ -170,7 +170,7 @@ 
 
                         $links[$url] = $url . ' | A | ' . $field;
 
-                        if (! isset($this->allLinks[$url])) {
+                        if (!isset($this->allLinks[$url])) {
                             $this->allLinks[$url] = [
                                 'count' => 0,
                                 'type' => 'A',
@@ -179,7 +179,7 @@ 
                         ++$this->allLinks[$url]['count'];
                     }
                 }
-                if (! $this->type || 'img' === strtolower($this->type)) {
+                if (!$this->type || 'img' === strtolower($this->type)) {
                     $hrefs = $dom->getElementsByTagName('img');
                     for ($i = 0; $i < $hrefs->length; ++$i) {
                         $href = $hrefs->item($i);
@@ -188,7 +188,7 @@ 
 
                         $links[$url] = $url . ' | IMG | ' . $field;
 
-                        if (! isset($this->allLinks[$url])) {
+                        if (!isset($this->allLinks[$url])) {
                             $this->allLinks[$url] = [
                                 'count' => 0,
                                 'type' => 'IMG',

src/Tasks/CheckClassNames.php

Spacing +7 added lines, -7 removed lines

@@ -78,7 +78,7 @@ 
 
         //check all classes
         foreach ($objectClassNames as $objectClassName) {
-            if (count($this->onlyRunFor) && ! in_array($objectClassName, $this->onlyRunFor, true)) {
+            if (count($this->onlyRunFor) && !in_array($objectClassName, $this->onlyRunFor, true)) {
                 continue;
             }
             $fields = $this->dataObjectSchema->databaseFields($objectClassName, false);
@@ -93,7 +93,7 @@ 
                     $this->flushNow('... ' . $objectClassName . ' POTENTIALLY has a table with a full class name: ' . $tableName . ' it is recommended that you set the private static table_name', 'error');
                     $allOK = false;
                 }
-                if (! $tableName) {
+                if (!$tableName) {
                     $this->flushNow('... Can not find: ' . $objectClassName . '.table_name in code ', 'error');
                     $allOK = false;
                 } elseif ($this->tableExists($tableName)) {
@@ -166,7 +166,7 @@ 
                     ORDER BY C DESC'
                 );
                 foreach ($rows as $row) {
-                    if (! $row[$fieldName]) {
+                    if (!$row[$fieldName]) {
                         $row[$fieldName] = '--- NO VALUE ---';
                     }
                     $this->flushNow('... ... ' . $row['C'] . ' ' . $row[$fieldName]);
@@ -196,7 +196,7 @@ 
                     foreach ($options as $key => $optionClassName) {
                         if ($optionClassName !== $objectClassName) {
                             $optionTableName = $this->dataObjectSchema->tableName($objectClassName);
-                            if (! $this->tableExists($optionTableName) || $optionTableName === $tableName) {
+                            if (!$this->tableExists($optionTableName) || $optionTableName === $tableName) {
                                 unset($options[$key]);
                             } else {
                                 $checkTables[$optionClassName] = $optionTableName;
@@ -225,7 +225,7 @@ 
                             }
                         }
                         if (0 === $optionCount) {
-                            if (! $row[$fieldName]) {
+                            if (!$row[$fieldName]) {
                                 $row[$fieldName] = '--- NO VALUE ---';
                             }
                             $this->flushNow('... Updating ' . $fieldName . ' to ' . $objectClassName . ' for ID = ' . $row['ID'] . ' from ' . $fieldName . ' = ' . $row[$fieldName] . ' - based on inability to find matching IDs in any child class tables', 'created');
@@ -289,7 +289,7 @@ 
     protected function bestClassName(string $objectClassName, string $tableName, string $fieldName): string
     {
         $keyForStore = $objectClassName . '_' . $tableName . '_' . $fieldName;
-        if (! isset($this->bestClassNameStore[$keyForStore])) {
+        if (!isset($this->bestClassNameStore[$keyForStore])) {
             $obj = Injector::inst()
                 ->get($objectClassName)
             ;
@@ -319,7 +319,7 @@ 
                     break;
                 }
             }
-            if (! $bestValue) {
+            if (!$bestValue) {
                 $bestValue = key($values);
             }
             $this->bestClassNameStore[$keyForStore] = $bestValue;

src/Tasks/DraftVsLive.php

Spacing +3 added lines, -3 removed lines

@@ -77,10 +77,10 @@ 
         foreach ($liveRows as $liveRow) {
             $results = array_diff($draftRow, $liveRow) + array_diff($liveRow, $draftRow);
             foreach (array_keys($results) as $key) {
-                if (! isset($draftRow[$key])) {
+                if (!isset($draftRow[$key])) {
                     $draftRow[$key] = '???';
                 }
-                if (! isset($liveRow[$key])) {
+                if (!isset($liveRow[$key])) {
                     $liveRow[$key] = '???';
                 }
                 $allOk = false;
@@ -125,7 +125,7 @@ 
                 'deleted'
             );
         }
-        if (! $backwards) {
+        if (!$backwards) {
             $this->compareColumnsInner($rowB, $rowA, $table, true);
         }
     }

src/Tasks/UpgradeOnlyCheckYMLClassNames.php

Spacing +8 added lines, -8 removed lines

@@ -45,7 +45,7 @@ 
             if (file_exists($fullSubDir)) {
                 $toAdds = $this->getYMLFiles($fullSubDir);
                 foreach ($toAdds as $toAdd) {
-                    if (! in_array(basename($toAdd), $this->Config()->get('files_to_ignore'), true)) {
+                    if (!in_array(basename($toAdd), $this->Config()->get('files_to_ignore'), true)) {
                         $ymlFiles[] = $toAdd;
                     }
                 }
@@ -57,14 +57,14 @@ 
             $this->flushNowLine();
             $count = 0;
             $alreadySet = [];
-            if (! file_exists($fileName)) {
+            if (!file_exists($fileName)) {
                 die(' Could not find ' . $fileName);
             }
             $fp = fopen($fileName, 'r');
             $hasLine = true;
             while ($hasLine) {
                 $line = stream_get_line($fp, 1024 * 1024, "\n");
-                if (! $line) {
+                if (!$line) {
                     break;
                 }
                 ++$count;
@@ -85,14 +85,14 @@ 
                                 $property = trim($myItems[0], "'");
                                 $property = trim($myItems[0], '"');
                                 if (strpos($property, '\\')) {
-                                    if (! class_exists($property)) {
+                                    if (!class_exists($property)) {
                                         $this->flushNow('
 ERROR ' . $className . '.' . $property . ' may not exist as class name but looks like one.<br>');
                                     }
                                 } elseif (strpos($property, '*')) {
                                     $this->flushNow('
 ERROR ' . $className . '.' . $property . ' contains *.<br>');
-                                } elseif (! property_exists($className, $property)) {
+                                } elseif (!property_exists($className, $property)) {
                                     $this->flushNow('
 ERROR ' . $className . '.' . $property . ' property could not be found<br>');
                                 } else {
@@ -112,7 +112,7 @@ 
 COULD NOT FIND ' . $className . '<br>');
                     }
                 } else {
-                    if (! strpos($line, '\\')) {
+                    if (!strpos($line, '\\')) {
                         continue;
                     }
                     if (strpos($line, '*')) {
@@ -126,7 +126,7 @@ 
 ERROR: Two mentions of ' . $line . '<br>');
                     } else {
                         $alreadySet[$line] = $line;
-                        if (! class_exists($line)) {
+                        if (!class_exists($line)) {
                             $this->flushNow('
 
 ERROR: Could not find class ' . $line . '<br>');
@@ -153,7 +153,7 @@ 
         // $subDir = array_merge($subDir, $directories);
         // Foreach directory, recursively get and add sub directories
         foreach ($directories as $directory) {
-            if (! in_array(basename($directory), $ignore, true)) {
+            if (!in_array(basename($directory), $ignore, true)) {
                 $subDirs[] = $directory;
             }
         }

src/Tasks/CheckDataObjectStatics.php

Spacing +2 added lines, -2 removed lines

@@ -68,13 +68,13 @@
         $values = [];
         //check all classes
         foreach ($this->objectClassNames as $objectClassName) {
-            if (count($this->onlyRunFor) && ! in_array($objectClassName, $this->onlyRunFor, true)) {
+            if (count($this->onlyRunFor) && !in_array($objectClassName, $this->onlyRunFor, true)) {
                 continue;
             }
 
             $summaryFields = Config::inst()->get($objectClassName, 'summary_fields');
             // $searchableFields = Config::inst()->get($objectClassName, 'searchable_fields');
-            if (! empty($summaryFields)) {
+            if (!empty($summaryFields)) {
                 $dbFields = array_keys(Config::inst()->get($objectClassName, 'db'));
                 if (count($dbFields) > 5) {
                     $recommended = array_intersect($dbFields, $summaryFields);

src/Tasks/TextOrJSONToRelationshipMigration.php

Spacing +3 added lines, -3 removed lines

@@ -170,7 +170,7 @@ 
     {
         if ('' !== $fieldValue) {
             $array = @json_decode($fieldValue, false);
-            if (! empty($array)) {
+            if (!empty($array)) {
                 $obj = $className::get_by_id($id);
                 $lookupClassName = $this->getlookupClassName($className, $lookupMethod);
                 $obj->{$lookupMethod}()->removeAll();
@@ -206,7 +206,7 @@ 
     protected function getTableName(string $className, string $tableExtension): string
     {
         $key = $className . '_' . $tableExtension;
-        if (! isset($this->tables[$key])) {
+        if (!isset($this->tables[$key])) {
             $dbtable = Config::inst()->get($className, 'table_name');
             $tableName = $dbtable . $tableExtension;
             $this->tables[$key] = $tableName;
@@ -218,7 +218,7 @@ 
     protected function getLookupClassName(string $className, string $lookupMethod): string
     {
         $key = $className . '_' . $lookupMethod;
-        if (! isset($this->lookupClassNames[$key])) {
+        if (!isset($this->lookupClassNames[$key])) {
             /** @var array $fields */
             $fields = Config::inst()->get($className, 'has_many');
             $fields += Config::inst()->get($className, 'many_many');

src/Tasks/MigrateDataTaskBase.php

Spacing +8 added lines, -8 removed lines

@@ -84,19 +84,19 @@ 
         if ([] !== $data) {
             $this->flushNow('<h3>Migrating data - Core Migration</h3>');
             foreach ($data as $dataItem) {
-                if (! isset($dataItem['include_inserts'])) {
+                if (!isset($dataItem['include_inserts'])) {
                     $dataItem['include_inserts'] = true;
                 }
-                if (! isset($dataItem['leftJoin'])) {
+                if (!isset($dataItem['leftJoin'])) {
                     $dataItem['leftJoin'] = [];
                 }
-                if (! isset($dataItem['where'])) {
+                if (!isset($dataItem['where'])) {
                     $dataItem['where'] = '';
                 }
-                if (! isset($dataItem['include_inserts'])) {
+                if (!isset($dataItem['include_inserts'])) {
                     $dataItem['include_inserts'] = true;
                 }
-                if (! isset($dataItem['new_table'])) {
+                if (!isset($dataItem['new_table'])) {
                     $dataItem['new_table'] = $dataItem['old_table'];
                 }
                 $dataItem['old_fields'] = [];
@@ -159,11 +159,11 @@ 
         array $leftJoin = [],
         string $where = ''
     ) {
-        if (! $this->tableExists($tableOld)) {
+        if (!$this->tableExists($tableOld)) {
             $this->flushNow("{$tableOld} (old table) does not exist", 'error');
         }
 
-        if (! $this->tableExists($tableNew)) {
+        if (!$this->tableExists($tableNew)) {
             $this->flushNow("{$tableNew} (new table) does not exist", 'error');
         }
 
@@ -178,7 +178,7 @@ 
             //add a new line using the ID as identifier
             foreach ($oldEntries as $oldEntry) {
                 if ($includeInserts) {
-                    if (! in_array($oldEntry['ID'], $newEntryIDs, true)) {
+                    if (!in_array($oldEntry['ID'], $newEntryIDs, true)) {
                         $this->flushNow('Added row ' . $oldEntry['ID'] . ' to ' . $tableNew . '.');
                         $this->runUpdateQuery('INSERT INTO "' . $tableNew . '" ("ID") VALUES (' . $oldEntry['ID'] . ');');
                     }

src/Traits/HelperMethods.php

Spacing +1 added lines, -1 removed lines

@@ -201,7 +201,7 @@
     {
         if (null === $this->_schema) {
             $this->_schema = DB::get_schema();
-            $this->_schema->schemaUpdate(function () {
+            $this->_schema->schemaUpdate(function() {
                 return true;
             });
         }

src/Tasks/UserFormFixes.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
         $objects = UserDefinedForm::get();
         foreach ($objects as $object) {
             $this->flushNow('Publishing ' . $object->getTitle());
-            $isPublished = $object->IsPublished()  && !$object->isModifiedOnDraft();
+            $isPublished = $object->IsPublished() && !$object->isModifiedOnDraft();
             ;
             $object->writeToStage(Versioned::DRAFT);
             $object->publishRecursive();