sunnysideup / silverstripe-imagegallery_basic

code/ImageGalleryPage.php

<?php

class ImageGalleryPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "imagegallery_basic/images/treeicons/ImageGalleryPage";

The property $icon is not used and could be removed.

    private static $allowed_children = array("ImageGalleryPage"); //can also be "none";

The property $allowed_children is not used and could be removed.

    private static $default_child = "ImageGalleryPage";

The property $default_child is not used and could be removed.

    private static $description = "Page used to display images in a gallery";

The property $description is not used and could be removed.

    private static $has_one = array(

The property $has_one is not used and could be removed.

        "AutomaticallyIncludedFolder" => "Folder"
    );

    private static $has_many = array(

The property $has_many is not used and could be removed.

        "ImageGalleryEntries" => "ImageGalleryEntry"
    );

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Gallery", $treeDropdowField = TreeDropdownField::create($name = "AutomaticallyIncludedFolderID", $title = "Quick Add from Folder", $sourceObjectName = "Folder"));
        $treeDropdowField->setRightTitle('
            Add a folder here to add a bunch of images all at once.<br />
            <a href="/admin/assets/show/'.$this->AutomaticallyIncludedFolderID.'">see files and images</a> section to add, remove and edit images in a folder before selecting one here.
            <br />
            Once added, you can edit the images below as you see fit.
        ');
        $gridField = new GridField('images', 'Linked images', $this->ImageGalleryEntries(), GridFieldConfig_RelationEditor::create());
        $fields->addFieldToTab("Root.Gallery", $gridField);
        if (class_exists("DataObjectSorterController")) {
            $fields->addFieldToTab(
                "Root.Gallery",
                LiteralField::create(
                    "ImageGalleryEntrySorter",
                    DataObjectSorterController::popup_link(
                        "ImageGalleryEntry",
                        $filterField = "ParentID",
                        $filterValue = $this->ID,
                        $linkText = "Sort Items",
                        $titleField = "FullTitle"
                        )
                    )
            );
        } else {
            $fields->addFieldToTab("Root.Gallery", new NumericField($name = "Sort", "Sort index number (the lower the number, the earlier it shows up"));
        }
        return $fields;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $imageAdded = false;
        if ($this->AutomaticallyIncludedFolderID) {
            if ($folder = Folder::get()->byID($this->AutomaticallyIncludedFolderID)) {
                if ($files = Image::get()->filter("ParentID", $folder->ID)) {
                    foreach ($files as $file) {
                        if (ImageGalleryEntry::get()->filter(array("ImageID" => $file->ID, "ParentID" => $this->ID))->count()) {

This if statement is empty and can be removed.

                            //do nothing
                            //debug::log("already exists");

72% of this comment could be valid code. Did you maybe forget this after debugging?

                        } else {
                            $ImageGalleryEntry = new ImageGalleryEntry();
                            $ImageGalleryEntry->Title = $file->Title;

The property Title does not exist on object<ImageGalleryEntry>. Since you implemented __set, maybe consider adding a @property annotation.

                            $ImageGalleryEntry->ImageID = $file->ID;

The property ImageID does not exist on object<ImageGalleryEntry>. Since you implemented __set, maybe consider adding a @property annotation.

                            $ImageGalleryEntry->ParentID = $this->ID;

The property ParentID does not exist on object<ImageGalleryEntry>. Since you implemented __set, maybe consider adding a @property annotation.

                            $ImageGalleryEntry->write();
                            $imageAdded = true;
                            //debug::log("writing");

72% of this comment could be valid code. Did you maybe forget this after debugging?

                        }
                    }
                } else {

This else statement is empty and can be removed.

                    //debug::log("D");

72% of this comment could be valid code. Did you maybe forget this after debugging?

                }
            } else {

This else statement is empty and can be removed.

                //debug::log("C");

72% of this comment could be valid code. Did you maybe forget this after debugging?

            }
        } else {

This else statement is empty and can be removed.

            //debug::log("B");

72% of this comment could be valid code. Did you maybe forget this after debugging?

        }
        if ($ImageGalleryEntries = ImageGalleryEntry::get()->filter(array("ParentID" => $this->ID))) {
            foreach ($ImageGalleryEntries as $ImageGalleryEntry) {
                $image = Image::get()
                    ->filter(array("ID" => $ImageGalleryEntry->ImageID))
                    ->exclude(array("Title" => $ImageGalleryEntry->Title))
                    ->First();
                if ($image) {
                    $image->Title = $image->Name = $ImageGalleryEntry->Title;
                    $image->write();
                }
            }
        }
        if ($imageAdded) {

This if statement is empty and can be removed.

            //LeftAndMain::force_reload();

67% of this comment could be valid code. Did you maybe forget this after debugging?

        }
        $this->AutomaticallyIncludedFolderID = 0;
    }

    public function NextGallery()

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        $pages = ImageGalleryPage::get()
            ->exclude(array("ID" => $this->ID))
            ->where("TimeDiff(\"Created\",'".$this->Created."') > 0")
            ->sort("Created", "ASC")
            ->limit(1);
        if ($pages) {
            foreach ($pages as $page) {
                return $page;
            }
        }
    }

    public function PreviousGallery()

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        $pages = ImageGalleryPage::get()
            ->exclude(array("ID" => $this->ID))
            ->where("TimeDiff(\"Created\",'".$this->Created."') < 0")
            ->sort("Created", "DESC")
            ->limit(1);
        if ($pages) {
            foreach ($pages as $page) {
                return $page;
            }
        }
    }
}

class ImageGalleryPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        "updateimagegalleryentries" => "ADMIN"
    );

    public function init()
    {
        parent::init();
        if (class_exists("PrettyPhoto")) {
            PrettyPhoto::include_code();
        }
    }

    public function updateimagegalleryentries()
    {
        $this->onBeforeWrite();
        return array();
    }
}