ImageGalleryPage - Code Metrics - sunnysideup/silverstripe-imagegallery_basic - Measure and Improve Code Quality continuously with Scrutinizer

ImageGalleryPage A
last analyzed 2018-08-22 00:39 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	126
Duplicated Lines	20.63 %

Coupling/Cohesion

Components	0
Dependencies	10

Importance

Changes

Metric	Value
wmc	18
lcom	0
cbo	10
dl	26
loc	126
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	NextGallery()	13	13	3
A	PreviousGallery()	13	13	3
A	getCMSFields()	0	31	2
B	onBeforeWrite()	0	47	10

How to fix Duplicated Code

<?php

class ImageGalleryPage extends Page
namespace YourVendor;

class YourClass { }
{
    private static $icon = "imagegallery_basic/images/treeicons/ImageGalleryPage";


    private static $allowed_children = array("ImageGalleryPage"); //can also be "none";


    private static $default_child = "ImageGalleryPage";


    private static $description = "Page used to display images in a gallery";


    private static $has_one = array(

        "AutomaticallyIncludedFolder" => "Folder"
    );

    private static $has_many = array(

        "ImageGalleryEntries" => "ImageGalleryEntry"
    );

    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Gallery", $treeDropdowField = TreeDropdownField::create($name = "AutomaticallyIncludedFolderID", $title = "Quick Add from Folder", $sourceObjectName = "Folder"));
        $treeDropdowField->setRightTitle('
            Add a folder here to add a bunch of images all at once.<br />
            <a href="/admin/assets/show/'.$this->AutomaticallyIncludedFolderID.'">see files and images</a> section to add, remove and edit images in a folder before selecting one here.
            <br />
            Once added, you can edit the images below as you see fit.
        ');
        $gridField = new GridField('images', 'Linked images', $this->ImageGalleryEntries(), GridFieldConfig_RelationEditor::create());
        $fields->addFieldToTab("Root.Gallery", $gridField);
        if (class_exists("DataObjectSorterController")) {
            $fields->addFieldToTab(
                "Root.Gallery",
                LiteralField::create(
                    "ImageGalleryEntrySorter",
                    DataObjectSorterController::popup_link(
                        "ImageGalleryEntry",
                        $filterField = "ParentID",
                        $filterValue = $this->ID,
                        $linkText = "Sort Items",
                        $titleField = "FullTitle"
                        )
                    )
            );
        } else {
            $fields->addFieldToTab("Root.Gallery", new NumericField($name = "Sort", "Sort index number (the lower the number, the earlier it shows up"));
        }
        return $fields;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $imageAdded = false;
        if ($this->AutomaticallyIncludedFolderID) {
            if ($folder = Folder::get()->byID($this->AutomaticallyIncludedFolderID)) {
                if ($files = Image::get()->filter("ParentID", $folder->ID)) {
                    foreach ($files as $file) {
                        if (ImageGalleryEntry::get()->filter(array("ImageID" => $file->ID, "ParentID" => $this->ID))->count()) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                            //do nothing
                            //debug::log("already exists");

                        } else {
                            $ImageGalleryEntry = new ImageGalleryEntry();
                            $ImageGalleryEntry->Title = $file->Title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $ImageGalleryEntry->ImageID = $file->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $ImageGalleryEntry->ParentID = $this->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $ImageGalleryEntry->write();
                            $imageAdded = true;
                            //debug::log("writing");

                        }
                    }
                } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                    //debug::log("D");

                }
            } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                //debug::log("C");

            }
        } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            //debug::log("B");

        }
        if ($ImageGalleryEntries = ImageGalleryEntry::get()->filter(array("ParentID" => $this->ID))) {
            foreach ($ImageGalleryEntries as $ImageGalleryEntry) {
                $image = Image::get()
                    ->filter(array("ID" => $ImageGalleryEntry->ImageID))
                    ->exclude(array("Title" => $ImageGalleryEntry->Title))
                    ->First();
                if ($image) {
                    $image->Title = $image->Name = $ImageGalleryEntry->Title;
                    $image->write();
                }
            }
        }
        if ($imageAdded) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //LeftAndMain::force_reload();

        }
        $this->AutomaticallyIncludedFolderID = 0;
    }

    public function NextGallery()

    {
        $pages = ImageGalleryPage::get()
            ->exclude(array("ID" => $this->ID))
            ->where("TimeDiff(\"Created\",'".$this->Created."') > 0")
            ->sort("Created", "ASC")
            ->limit(1);
        if ($pages) {
            foreach ($pages as $page) {
                return $page;
            }
        }
    }

    public function PreviousGallery()

    {
        $pages = ImageGalleryPage::get()
            ->exclude(array("ID" => $this->ID))
            ->where("TimeDiff(\"Created\",'".$this->Created."') < 0")
            ->sort("Created", "DESC")
            ->limit(1);
        if ($pages) {
            foreach ($pages as $page) {
                return $page;
            }
        }
    }
}

class ImageGalleryPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    private static $allowed_actions = array(

        "updateimagegalleryentries" => "ADMIN"
    );

    public function init()
    {
        parent::init();
        if (class_exists("PrettyPhoto")) {
            PrettyPhoto::include_code();
        }
    }

    public function updateimagegalleryentries()
    {
        $this->onBeforeWrite();
        return array();
    }
}


1		<?php
2
3		class ImageGalleryPage extends Page
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5		private static $icon = "imagegallery_basic/images/treeicons/ImageGalleryPage";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6
7		private static $allowed_children = array("ImageGalleryPage"); //can also be "none";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$allowed_children` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
8
9		private static $default_child = "ImageGalleryPage";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$default_child` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10
11		private static $description = "Page used to display images in a gallery";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$description` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12
13		private static $has_one = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14		"AutomaticallyIncludedFolder" => "Folder"
15		);
16
17		private static $has_many = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$has_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18		"ImageGalleryEntries" => "ImageGalleryEntry"
19		);
20
21		public function getCMSFields()
		0 ignored issues – show Documentation introduced 2018-02-21 04:05 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
22		{
23		$fields = parent::getCMSFields();
24		$fields->addFieldToTab("Root.Gallery", $treeDropdowField = TreeDropdownField::create($name = "AutomaticallyIncludedFolderID", $title = "Quick Add from Folder", $sourceObjectName = "Folder"));
25		$treeDropdowField->setRightTitle('
26		Add a folder here to add a bunch of images all at once.<br />
27		<a href="/admin/assets/show/'.$this->AutomaticallyIncludedFolderID.'">see files and images</a> section to add, remove and edit images in a folder before selecting one here.
28		<br />
29		Once added, you can edit the images below as you see fit.
30		');
31		$gridField = new GridField('images', 'Linked images', $this->ImageGalleryEntries(), GridFieldConfig_RelationEditor::create());
32		$fields->addFieldToTab("Root.Gallery", $gridField);
33		if (class_exists("DataObjectSorterController")) {
34		$fields->addFieldToTab(
35		"Root.Gallery",
36		LiteralField::create(
37		"ImageGalleryEntrySorter",
38		DataObjectSorterController::popup_link(
39		"ImageGalleryEntry",
40		$filterField = "ParentID",
41		$filterValue = $this->ID,
42		$linkText = "Sort Items",
43		$titleField = "FullTitle"
44		)
45		)
46		);
47		} else {
48		$fields->addFieldToTab("Root.Gallery", new NumericField($name = "Sort", "Sort index number (the lower the number, the earlier it shows up"));
49		}
50		return $fields;
51		}
52
53		public function onBeforeWrite()
54		{
55		parent::onBeforeWrite();
56		$imageAdded = false;
57		if ($this->AutomaticallyIncludedFolderID) {
58		if ($folder = Folder::get()->byID($this->AutomaticallyIncludedFolderID)) {
59		if ($files = Image::get()->filter("ParentID", $folder->ID)) {
60		foreach ($files as $file) {
61		if (ImageGalleryEntry::get()->filter(array("ImageID" => $file->ID, "ParentID" => $this->ID))->count()) {
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
62		//do nothing
63		//debug::log("already exists");
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64		} else {
65		$ImageGalleryEntry = new ImageGalleryEntry();
66		$ImageGalleryEntry->Title = $file->Title;
		0 ignored issues – show Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<ImageGalleryEntry>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
67		$ImageGalleryEntry->ImageID = $file->ID;
		0 ignored issues – show Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `ImageID` does not exist on `object<ImageGalleryEntry>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
68		$ImageGalleryEntry->ParentID = $this->ID;
		0 ignored issues – show Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `ParentID` does not exist on `object<ImageGalleryEntry>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
69		$ImageGalleryEntry->write();
70		$imageAdded = true;
71		//debug::log("writing");
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
72		}
73		}
74		} else {
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
75		//debug::log("D");
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
76		}
77		} else {
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
78		//debug::log("C");
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79		}
80		} else {
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
81		//debug::log("B");
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
82		}
83		if ($ImageGalleryEntries = ImageGalleryEntry::get()->filter(array("ParentID" => $this->ID))) {
84		foreach ($ImageGalleryEntries as $ImageGalleryEntry) {
85		$image = Image::get()
86		->filter(array("ID" => $ImageGalleryEntry->ImageID))
87		->exclude(array("Title" => $ImageGalleryEntry->Title))
88		->First();
89		if ($image) {
90		$image->Title = $image->Name = $ImageGalleryEntry->Title;
91		$image->write();
92		}
93		}
94		}
95		if ($imageAdded) {
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
96		//LeftAndMain::force_reload();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97		}
98		$this->AutomaticallyIncludedFolderID = 0;
99		}
100
101	View Code Duplication	public function NextGallery()
		0 ignored issues – show Documentation introduced 2018-08-21 23:57 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2018-08-21 23:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		{
103		$pages = ImageGalleryPage::get()
104		->exclude(array("ID" => $this->ID))
105		->where("TimeDiff(\"Created\",'".$this->Created."') > 0")
106		->sort("Created", "ASC")
107		->limit(1);
108		if ($pages) {
109		foreach ($pages as $page) {
110		return $page;
111		}
112		}
113		}
114
115	View Code Duplication	public function PreviousGallery()
		0 ignored issues – show Documentation introduced 2018-02-21 04:05 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2018-02-21 04:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		$pages = ImageGalleryPage::get()
118		->exclude(array("ID" => $this->ID))
119		->where("TimeDiff(\"Created\",'".$this->Created."') < 0")
120		->sort("Created", "DESC")
121		->limit(1);
122		if ($pages) {
123		foreach ($pages as $page) {
124		return $page;
125		}
126		}
127		}
128		}
129
130		class ImageGalleryPage_Controller extends Page_Controller
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
131		{
132		private static $allowed_actions = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
133		"updateimagegalleryentries" => "ADMIN"
134		);
135
136		public function init()
137		{
138		parent::init();
139		if (class_exists("PrettyPhoto")) {
140		PrettyPhoto::include_code();
141		}
142		}
143
144		public function updateimagegalleryentries()
145		{
146		$this->onBeforeWrite();
147		return array();
148		}
149		}
150

sunnysideup / silverstripe-imagegallery_basic

ImageGalleryPage A last analyzed 2018-08-22 00:39 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ImageGalleryPage A
last analyzed 2018-08-22 00:39 UTC