Issues in GoogleCustomSearchPage.php (master) - Issues in master - sunnysideup/silverstripe-googlecustomsearch - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/GoogleCustomSearchPage.php (17 issues)

Labels

Severity

Minor 17

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @package googlesitesearch
 */
class GoogleCustomSearchPage extends Page
namespace YourVendor;

class YourClass { }
{
    private static $icon = "googlecustomsearch/images/treeicons/GoogleCustomSearchPage";


    private static $allowed_children = "none";


    private static $can_be_root = true;


    private static $description = "Page to search via Google and display search results.";


    /**
     * Standard SS variable.
     */
    private static $singular_name = "Google Search Results Page";

    public function i18n_singular_name()
    {
        return _t("GoogleCustomSearchPage.SINGULAR_NAME", "Google Search Results Page");
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = "Google Search Results Pages";

    public function i18n_plural_name()
    {
        return _t("GoogleCustomSearchPage.PLURAL_NAME", "Google Search Results Pages");
    }

    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Searches",
            new GoogleCustomSearchPage_RecordField("stats", "Search History Last 100 Days")
        );
        return $fields;
    }

    public function requireDefaultRecords()
    {
        if ($this->canCreate()) {
            DB::alteration_message("Creating a GoogleCustomSearchPage", "created");
            $page = new GoogleCustomSearchPage();
            $page->writeToStage('Stage');
            $page->publish('Stage', 'Live');
        }
    }

    public function populateDefaults()
    {
        parent::populateDefaults();
        $this->Title = "Search";
        $this->MenuTitle = "Search";
        $this->ShowInMenus = 0;
        $this->ShowInSearch = 0;
        $this->URLSegment = "search";
    }

    public function canCreate($member = null)
    {
        return GoogleCustomSearchPage::get()->count() ?  false : true;
    }
}

class GoogleCustomSearchPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    private static $allowed_actions = array(

        "recordsearch"
    );

    public function init()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::init();
        //register any search
        if (isset($_GET["search"])) {
            $searchString = Convert::raw2sql($_GET["search"]);
            $forwardto = "";
            if (isset($_GET["forwardto"])) {
                $forwardto = Convert::raw2sql($_GET["forwardto"]);
            }
            GoogleCustomSearchPage_Record::add_entry($searchString, $forwardto);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
        if ($this->request->param("Action") != "recordsearch") {
            Requirements::themedCSS('GoogleCustomSearchPage');
            Requirements::javascript(THIRDPARTY_DIR . '/jquery/jquery.js');
            Requirements::javascript('googlecustomsearch/javascript/GoogleCustomSearchPage.js');
            $cxKey = Config::inst()->get("GoogleCustomSearchExt", "cx_key");
            Requirements::customScript("
					GoogleCustomSearchPage.cxKey = '".$cxKey."';
				",
                "GoogleCustomSearchPage"
            );
        } else {
            echo "registered ...";
        }
    }

    /**
     * template function,
     *
     * @ return String
     */
    public function SearchPhrase()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $string = "";
        if (isset($_GET['search'])) {
            $string = $_GET['search'];
        }
        return DBField::create_field('HTMLText', $string);
    }

    /**
     *
     * @return String
     */
    public function getTitle()
    {
        if ($searchPhrase = $this->SearchPhrase()->forTemplate()) {
            return $this->dataRecord->Title._t("GoogleCustomSearchPage.FOR", " for ").$searchPhrase;
        } else {
            return $this->dataRecord->Title;
        }
    }

    public function recordsearch($request)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_GET["forwardto"]) && $_GET["forwardto"]) {
            return $this->redirect($_GET["forwardto"]);
        }
    }
}


1			<?php
2
3			/**
4			* @package googlesitesearch
5			*/
6			class GoogleCustomSearchPage extends Page
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			private static $icon = "googlecustomsearch/images/treeicons/GoogleCustomSearchPage";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9
10			private static $allowed_children = "none";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$allowed_children` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11
12			private static $can_be_root = true;
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$can_be_root` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13
14			private static $description = "Page to search via Google and display search results.";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$description` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16			/**
17			* Standard SS variable.
18			*/
19			private static $singular_name = "Google Search Results Page";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			public function i18n_singular_name()
21			{
22			return _t("GoogleCustomSearchPage.SINGULAR_NAME", "Google Search Results Page");
23			}
24
25			/**
26			* Standard SS variable.
27			*/
28			private static $plural_name = "Google Search Results Pages";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
29			public function i18n_plural_name()
30			{
31			return _t("GoogleCustomSearchPage.PLURAL_NAME", "Google Search Results Pages");
32			}
33
34			public function getCMSFields()
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
35			{
36			$fields = parent::getCMSFields();
37			$fields->addFieldToTab("Root.Searches",
38			new GoogleCustomSearchPage_RecordField("stats", "Search History Last 100 Days")
39			);
40			return $fields;
41			}
42
43			public function requireDefaultRecords()
44			{
45			if ($this->canCreate()) {
46			DB::alteration_message("Creating a GoogleCustomSearchPage", "created");
47			$page = new GoogleCustomSearchPage();
48			$page->writeToStage('Stage');
49			$page->publish('Stage', 'Live');
50			}
51			}
52
53			public function populateDefaults()
54			{
55			parent::populateDefaults();
56			$this->Title = "Search";
57			$this->MenuTitle = "Search";
58			$this->ShowInMenus = 0;
59			$this->ShowInSearch = 0;
60			$this->URLSegment = "search";
61			}
62
63			public function canCreate($member = null)
64			{
65			return GoogleCustomSearchPage::get()->count() ? false : true;
66			}
67			}
68
69			class GoogleCustomSearchPage_Controller extends Page_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
70			{
71			private static $allowed_actions = array(
			0 ignored issues – show Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
72			"recordsearch"
73			);
74
75			public function init()
			0 ignored issues – show Coding Style introduced 2017-07-31 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `init` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
76			{
77			parent::init();
78			//register any search
79			if (isset($_GET["search"])) {
80			$searchString = Convert::raw2sql($_GET["search"]);
81			$forwardto = "";
82			if (isset($_GET["forwardto"])) {
83			$forwardto = Convert::raw2sql($_GET["forwardto"]);
84			}
85			GoogleCustomSearchPage_Record::add_entry($searchString, $forwardto);
			0 ignored issues – show Bug introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$searchString` defined by `\Convert::raw2sql($_GET['search'])` on line `80` can also be of type `array`; however, `GoogleCustomSearchPage_Record::add_entry()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$forwardto` defined by `\Convert::raw2sql($_GET['forwardto'])` on line `83` can also be of type `array`; however, `GoogleCustomSearchPage_Record::add_entry()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
86			}
87			if ($this->request->param("Action") != "recordsearch") {
88			Requirements::themedCSS('GoogleCustomSearchPage');
89			Requirements::javascript(THIRDPARTY_DIR . '/jquery/jquery.js');
90			Requirements::javascript('googlecustomsearch/javascript/GoogleCustomSearchPage.js');
91			$cxKey = Config::inst()->get("GoogleCustomSearchExt", "cx_key");
92			Requirements::customScript("
93			GoogleCustomSearchPage.cxKey = '".$cxKey."';
94			",
95			"GoogleCustomSearchPage"
96			);
97			} else {
98			echo "registered ...";
99			}
100			}
101
102			/**
103			* template function,
104			*
105			* @ return String
106			*/
107			public function SearchPhrase()
			0 ignored issues – show Coding Style introduced 2017-07-31 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `SearchPhrase` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
108			{
109			$string = "";
110			if (isset($_GET['search'])) {
111			$string = $_GET['search'];
112			}
113			return DBField::create_field('HTMLText', $string);
114			}
115
116			/**
117			*
118			* @return String
119			*/
120			public function getTitle()
121			{
122			if ($searchPhrase = $this->SearchPhrase()->forTemplate()) {
123			return $this->dataRecord->Title._t("GoogleCustomSearchPage.FOR", " for ").$searchPhrase;
124			} else {
125			return $this->dataRecord->Title;
126			}
127			}
128
129			public function recordsearch($request)
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Coding Style introduced 2017-07-31 11:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `recordsearch` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
130			{
131			if (isset($_GET["forwardto"]) && $_GET["forwardto"]) {
132			return $this->redirect($_GET["forwardto"]);
133			}
134			}
135			}
136

sunnysideup / silverstripe-googlecustomsearch

Issues (41)

Security Analysis not enabled

code/GoogleCustomSearchPage.php (17 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like