GoogleCustomSearchPage_Controller

Complexity

Total Complexity

11

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	init()	0	26	4
A	SearchPhrase()	0	8	2
A	getTitle()	0	8	2
A	recordsearch()	0	6	3

<?php

/**
 * @package googlesitesearch
 */
class GoogleCustomSearchPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "googlecustomsearch/images/treeicons/GoogleCustomSearchPage";

The property $icon is not used and could be removed.

    private static $allowed_children = "none";

The property $allowed_children is not used and could be removed.

    private static $can_be_root = true;

The property $can_be_root is not used and could be removed.

    private static $description = "Page to search via Google and display search results.";

The property $description is not used and could be removed.

    /**
     * Standard SS variable.
     */
    private static $singular_name = "Google Search Results Page";

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t("GoogleCustomSearchPage.SINGULAR_NAME", "Google Search Results Page");
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = "Google Search Results Pages";

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t("GoogleCustomSearchPage.PLURAL_NAME", "Google Search Results Pages");
    }

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Searches",
            new GoogleCustomSearchPage_RecordField("stats", "Search History Last 100 Days")
        );
        return $fields;
    }

    public function requireDefaultRecords()
    {
        if ($this->canCreate()) {
            DB::alteration_message("Creating a GoogleCustomSearchPage", "created");
            $page = new GoogleCustomSearchPage();
            $page->writeToStage('Stage');
            $page->publish('Stage', 'Live');
        }
    }

    public function populateDefaults()
    {
        parent::populateDefaults();
        $this->Title = "Search";
        $this->MenuTitle = "Search";
        $this->ShowInMenus = 0;
        $this->ShowInSearch = 0;
        $this->URLSegment = "search";
    }

    public function canCreate($member = null)
    {
        return GoogleCustomSearchPage::get()->count() ?  false : true;
    }
}

class GoogleCustomSearchPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        "recordsearch"
    );

    public function init()

init uses the super-global variable $_GET which is generally not recommended.

    {
        parent::init();
        //register any search
        if (isset($_GET["search"])) {
            $searchString = Convert::raw2sql($_GET["search"]);
            $forwardto = "";
            if (isset($_GET["forwardto"])) {
                $forwardto = Convert::raw2sql($_GET["forwardto"]);
            }
            GoogleCustomSearchPage_Record::add_entry($searchString, $forwardto);

It seems like $searchString defined by \Convert::raw2sql($_GET['search']) on line 80 can also be of type array; however, GoogleCustomSearchPage_Record::add_entry() does only seem to accept string, maybe add an additional type check?

It seems like $forwardto defined by \Convert::raw2sql($_GET['forwardto']) on line 83 can also be of type array; however, GoogleCustomSearchPage_Record::add_entry() does only seem to accept string, maybe add an additional type check?

        }
        if ($this->request->param("Action") != "recordsearch") {
            Requirements::themedCSS('GoogleCustomSearchPage');
            Requirements::javascript(THIRDPARTY_DIR . '/jquery/jquery.js');
            Requirements::javascript('googlecustomsearch/javascript/GoogleCustomSearchPage.js');
            $cxKey = Config::inst()->get("GoogleCustomSearchExt", "cx_key");
            Requirements::customScript("
					GoogleCustomSearchPage.cxKey = '".$cxKey."';
				",
                "GoogleCustomSearchPage"
            );
        } else {
            echo "registered ...";
        }
    }

    /**
     * template function,
     *
     * @ return String
     */
    public function SearchPhrase()

SearchPhrase uses the super-global variable $_GET which is generally not recommended.

    {
        $string = "";
        if (isset($_GET['search'])) {
            $string = $_GET['search'];
        }
        return DBField::create_field('HTMLText', $string);
    }

    /**
     *
     * @return String
     */
    public function getTitle()
    {
        if ($searchPhrase = $this->SearchPhrase()->forTemplate()) {
            return $this->dataRecord->Title._t("GoogleCustomSearchPage.FOR", " for ").$searchPhrase;
        } else {
            return $this->dataRecord->Title;
        }
    }

    public function recordsearch($request)

The return type could not be reliably inferred; please add a @return annotation.

recordsearch uses the super-global variable $_GET which is generally not recommended.

    {
        if (isset($_GET["forwardto"]) && $_GET["forwardto"]) {
            return $this->redirect($_GET["forwardto"]);
        }
    }
}