BrowseSuburbPage::create_suburb() - Code Metrics - sunnysideup/silverstripe-geobrowser - Measure and Improve Code Quality continuously with Scrutinizer

BrowseSuburbPage::create_suburb() C
last analyzed 2018-03-20 01:16 UTC

↳ Parent: BrowseSuburbPage

Complexity

Conditions	7
Paths	4

Size

Total Lines	22
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	6.9811
c	0
b	0
f	0
cc	7
eloc	17
nc	4
nop	2

<?php

/**
 * There is no data for this page.
 * We can use Google Maps to choose suburbs...?
 *
 *
 **/

class BrowseSuburbPage extends BrowseAbstractPage
namespace YourVendor;

class YourClass { }
{
    
    /**
     * Standard SS Static
     **/
    public static $icon = "geobrowser/images/treeicons/BrowseSuburbPage";
    
    /**
     * Standard SS static
     **/
    public static $db = array(
        "Longitude" => "Double(12,7)",
        "Lattitude" => "Double(12,7)"
    );

    /**
     * Standard SS Static
     **/
    public static $default_parent = "BrowseCitiesPage";
    
    /**
     * Standard SS Static
     **/
    public static $can_be_root = false;

    /**
     * Standard SS Static
     **/
    public static $defaults = array(
        "ShowInMenus" => false
    );
    

    /**
     * Standard SS method
     * CMS Fields
     **/
    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        return $fields;
    }
    
    
    /**
     * Name of the level.
     **/
    public function GeoLevelName()
    {
        return "Suburbs";
    }
    
    /**
     * number of the level.
     **/
    public function GeoLevelNumber()
    {
        return 4;
    }

    /**
     * Creates a region... called from BrowseCountriesPage
     *
     *@param Array $googleMapAddressArray - array of google Map Address Data
     *@param Object $parent - a BrowseCountriesPage object
     *@return Object | false - returns the BrowseSuburbPage if there is one.

     *
     **/
    public static function create_suburb($googleMapAddressArray, BrowseCitiesPage $parent)
    {
        if ($parent && isset($googleMapAddressArray["LocalityName"]) && isset($googleMapAddressArray[0]) && isset($googleMapAddressArray[1])) {
            $name = htmlentities($googleMapAddressArray["LocalityName"]);
            if ($name) {
                $page = DataObject::get("BrowseSuburbPage", "\"Title\" = '".$name."' AND \"ParentID\" = ".$parent->ID);
                if (!$page) {
                    $page = new BrowseSuburbPage();
                    $page->ParentID = $parent->ID;
                    $page->Title = $name;
                    $page->MetaTitle = $name;
                    $page->MenuTitle = $name;
                    $page->Longitude = $googleMapAddressArray[0];
                    $page->Latitude = $googleMapAddressArray[1];
                    $page->writeToStage('Stage');
                    $page->publish('Stage', 'Live');
                    $page->flushCache();
                }
                $page = DataObject::get("BrowseSuburbPage", "\"Title\" = '".$name."' AND \"ParentID\" = ".$parent->ID);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        }
    }
}

class BrowseSuburbPage_Controller extends BrowseAbstractPage_Controller
namespace YourVendor;

class YourClass { }
{
}


1			<?php
2
3			/**
4			* There is no data for this page.
5			* We can use Google Maps to choose suburbs...?
6			*
7			*
8			**/
9
10			class BrowseSuburbPage extends BrowseAbstractPage
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12
13			/**
14			* Standard SS Static
15			**/
16			public static $icon = "geobrowser/images/treeicons/BrowseSuburbPage";
17
18			/**
19			* Standard SS static
20			**/
21			public static $db = array(
22			"Longitude" => "Double(12,7)",
23			"Lattitude" => "Double(12,7)"
24			);
25
26			/**
27			* Standard SS Static
28			**/
29			public static $default_parent = "BrowseCitiesPage";
30
31			/**
32			* Standard SS Static
33			**/
34			public static $can_be_root = false;
35
36			/**
37			* Standard SS Static
38			**/
39			public static $defaults = array(
40			"ShowInMenus" => false
41			);
42
43
44			/**
45			* Standard SS method
46			* CMS Fields
47			**/
48			public function getCMSFields()
			0 ignored issues – show Documentation introduced 2018-02-21 04:03 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
49			{
50			$fields = parent::getCMSFields();
51			return $fields;
52			}
53
54
55			/**
56			* Name of the level.
57			**/
58			public function GeoLevelName()
59			{
60			return "Suburbs";
61			}
62
63			/**
64			* number of the level.
65			**/
66			public function GeoLevelNumber()
67			{
68			return 4;
69			}
70
71			/**
72			* Creates a region... called from BrowseCountriesPage
73			*
74			*@param Array $googleMapAddressArray - array of google Map Address Data
75			*@param Object $parent - a BrowseCountriesPage object
76			*@return Object \| false - returns the BrowseSuburbPage if there is one.
			0 ignored issues – show Documentation introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report Should the return type not be `object\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
77			*
78			**/
79			public static function create_suburb($googleMapAddressArray, BrowseCitiesPage $parent)
80			{
81			if ($parent && isset($googleMapAddressArray["LocalityName"]) && isset($googleMapAddressArray[0]) && isset($googleMapAddressArray[1])) {
82			$name = htmlentities($googleMapAddressArray["LocalityName"]);
83			if ($name) {
84			$page = DataObject::get("BrowseSuburbPage", "\"Title\" = '".$name."' AND \"ParentID\" = ".$parent->ID);
85			if (!$page) {
86			$page = new BrowseSuburbPage();
87			$page->ParentID = $parent->ID;
88			$page->Title = $name;
89			$page->MetaTitle = $name;
90			$page->MenuTitle = $name;
91			$page->Longitude = $googleMapAddressArray[0];
92			$page->Latitude = $googleMapAddressArray[1];
93			$page->writeToStage('Stage');
94			$page->publish('Stage', 'Live');
95			$page->flushCache();
96			}
97			$page = DataObject::get("BrowseSuburbPage", "\"Title\" = '".$name."' AND \"ParentID\" = ".$parent->ID);
			0 ignored issues – show Unused Code introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report `$page` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98			}
99			}
100			}
101			}
102
103			class BrowseSuburbPage_Controller extends BrowseAbstractPage_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
104			{
105			}
106

sunnysideup / silverstripe-geobrowser

BrowseSuburbPage::create_suburb() C last analyzed 2018-03-20 01:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BrowseSuburbPage::create_suburb() C
last analyzed 2018-03-20 01:16 UTC