BrowseSuburbPage

Complexity

Total Complexity

10

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	5	1
A	GeoLevelName()	0	4	1
A	GeoLevelNumber()	0	4	1
C	create_suburb()	0	22	7

<?php

/**
 * There is no data for this page.
 * We can use Google Maps to choose suburbs...?
 *
 *
 **/

class BrowseSuburbPage extends BrowseAbstractPage

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    
    /**
     * Standard SS Static
     **/
    public static $icon = "geobrowser/images/treeicons/BrowseSuburbPage";
    
    /**
     * Standard SS static
     **/
    public static $db = array(
        "Longitude" => "Double(12,7)",
        "Lattitude" => "Double(12,7)"
    );

    /**
     * Standard SS Static
     **/
    public static $default_parent = "BrowseCitiesPage";
    
    /**
     * Standard SS Static
     **/
    public static $can_be_root = false;

    /**
     * Standard SS Static
     **/
    public static $defaults = array(
        "ShowInMenus" => false
    );
    

    /**
     * Standard SS method
     * CMS Fields
     **/
    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        return $fields;
    }
    
    
    /**
     * Name of the level.
     **/
    public function GeoLevelName()
    {
        return "Suburbs";
    }
    
    /**
     * number of the level.
     **/
    public function GeoLevelNumber()
    {
        return 4;
    }

    /**
     * Creates a region... called from BrowseCountriesPage
     *
     *@param Array $googleMapAddressArray - array of google Map Address Data
     *@param Object $parent - a BrowseCountriesPage object
     *@return Object | false - returns the BrowseSuburbPage if there is one.

Should the return type not be object|null?

     *
     **/
    public static function create_suburb($googleMapAddressArray, BrowseCitiesPage $parent)
    {
        if ($parent && isset($googleMapAddressArray["LocalityName"]) && isset($googleMapAddressArray[0]) && isset($googleMapAddressArray[1])) {
            $name = htmlentities($googleMapAddressArray["LocalityName"]);
            if ($name) {
                $page = DataObject::get("BrowseSuburbPage", "\"Title\" = '".$name."' AND \"ParentID\" = ".$parent->ID);
                if (!$page) {
                    $page = new BrowseSuburbPage();
                    $page->ParentID = $parent->ID;
                    $page->Title = $name;
                    $page->MetaTitle = $name;
                    $page->MenuTitle = $name;
                    $page->Longitude = $googleMapAddressArray[0];
                    $page->Latitude = $googleMapAddressArray[1];
                    $page->writeToStage('Stage');
                    $page->publish('Stage', 'Live');
                    $page->flushCache();
                }
                $page = DataObject::get("BrowseSuburbPage", "\"Title\" = '".$name."' AND \"ParentID\" = ".$parent->ID);

$page is not used, you could remove the assignment.

            }
        }
    }
}

class BrowseSuburbPage_Controller extends BrowseAbstractPage_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
}