EdmundsAPI::get_data() - Code Metrics - sunnysideup/silverstripe-electric-vehicle-calculator - Measure and Improve Code Quality continuously with Scrutinizer

EdmundsAPI::get_data() A
last analyzed 2018-03-20 01:14 UTC

↳ Parent: EdmundsAPI

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	2

<?php
/**
 * requires external API
 *
 */


class EdmundsAPI extends Edmunds\SDK\ApiClient
namespace YourVendor;

class YourClass { }
{
    private static $api_key = "";


    private static $secret = "";


    private static $_cache = null;

    public function __construct()

    {
        if (!self::$_cache) {
            self::$_cache = new Edmunds\SDK\ApiCache(TEMP_FOLDER);
        }
        return parent::__construct(Config::inst()->get("EdmundsAPI", "api_key"), self::$_cache);

    }

    public static function get_data($call, $params)

    {
        if (substr($call, 0, 1) !== "/") {
            $call = "/".$call;
        }
        $obj = Injector::inst()->get("EdmundsAPI");
        return $obj->makeCall($call, $params);
    }
}


1			<?php
2			/**
3			* requires external API
4			*
5			*/
6
7
8			class EdmundsAPI extends Edmunds\SDK\ApiClient
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			private static $api_key = "";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$api_key` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11
12			private static $secret = "";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$secret` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13
14			private static $_cache = null;
15
16			public function __construct()
			0 ignored issues – show Documentation introduced 2017-09-20 09:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
17			{
18			if (!self::$_cache) {
19			self::$_cache = new Edmunds\SDK\ApiCache(TEMP_FOLDER);
20			}
21			return parent::__construct(Config::inst()->get("EdmundsAPI", "api_key"), self::$_cache);
			0 ignored issues – show Bug introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
22			}
23
24			public static function get_data($call, $params)
			0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
25			{
26			if (substr($call, 0, 1) !== "/") {
27			$call = "/".$call;
28			}
29			$obj = Injector::inst()->get("EdmundsAPI");
30			return $obj->makeCall($call, $params);
31			}
32			}
33

sunnysideup / silverstripe-electric-vehicle-calculator

EdmundsAPI::get_data() A last analyzed 2018-03-20 01:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EdmundsAPI::get_data() A
last analyzed 2018-03-20 01:14 UTC