EdmundsAPI

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	get_data()	0	8	2

<?php
/**
 * requires external API
 *
 */


class EdmundsAPI extends Edmunds\SDK\ApiClient

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $api_key = "";

The property $api_key is not used and could be removed.

    private static $secret = "";

The property $secret is not used and could be removed.

    private static $_cache = null;

    public function __construct()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (!self::$_cache) {
            self::$_cache = new Edmunds\SDK\ApiCache(TEMP_FOLDER);
        }
        return parent::__construct(Config::inst()->get("EdmundsAPI", "api_key"), self::$_cache);

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    public static function get_data($call, $params)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (substr($call, 0, 1) !== "/") {
            $call = "/".$call;
        }
        $obj = Injector::inst()->get("EdmundsAPI");
        return $obj->makeCall($call, $params);
    }
}