PickUpOrDeliveryModifierOptions_SubTotalBracket::i18n_singular_name() - Code Metrics - sunnysideup/silverstripe-ecommerce_delivery - Measure and Improve Code Quality continuously with Scrutinizer

i18n_singular_name() A
last analyzed 2018-03-20 01:04 UTC

↳ Parent: PickUpOrDeliveryModifierOptions_SubTotalBracket

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php


/**
 * below we record options for subTotal brackets with fixed cost
 * e.g. if Order.SubTotal > 10 and Order.SubTotal < 20 => Charge is $111.
 *
 *
 *
 */
class PickUpOrDeliveryModifierOptions_SubTotalBracket extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "Name" => "Varchar",
        "MinimumSubTotal" => "Currency",
        "MaximumSubTotal" => "Currency",
        "FixedCost" => "Currency"
    );

    private static $belongs_many_many = array(

        "PickUpOrDeliveryModifierOptions" => "PickUpOrDeliveryModifierOptions"
    );

    private static $indexes = array(

        "MinimumSubTotal" => true,
        "MaximumSubTotal" => true
    );

    private static $searchable_fields = array(

        "Name" => "PartialMatchFilter"
    );

    private static $field_labels = array(

        "Name" => "Description (e.g. order below a hundy)",
        "MinimumSubTotal" => "The minimum Sub-Total for the Order",
        "MaximumSubTotal" => "The maximum Sub-Total for the Order",
        "FixedCost" => "Total price (fixed cost)"
    );

    private static $summary_fields = array(

        "Name",
        "MinimumSubTotal",
        "MaximumSubTotal",
        "FixedCost"
    );

    private static $singular_name = "Sub-Total Bracket";


    public function i18n_singular_name()
    {
        return _t("PickUpOrDeliveryModifierOptions.SUBTOTAL_BRACKET", "Sub-Total Bracket");
    }

    private static $plural_name = "SubTotal Brackets";


    public function i18n_plural_name()
    {
        return _t("PickUpOrDeliveryModifierOptions.SUBTOTAL_BRACKETS", "Sub-Total Brackets");
    }

    private static $default_sort = "MinimumSubTotal ASC, MaximumSubTotal ASC";



    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canCreate($member = null)

    {
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canCreate($member);
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean
     */
    public function canView($member = null)
    {
        return true;
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canEdit($member = null)

    {
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canEdit($member);
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canDelete($member = null)

    {
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canDelete($member);
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField('Name', ReadonlyField::create('Name', 'Description'));
        return $fields;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->Name = 'MIN '.$this->MinimumSubTotal.' MAX '.$this->MaximumSubTotal. ', COST: '.$this->FixedCost;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1		<?php
2
3
4		/**
5		* below we record options for subTotal brackets with fixed cost
6		* e.g. if Order.SubTotal > 10 and Order.SubTotal < 20 => Charge is $111.
7		*
8		*
9		*
10		*/
11		class PickUpOrDeliveryModifierOptions_SubTotalBracket extends DataObject
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12		{
13		private static $db = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14		"Name" => "Varchar",
15		"MinimumSubTotal" => "Currency",
16		"MaximumSubTotal" => "Currency",
17		"FixedCost" => "Currency"
18		);
19
20		private static $belongs_many_many = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$belongs_many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21		"PickUpOrDeliveryModifierOptions" => "PickUpOrDeliveryModifierOptions"
22		);
23
24		private static $indexes = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$indexes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
25		"MinimumSubTotal" => true,
26		"MaximumSubTotal" => true
27		);
28
29		private static $searchable_fields = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
30		"Name" => "PartialMatchFilter"
31		);
32
33		private static $field_labels = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
34		"Name" => "Description (e.g. order below a hundy)",
35		"MinimumSubTotal" => "The minimum Sub-Total for the Order",
36		"MaximumSubTotal" => "The maximum Sub-Total for the Order",
37		"FixedCost" => "Total price (fixed cost)"
38		);
39
40		private static $summary_fields = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
41		"Name",
42		"MinimumSubTotal",
43		"MaximumSubTotal",
44		"FixedCost"
45		);
46
47		private static $singular_name = "Sub-Total Bracket";
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
48
49		public function i18n_singular_name()
50		{
51		return _t("PickUpOrDeliveryModifierOptions.SUBTOTAL_BRACKET", "Sub-Total Bracket");
52		}
53
54		private static $plural_name = "SubTotal Brackets";
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
55
56		public function i18n_plural_name()
57		{
58		return _t("PickUpOrDeliveryModifierOptions.SUBTOTAL_BRACKETS", "Sub-Total Brackets");
59		}
60
61		private static $default_sort = "MinimumSubTotal ASC, MaximumSubTotal ASC";
		0 ignored issues – show Comprehensibility introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
62
63
64		/**
65		* standard SS method
66		* @param Member \| NULL
67		* @return Boolean
		0 ignored issues – show Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
68		*/
69	View Code Duplication	public function canCreate($member = null)
		0 ignored issues – show Duplication introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
72		return true;
73		}
74		return parent::canCreate($member);
75		}
76
77		/**
78		* standard SS method
79		* @param Member \| NULL
80		* @return Boolean
81		*/
82		public function canView($member = null)
83		{
84		return true;
85		}
86
87		/**
88		* standard SS method
89		* @param Member \| NULL
90		* @return Boolean
		0 ignored issues – show Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
91		*/
92	View Code Duplication	public function canEdit($member = null)
		0 ignored issues – show Duplication introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		{
94		if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
95		return true;
96		}
97		return parent::canEdit($member);
98		}
99
100		/**
101		* standard SS method
102		* @param Member \| NULL
103		* @return Boolean
		0 ignored issues – show Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
104		*/
105	View Code Duplication	public function canDelete($member = null)
		0 ignored issues – show Duplication introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
108		return true;
109		}
110		return parent::canDelete($member);
111		}
112
113		/**
114		* CMS Fields
115		* @return FieldList
116		*/
117		public function getCMSFields()
118		{
119		$fields = parent::getCMSFields();
120		$fields->replaceField('Name', ReadonlyField::create('Name', 'Description'));
121		return $fields;
122		}
123
124		public function onBeforeWrite()
125		{
126		parent::onBeforeWrite();
127		$this->Name = 'MIN '.$this->MinimumSubTotal.' MAX '.$this->MaximumSubTotal. ', COST: '.$this->FixedCost;
		0 ignored issues – show Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `object<PickUpOrDeliveryM...ptions_SubTotalBracket>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `MinimumSubTotal` does not exist on `object<PickUpOrDeliveryM...ptions_SubTotalBracket>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `MaximumSubTotal` does not exist on `object<PickUpOrDeliveryM...ptions_SubTotalBracket>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 00:41 UTC by Report Bug Copy Issue Report The property `FixedCost` does not exist on `object<PickUpOrDeliveryM...ptions_SubTotalBracket>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
128		}
129		}
130

sunnysideup / silverstripe-ecommerce_delivery

i18n_singular_name() A last analyzed 2018-03-20 01:04 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

i18n_singular_name() A
last analyzed 2018-03-20 01:04 UTC