PickUpOrDeliveryModifierOptions_SubTotalBracket

Complexity

Total Complexity

11

Size/Duplication

Total Lines	119
Duplicated Lines	17.65 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	canCreate()	7	7	2
A	canView()	0	4	1
A	canEdit()	7	7	2
A	canDelete()	7	7	2
A	getCMSFields()	0	6	1
A	onBeforeWrite()	0	5	1

<?php


/**
 * below we record options for subTotal brackets with fixed cost
 * e.g. if Order.SubTotal > 10 and Order.SubTotal < 20 => Charge is $111.
 *
 *
 *
 */
class PickUpOrDeliveryModifierOptions_SubTotalBracket extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        "Name" => "Varchar",
        "MinimumSubTotal" => "Currency",
        "MaximumSubTotal" => "Currency",
        "FixedCost" => "Currency"
    );

    private static $belongs_many_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $belongs_many_many is not used and could be removed.

        "PickUpOrDeliveryModifierOptions" => "PickUpOrDeliveryModifierOptions"
    );

    private static $indexes = array(

Consider using a different property name as you override a private property of the parent class.

The property $indexes is not used and could be removed.

        "MinimumSubTotal" => true,
        "MaximumSubTotal" => true
    );

    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        "Name" => "PartialMatchFilter"
    );

    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        "Name" => "Description (e.g. order below a hundy)",
        "MinimumSubTotal" => "The minimum Sub-Total for the Order",
        "MaximumSubTotal" => "The maximum Sub-Total for the Order",
        "FixedCost" => "Total price (fixed cost)"
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        "Name",
        "MinimumSubTotal",
        "MaximumSubTotal",
        "FixedCost"
    );

    private static $singular_name = "Sub-Total Bracket";

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t("PickUpOrDeliveryModifierOptions.SUBTOTAL_BRACKET", "Sub-Total Bracket");
    }

    private static $plural_name = "SubTotal Brackets";

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t("PickUpOrDeliveryModifierOptions.SUBTOTAL_BRACKETS", "Sub-Total Brackets");
    }

    private static $default_sort = "MinimumSubTotal ASC, MaximumSubTotal ASC";

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

Should the return type not be boolean|string|null?

     */
    public function canCreate($member = null)

This method seems to be duplicated in your project.

    {
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canCreate($member);
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean
     */
    public function canView($member = null)
    {
        return true;
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

Should the return type not be boolean|string|null?

     */
    public function canEdit($member = null)

This method seems to be duplicated in your project.

    {
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canEdit($member);
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

Should the return type not be boolean|string|null?

     */
    public function canDelete($member = null)

This method seems to be duplicated in your project.

    {
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canDelete($member);
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField('Name', ReadonlyField::create('Name', 'Description'));
        return $fields;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->Name = 'MIN '.$this->MinimumSubTotal.' MAX '.$this->MaximumSubTotal. ', COST: '.$this->FixedCost;

The property Name does not exist on object<PickUpOrDeliveryModifierOptions_SubTotalBracket>. Since you implemented __set, maybe consider adding a @property annotation.

The property MinimumSubTotal does not exist on object<PickUpOrDeliveryModifierOptions_SubTotalBracket>. Since you implemented __get, maybe consider adding a @property annotation.

The property MaximumSubTotal does not exist on object<PickUpOrDeliveryModifierOptions_SubTotalBracket>. Since you implemented __get, maybe consider adding a @property annotation.

The property FixedCost does not exist on object<PickUpOrDeliveryModifierOptions_SubTotalBracket>. Since you implemented __get, maybe consider adding a @property annotation.

    }
}