Passed
Push — master ( 4ebc9d...305f3a )
by Nicolaas
02:38
created
code/control/cms/CountryPrice_TestController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -347,7 +347,7 @@
 block discarded – undo
347 347
     /**
348 348
      * returns the Distributor for the user
349 349
      * Needs to be in model so we can access from the order in the template.
350
-     * @return Varchar Field
350
+     * @return Distributor Field
351 351
      */
352 352
     public function MyDistributor()
353 353
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     public function init()
17 17
     {
18 18
         parent::init();
19
-        if (! Permission::check('ADMIN')) {
19
+        if (!Permission::check('ADMIN')) {
20 20
             return Security::permissionFailure($this, 'This page is secured and you need administrator rights to access it. You can also save the page in the CMS to get 15 minutes access without being logged in.');
21 21
         }
22 22
     }
@@ -181,17 +181,17 @@  discard block
 block discarded – undo
181 181
             "MyCountryCode" => "This is the key function",
182 182
             "MyCountryTitle" => "",
183 183
             "MyCurrency" => "Based on the currency set in the order.",
184
-            "MyDistributor" => "You have to set the ". _t('Distributor.SINGULAR_NAME', 'Distributor') . "'s countries in order to work out someone's ". _t('Distributor.SINGULAR_NAME', 'Distributor') . ".",
184
+            "MyDistributor" => "You have to set the "._t('Distributor.SINGULAR_NAME', 'Distributor')."'s countries in order to work out someone's "._t('Distributor.SINGULAR_NAME', 'Distributor').".",
185 185
             "MyDistributorCountry" => "This is the country that is being used for the sale.  For dodgy countries, we use the backup country.",
186
-            "MyDeliveryCostNote" => "Set in country, ". _t('Distributor.SINGULAR_NAME', 'Distributor') . " and default country.",
187
-            "MyShippingDeliveryInfo" => "Set in country, ". _t('Distributor.SINGULAR_NAME', 'Distributor') . " and default country.",
188
-            "MyShippingReturnInfo" => "Set in country, ". _t('Distributor.SINGULAR_NAME', 'Distributor') . " and default country.",
189
-            "MyProductNotAvailableNote" => "Set in country, ". _t('Distributor.SINGULAR_NAME', 'Distributor') . ", default country, AND the Ecommerce Config.",
186
+            "MyDeliveryCostNote" => "Set in country, "._t('Distributor.SINGULAR_NAME', 'Distributor')." and default country.",
187
+            "MyShippingDeliveryInfo" => "Set in country, "._t('Distributor.SINGULAR_NAME', 'Distributor')." and default country.",
188
+            "MyShippingReturnInfo" => "Set in country, "._t('Distributor.SINGULAR_NAME', 'Distributor')." and default country.",
189
+            "MyProductNotAvailableNote" => "Set in country, "._t('Distributor.SINGULAR_NAME', 'Distributor').", default country, AND the Ecommerce Config.",
190 190
             "MyStockistSearchPage" => "",
191 191
             "MyStockistCountryPage" => "The stockist page that is related to the visitor's country",
192 192
             "MyCountryFAQPage" => "",
193 193
             "MyBackupCountryCode" => "This country is used if the information for the selected country is not available.",
194
-            "MyDefaultDistributor" => "You can set one default ". _t('Distributor.SINGULAR_NAME', 'Distributor') . " (head office) with a tickbox for any ". _t('Distributor.SINGULAR_NAME', 'Distributor') ,
194
+            "MyDefaultDistributor" => "You can set one default "._t('Distributor.SINGULAR_NAME', 'Distributor')." (head office) with a tickbox for any "._t('Distributor.SINGULAR_NAME', 'Distributor'),
195 195
 
196 196
         );
197 197
         $array = array(
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
             "MyDefaultDistributor" => "Object",
212 212
         );
213 213
         echo "<h1>Current Settings</h1>";
214
-        echo "<p>Most of these settings can be adjusted in the country, ". _t('Distributor.SINGULAR_NAME', 'Distributor') . " and generic e-commerce settings.</p>";
214
+        echo "<p>Most of these settings can be adjusted in the country, "._t('Distributor.SINGULAR_NAME', 'Distributor')." and generic e-commerce settings.</p>";
215 215
         foreach ($array as $name => $type) {
216 216
             $style = "created";
217 217
             $notSet = false;
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
                     }
246 246
                 }
247 247
             }
248
-            if (! $string) {
248
+            if (!$string) {
249 249
                 $string = "NOT SET";
250 250
                 $style = "deleted";
251 251
             }
Please login to merge, or discard this patch.
code/model/buyables/CountryPrice_CopyPrices.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,6 @@
 block discarded – undo
96 96
      *  - ID
97 97
      * searches through children, until all all childpages have been added
98 98
      *
99
-     * @param  string $country [description]
100 99
      * @param  array  $values  [description]
101 100
      * @return array          [description]
102 101
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,11 +25,11 @@
 block discarded – undo
25 25
             } else {
26 26
                 $fromCountriesArray = array();
27 27
             }
28
-            $allCountries =  EcommerceCountry::get();
28
+            $allCountries = EcommerceCountry::get();
29 29
             $toCountries = array();
30 30
             foreach ($allCountries as $country) {
31 31
                 $country = CountryPrice_EcommerceCountry::get_real_country($country);
32
-                $toCountries[$country->Code] = $country->Name . ($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
32
+                $toCountries[$country->Code] = $country->Name.($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
33 33
             }
34 34
             $countryCurrencies = CountryPrice_EcommerceCurrency::get_currency_per_country();
35 35
             $link = CountryPrice_CopyPrices_Controller::get_link($this->owner);
Please login to merge, or discard this patch.
code/model/CountryPrice.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -244,7 +244,7 @@
 block discarded – undo
244 244
 
245 245
     /**
246 246
      * Returns if the currency is an old currency not used anymore.
247
-     * @return Boolean
247
+     * @return boolean|null
248 248
      */
249 249
     public function isObsolete()
250 250
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function Buyable()
67 67
     {
68
-        if(! $this->_myBuyable) {
68
+        if (!$this->_myBuyable) {
69 69
             $className = $this->ObjectClass;
70
-            if ( class_exists($this->ObjectClass) ) {
70
+            if (class_exists($this->ObjectClass)) {
71 71
                 $this->_myBuyable = $className::get()->byID($this->ObjectID);
72 72
             }
73 73
         }
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
      */
88 88
     public function CountryObject()
89 89
     {
90
-        if(! $this->_myCountryObject) {
90
+        if (!$this->_myCountryObject) {
91 91
             if ($this->Country) {
92
-                $this->_myCountryObject =  EcommerceCountry::get()
92
+                $this->_myCountryObject = EcommerceCountry::get()
93 93
                     ->filter(array("Code" => $this->Country))
94 94
                     ->First();
95 95
             }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function getFullPrice()
148 148
     {
149
-        return "$this->Price $this->Currency" . ($this->isObsolete() ? ' (obsolete!)' : '');
149
+        return "$this->Price $this->Currency".($this->isObsolete() ? ' (obsolete!)' : '');
150 150
     }
151 151
 
152 152
     public function getCMSFields()
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     public function canEdit($member = null)
219 219
     {
220 220
         $canEdit = parent::canEdit();
221
-        if (! $canEdit) {
221
+        if (!$canEdit) {
222 222
             $member = Member::currentUser();
223 223
             $distributor = $member->Distributor();
224 224
             if ($distributor->exists()) {
@@ -236,16 +236,16 @@  discard block
 block discarded – undo
236 236
     protected function validate()
237 237
     {
238 238
         $result = parent::validate();
239
-        if (! $this->ObjectClass && isset($_REQUEST["MyObjectClass"])) {
239
+        if (!$this->ObjectClass && isset($_REQUEST["MyObjectClass"])) {
240 240
             if (class_exists($_REQUEST["MyObjectClass"])) {
241 241
                 $this->ObjectClass = Convert::raw2sql($_REQUEST["MyObjectClass"]);
242 242
             }
243 243
         }
244
-        if (! $this->ObjectID && isset($_REQUEST["MyObjectID"])) {
244
+        if (!$this->ObjectID && isset($_REQUEST["MyObjectID"])) {
245 245
             $this->ObjectID = intval($_REQUEST["MyObjectID"]);
246 246
         }
247 247
         //check for duplicates in case it has not been created yet...
248
-        if (! $this->ObjectClass || ! $this->ObjectID) {
248
+        if (!$this->ObjectClass || !$this->ObjectID) {
249 249
             $result->error('Object could not be created. Please contact your developer.');
250 250
             return $result;
251 251
         }
Please login to merge, or discard this patch.
code/model/process/extensions/CountryPrice_OrderDOD.php 3 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -47,6 +47,7 @@
 block discarded – undo
47 47
      * this method basically makes sure that the Order
48 48
      * has all the localised stuff attached to it, specifically
49 49
      * the right currency
50
+     * @param string $countryCode
50 51
      */
51 52
     public static function localise_order($countryCode = null, $force = false)
52 53
     {
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         $order = Order::get()->byID($order->ID);
101 101
         $orderHasBeenChanged = false;
102 102
 
103
-         //check currency ...
103
+            //check currency ...
104 104
         if ($order->CurrencyUsedID != $currencyObject->ID) {
105 105
             $order->SetCurrency($currencyObject);
106 106
             $orderHasBeenChanged = true;
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
                 'Root.Country',
149 149
                 DropdownField::create(
150 150
                     'DistributorID',
151
-                     _t('Distributor.SINGULAR_NAME', 'Distributor'),
151
+                        _t('Distributor.SINGULAR_NAME', 'Distributor'),
152 152
                     array(''=> '--- Please select ---') + Distributor::get()->map()->toArray()
153 153
                 )
154 154
             );
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         if ($order->IsSubmitted()) {
62 62
             return true;
63 63
         }
64
-        if (! $countryCode) {
64
+        if (!$countryCode) {
65 65
             $countryCode = $order->getCountry();
66 66
         }
67 67
         $currencyObject = CountryPrice_EcommerceCurrency::get_currency_for_country($countryCode);
@@ -75,13 +75,13 @@  discard block
 block discarded – undo
75 75
         //check if the billing and shipping address have a country so that they will not be overridden by previous Orders
76 76
         //we do this to make sure that the previous address can not change the region and thereby destroy the order in the cart
77 77
         if ($billingAddress = $order->CreateOrReturnExistingAddress('BillingAddress')) {
78
-            if (! $billingAddress->Country || $force) {
78
+            if (!$billingAddress->Country || $force) {
79 79
                 $billingAddress->Country = $countryCode;
80 80
                 $billingAddress->write();
81 81
             }
82 82
         }
83 83
         if ($shippingAddress = $order->CreateOrReturnExistingAddress('ShippingAddress')) {
84
-            if (! $shippingAddress->ShippingCountry || $force) {
84
+            if (!$shippingAddress->ShippingCountry || $force) {
85 85
                 $shippingAddress->ShippingCountry = $countryCode;
86 86
                 $shippingAddress->write();
87 87
             }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         //if a country code and currency has been set then all is good
91 91
         //from there we keep it this way
92 92
         if (
93
-            $order->OriginatingCountryCode ==  $countryCode &&
93
+            $order->OriginatingCountryCode == $countryCode &&
94 94
             $order->CurrencyUsedID == $currencyObject->ID
95 95
         ) {
96 96
             return true;
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
             if ($items) {
112 112
                 foreach ($items as $item) {
113 113
                     $buyable = $item->Buyable(true);
114
-                    if (! $buyable->canPurchase()) {
114
+                    if (!$buyable->canPurchase()) {
115 115
                         $item->delete();
116 116
                     }
117 117
                 }
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
      */
156 156
     public function onAfterWrite()
157 157
     {
158
-        if(! $this->owner->DistributorID) {
159
-            if($defaultDistributor = Distributor::get_default_distributor()) {
160
-                if($defaultDistributor->exists()) {
161
-                    if($defaultDistributor->ID) {
158
+        if (!$this->owner->DistributorID) {
159
+            if ($defaultDistributor = Distributor::get_default_distributor()) {
160
+                if ($defaultDistributor->exists()) {
161
+                    if ($defaultDistributor->ID) {
162 162
                         $this->owner->DistributorID = $defaultDistributor->ID;
163 163
                         $this->owner->write();
164 164
                     }
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 
175 175
     public function canEdit($member = null)
176 176
     {
177
-        if (! $member) {
177
+        if (!$member) {
178 178
             $member = Member::currentUser();
179 179
         }
180 180
         if ($member) {
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 $countryMessageObject->CountrySpecificEmailMessage
286 286
             );
287 287
         }
288
-        if($step->SendEmailToDistributor) {
288
+        if ($step->SendEmailToDistributor) {
289 289
             if ($distributor = $this->owner->Distributor()) {
290 290
                 $distributorEmail = $distributor->Email;
291 291
                 if ($distributorEmail) {
Please login to merge, or discard this patch.
code/forms/CountryPrice_OrderFormAddressExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
         if ($allowedCountries->count()) {
13 13
             $allowedCountryCodes = $allowedCountries->column('Code');
14 14
             foreach ($newSource as $key => $value) {
15
-                if (! in_array($key, $allowedCountryCodes)) {
15
+                if (!in_array($key, $allowedCountryCodes)) {
16 16
                     unset($newSource[$key]);
17 17
                 }
18 18
             }
Please login to merge, or discard this patch.
code/model/Distributor.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         //secondary for another country
112 112
         $fields->removeByName('Versions');
113 113
         if ($listOfCountriesCovered && $listOfCountriesCovered->count()) {
114
-            $countryArray =  array(" -- please select --") + $listOfCountriesCovered->toArray();
114
+            $countryArray = array(" -- please select --") + $listOfCountriesCovered->toArray();
115 115
             $fields->addFieldToTab("Root.CountryDetails", DropdownField::create("PrimaryCountryID", "Primary Country", $countryArray));
116 116
         } else {
117 117
             $fields->removeByName('PrimaryCountryID');
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
                         'IsDefault' => 'Default',
144 144
                         'Email' => 'Email'
145 145
                     );
146
-                    $table = '<table class="versions"><thead><tr><th>' . implode('</th><th>', $columns) . '</th></tr></thead><tbody>';
146
+                    $table = '<table class="versions"><thead><tr><th>'.implode('</th><th>', $columns).'</th></tr></thead><tbody>';
147 147
                     $version = $this->Version - 1;
148 148
                     while ($version > 0) {
149 149
                         $versionDO = Versioned::get_version('Distributor', $this->ID, $version--);
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
                         foreach ($columns as $column => $title) {
152 152
                             $values[] = $versionDO->$column;
153 153
                         }
154
-                        $table .= '<tr><td>' . implode('</td><td>', $values) . '</td></tr>';
154
+                        $table .= '<tr><td>'.implode('</td><td>', $values).'</td></tr>';
155 155
                     }
156 156
                     $table .= '</tbody></table>';
157 157
                     $table .= "<style type=\"text/css\">
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
         }
235 235
         if ($this->PrimaryCountryID > 0 && EcommerceCountry::get()->byID(intval($this->PrimaryCountryID))) {
236 236
             $primaryCountry = $this->PrimaryCountry();
237
-            if (! $this->Countries()->byID($this->PrimaryCountryID)) {
237
+            if (!$this->Countries()->byID($this->PrimaryCountryID)) {
238 238
                 $this->Countries()->add($primaryCountry);
239 239
             }
240 240
         } else {
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
     public function onAfterWrite()
254 254
     {
255 255
         parent::onAfterWrite();
256
-        if (! self::$_ran_after_write) {
256
+        if (!self::$_ran_after_write) {
257 257
             self::$_ran_after_write = true;
258 258
             $this->setupUser();
259 259
         }
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
                 $member = Member::create($filter);
372 372
                 //$thisMember->SetPassword = substr(session_id, 0, 8);
373 373
             }
374
-            $member->FirstName = trim(_t('Distributor.SINGULAR_NAME', 'Distributor') . _t('Distributor.FOR', ' for '));
374
+            $member->FirstName = trim(_t('Distributor.SINGULAR_NAME', 'Distributor')._t('Distributor.FOR', ' for '));
375 375
             $member->Surname = $this->Name;
376 376
             $member->DistributorID = $this->ID;
377 377
             $member->write();
Please login to merge, or discard this patch.
model/process/extensions/CountryPrice_OrderStatusLog_AND_OrderAtribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
     }
9 9
     public function canView($member = null)
10 10
     {
11
-        if (! $this->owner->ID) {
11
+        if (!$this->owner->ID) {
12 12
             return true;
13 13
         } elseif ($member && $member->DistributorID) {
14 14
             if ($order = $this->owner->Order()) {
Please login to merge, or discard this patch.
code/model/address/CountryPrice_EcommerceCountry.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -163,9 +163,9 @@
 block discarded – undo
163 163
     }
164 164
 
165 165
     /**
166
-    * checks if the country has a distributor
167
-    * and returns the primary country for the distributor.
168
-    * If not, returns the defaulf country.
166
+     * checks if the country has a distributor
167
+     * and returns the primary country for the distributor.
168
+     * If not, returns the defaulf country.
169 169
      *
170 170
      * @return EcommerceCountry
171 171
      *
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                     'Root.FAQPage',
89 89
                     new LiteralField(
90 90
                         "FAQPageExplanation",
91
-                        "<p class=\"message warning\">FAQ information can only be added to the main country for a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ."</p>"
91
+                        "<p class=\"message warning\">FAQ information can only be added to the main country for a "._t('Distributor.SINGULAR_NAME', 'Distributor')."</p>"
92 92
                     )
93 93
                 );
94 94
             }
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
         $order = ShoppingCart::current_order();
201 201
 
202 202
         //get country from EcommerceCountry
203
-        if (! $country) {
203
+        if (!$country) {
204 204
             $country = EcommerceCountry::get_country();
205 205
         }
206 206
 
@@ -240,9 +240,9 @@  discard block
 block discarded – undo
240 240
     public static function get_backup_country()
241 241
     {
242 242
         $obj = EcommerceCountry::get()->filter(array("IsBackupCountry" => true))->first();
243
-        if (! $obj) {
243
+        if (!$obj) {
244 244
             $obj = EcommerceCountry::get()->filter(array("Code" => EcommerceConfig::get('EcommerceCountry', 'default_country_code')))->first();
245
-            if (! $obj) {
245
+            if (!$obj) {
246 246
                 $obj = EcommerceCountry::get()->first();
247 247
             }
248 248
         }
Please login to merge, or discard this patch.
code/control/cms/CountryPrice_DistributorManagementTool.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
                         return $this->redirect(CountryPrices_ChangeCountryController::new_country_link($distributorPrimaryCountryCode));
70 70
                     }
71 71
                 } else {
72
-                    die("ERROR: No primary country has been set for this ".  _t('Distributor.SINGULAR_NAME', 'Distributor') .".");
72
+                    die("ERROR: No primary country has been set for this "._t('Distributor.SINGULAR_NAME', 'Distributor').".");
73 73
                 }
74 74
             }
75 75
             if ($countries && $countries->count()) {
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             }
78 78
         }
79 79
         if (!$canViewAndEdit) {
80
-            Security::permissionFailure($this, 'Please log in first or log in as a '. _t('Distributor.SINGULAR_NAME', 'Distributor'). '.');
80
+            Security::permissionFailure($this, 'Please log in first or log in as a '._t('Distributor.SINGULAR_NAME', 'Distributor').'.');
81 81
         }
82 82
     }
83 83
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         $fields['Price'] = 'Price';
107 107
 
108 108
         foreach ($fields as $field) {
109
-            if (! isset($_REQUEST[$field])) {
109
+            if (!isset($_REQUEST[$field])) {
110 110
                 return "$field value missing";
111 111
             }
112 112
         }
@@ -121,13 +121,13 @@  discard block
 block discarded – undo
121 121
                 $valid = true;
122 122
             }
123 123
         }
124
-        if (! $valid) {
124
+        if (!$valid) {
125 125
             return 'ObjectClass value incorrect';
126 126
         }
127 127
 
128 128
         $objectID = intval($_REQUEST['ObjectID']);
129 129
         $object = $objectClass::get()->byID($objectID);
130
-        if (! $object) {
130
+        if (!$object) {
131 131
             return 'ObjectID value incorrect';
132 132
         }
133 133
 
@@ -143,12 +143,12 @@  discard block
 block discarded – undo
143 143
             $valid = true;
144 144
             if ($this->distributor) {
145 145
                 $countries = $this->distributor->Countries()->map('Code', 'Code')->toArray();
146
-                if (! in_array($countryCode, $countries)) {
146
+                if (!in_array($countryCode, $countries)) {
147 147
                     $valid = false;
148 148
                 }
149 149
             }
150 150
         }
151
-        if (! $valid) {
151
+        if (!$valid) {
152 152
             return 'Country value incorrect';
153 153
         }
154 154
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         }
159 159
 
160 160
         $price = $_REQUEST['Price'];
161
-        if (! is_numeric($price)) {
161
+        if (!is_numeric($price)) {
162 162
             return 'Price value incorrect';
163 163
         }
164 164
 
@@ -179,13 +179,13 @@  discard block
 block discarded – undo
179 179
      */
180 180
     public function setobjectfield()
181 181
     {
182
-        if (isset($_REQUEST["F"]) && $_REQUEST["F"]== "TESTONLY") {
182
+        if (isset($_REQUEST["F"]) && $_REQUEST["F"] == "TESTONLY") {
183 183
             return "THIS IS FOR TESTING ONLY";
184 184
         }
185 185
         // 1) Check that all parameters have been specified
186 186
 
187 187
         foreach (array('T', 'I', 'F', 'V') as $field) {
188
-            if (! isset($_REQUEST[$field])) {
188
+            if (!isset($_REQUEST[$field])) {
189 189
                 return "$field value missing";
190 190
             }
191 191
         }
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
         $result = 1; // Updated
196 196
 
197 197
         $objectClass = $_REQUEST['T'];
198
-        if (! class_exists($objectClass)) {
198
+        if (!class_exists($objectClass)) {
199 199
             return 'ObjectClass value incorrect';
200 200
         }
201 201
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
         } elseif (intval($objectID)) {
208 208
             $objectID = intval($objectID);
209 209
             $object = $objectClass::get()->byID($objectID);
210
-            if (! $object) {
210
+            if (!$object) {
211 211
                 return 'ObjectID (ID: $objectID, Class Name: $objectClass) value incorrect';
212 212
             }
213 213
         } else {
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
         $fieldName = Convert::raw2sql($_REQUEST['F']);
222 222
         $value = $_REQUEST['V'];
223 223
 
224
-        if ($fieldName == 'Price' && (! is_numeric($value) || $value < 0)) {
224
+        if ($fieldName == 'Price' && (!is_numeric($value) || $value < 0)) {
225 225
             return 'Price value incorrect';
226 226
         }
227 227
         if ($value == '0') {
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
                 }
334 334
                 if (Permission::check("ADMIN")) {
335 335
                     $html .= $this->createEditNode(
336
-                        "Default " . _t('Distributor.SINGULAR_NAME', 'Distributor'),
336
+                        "Default "._t('Distributor.SINGULAR_NAME', 'Distributor'),
337 337
                         $distributor->IsDefault ? "YES" : "NO"
338 338
                     );
339 339
                 }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
                 $countryList = array();
343 343
                 $countries = $distributor->Countries();
344 344
                 foreach ($countries as $country) {
345
-                    $countryList[] = $country->Name . ($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
345
+                    $countryList[] = $country->Name.($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
346 346
                 }
347 347
                 $html .= $this->createEditNode(
348 348
                     'Countries',
@@ -424,14 +424,14 @@  discard block
 block discarded – undo
424 424
                 $data = array('T' => 'EcommerceCountry', 'I' => $country->ID);
425 425
                 $distributorName = $country->Distributor()->Name;
426 426
                 if (!$distributorName) {
427
-                    $distributorName = "<p class=\"message bad\">No ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." has been assigned to this country.</p>";
427
+                    $distributorName = "<p class=\"message bad\">No "._t('Distributor.SINGULAR_NAME', 'Distributor')." has been assigned to this country.</p>";
428 428
                 }
429 429
                 $html .= $this->createTreeNode($country->Code." - ".$country->Name, $country->Code, array($country));
430 430
                 $distributorTitlePlural = _t('Distributor.PLURAL_NAME', 'Distributor');
431 431
                 $distributorTitleSingluar = _t('Distributor.SINGULAR_NAME', 'Distributor');
432 432
                 $html .= $this->createEditNode($distributorTitleSingluar, $distributorName);
433 433
                 $html .= $this->createEditNode("FAQ Content", "", $country->FAQContent, $data + array("F" => "FAQContent"), "textarea");
434
-                $html .= $this->createEditNode("Top Bar Message", "",  $country->TopBarMessage, $data + array("F" => "TopBarMessage"), "");
434
+                $html .= $this->createEditNode("Top Bar Message", "", $country->TopBarMessage, $data + array("F" => "TopBarMessage"), "");
435 435
                 $html .= $this->createEditNode("Country Specific Messages", $countrySpecificMessages);
436 436
                 $html .= $this->createEditNode("Delivery Options", $deliveryOptions);
437 437
                 $html .= $this->createEditNode("Taxes", $taxes);
@@ -441,15 +441,15 @@  discard block
 block discarded – undo
441 441
                 $html .= $this->closeTreeNode();
442 442
             }
443 443
         }
444
-        $countries =  EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 0));
444
+        $countries = EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 0));
445 445
         if ($countries && $countries->count()) {
446 446
             $list = implode(", ", $countries->map("ID", "Code")->toArray());
447
-            $html .= $this->createEditNode("Countries without a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." that allow sales", $list);
447
+            $html .= $this->createEditNode("Countries without a "._t('Distributor.SINGULAR_NAME', 'Distributor')." that allow sales", $list);
448 448
         }
449
-        $countries =  EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 1));
449
+        $countries = EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 1));
450 450
         if ($countries && $countries->count()) {
451 451
             $list = implode(", ", $countries->map("ID", "Code")->toArray());
452
-            $html .= $this->createEditNode("Countries without a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." that do not allow sales", $list);
452
+            $html .= $this->createEditNode("Countries without a "._t('Distributor.SINGULAR_NAME', 'Distributor')." that do not allow sales", $list);
453 453
         }
454 454
         return $html;
455 455
     }
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
         $defaultPriceText = ' (N.B. This is default for new variations ONLY - set actual prices under variations)';
471 471
         if ($products && $products->count()) {
472 472
             foreach ($products as $product) {
473
-                $withDefaultPrices = Permission::check('ADMIN') || (! $product->hasVariations());
473
+                $withDefaultPrices = Permission::check('ADMIN') || (!$product->hasVariations());
474 474
                 $html .= $this->createTreeNode($product->FullName, "pricing", array($product));
475 475
 
476 476
                 //country exceptions
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
                     //only show default price for ShopAdmin
493 493
                     if ($withDefaultPrices) {
494 494
                         $html .= $this->createEditNode(
495
-                            'Default Price' . ($product->hasVariations() ? $defaultPriceText : ''),
495
+                            'Default Price'.($product->hasVariations() ? $defaultPriceText : ''),
496 496
                             EcommercePayment::site_currency(),
497 497
                             $product->Price,
498 498
                             array(
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
                 $outstandingCountries = $this->countryArray;
509 509
                 if ($withDefaultPrices) {
510 510
                     $html .= $this->createTreeNode(
511
-                        'Country Prices' . ($product->hasVariations() ? $defaultPriceText : ''),
511
+                        'Country Prices'.($product->hasVariations() ? $defaultPriceText : ''),
512 512
                         " pricing countryPrices"
513 513
                     );
514 514
                 }
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
                             $countryName = EcommerceCountry::find_title($countryPricesObject->Country);
533 533
                             if ($withDefaultPrices) {
534 534
                                 $html .= $this->createEditNode(
535
-                                    $countryPricesObject->Country . ' - '. $countryName,
535
+                                    $countryPricesObject->Country.' - '.$countryName,
536 536
                                     $countryPricesObject->Currency,
537 537
                                     $countryPricesObject->Price,
538 538
                                     $data,
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
                         $countryName = EcommerceCountry::find_title($countryCode);
567 567
                         if ($withDefaultPrices) {
568 568
                             $html .= $this->createEditNode(
569
-                                $countryCode . ' - '. $countryName,
569
+                                $countryCode.' - '.$countryName,
570 570
                                 $currencyObject->Code,
571 571
                                 $addText,
572 572
                                 $data,
@@ -619,8 +619,8 @@  discard block
 block discarded – undo
619 619
                                                 "F" => "Price"
620 620
                                             );
621 621
                                             $countryName = EcommerceCountry::find_title($countryPricesObject->Country);
622
-                                            $html .=  $this->createEditNode(
623
-                                                $countryPricesObject->Country . ' - '. $countryName,
622
+                                            $html .= $this->createEditNode(
623
+                                                $countryPricesObject->Country.' - '.$countryName,
624 624
                                                 $countryPricesObject->Currency,
625 625
                                                 $countryPricesObject->Price,
626 626
                                                 $data,
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
                                         );
667 667
                                         $countryName = EcommerceCountry::find_title($countryCode);
668 668
                                         $html .= $this->createEditNode(
669
-                                            $countryCode . ' - '. $countryName,
669
+                                            $countryCode.' - '.$countryName,
670 670
                                             $currency->Code,
671 671
                                             $addText,
672 672
                                             $data,
Please login to merge, or discard this patch.