Completed
Push — master ( f456f1...747acb )
by Nicolaas
05:26 queued 01:59
created
code/api/ShoppingCart.php 1 patch
Doc Comments   +18 added lines, -17 removed lines patch added patch discarded remove patch
@@ -350,8 +350,8 @@  discard block
 block discarded – undo
350 350
      * Adds any number of items to the cart.
351 351
      * Returns the order item on succes OR false on failure.
352 352
      *
353
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
354
-     * @param float      $quantity   - number of items add.
353
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
354
+     * @param integer      $quantity   - number of items add.
355 355
      * @param mixed      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
356 356
      *                                 if you make it a form, it will save the form into the orderitem
357 357
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
      *
399 399
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
400 400
      *
401
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
401
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
402 402
      * @param float      $quantity   - number of items add.
403 403
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
404 404
      *
@@ -428,8 +428,8 @@  discard block
 block discarded – undo
428 428
      *
429 429
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
430 430
      *
431
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
432
-     * @param float      $quantity   - number of items add.
431
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
432
+     * @param integer      $quantity   - number of items add.
433 433
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
434 434
      *
435 435
      * @return false | OrderItem | null
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
      *
468 468
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
469 469
      *
470
-     * @param OrderItem $buyable    - the buyable (generally a product) being added to the cart
470
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
471 471
      * @param array     $parameters - array of parameters to target a specific order item. eg: group=1, length=5
472 472
      *
473 473
      * @return bool | item | null - successfully removed
@@ -494,9 +494,8 @@  discard block
 block discarded – undo
494 494
     /**
495 495
      * Checks and prepares variables for a quantity change (add, edit, remove) for an Order Item.
496 496
      *
497
-     * @param DataObject    $buyable             - the buyable (generally a product) being added to the cart
498
-     * @param float         $quantity            - number of items add.
499
-     * @param bool          $mustBeExistingItems - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
497
+     * @param BuyableModel    $buyable             - the buyable (generally a product) being added to the cart
498
+     * @param bool          $mustBeExistingItem - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
500 499
      * @param array | Form  $parameters          - array of parameters to target a specific order item. eg: group=1, length=5*
501 500
      *                                           - form saved into item...
502 501
      *
@@ -564,7 +563,7 @@  discard block
 block discarded – undo
564 563
      * we do not need things like "canPurchase" here, because that is with the "addBuyable" method.
565 564
      * NOTE: does not write!
566 565
      *
567
-     * @param DataObject $buyable
566
+     * @param BuyableModel $buyable
568 567
      * @param array      $parameters
569 568
      *
570 569
      * @return OrderItem
@@ -626,7 +625,7 @@  discard block
 block discarded – undo
626 625
     /**
627 626
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
628 627
      *
629
-     * @return bool | null
628
+     * @return boolean|null | null
630 629
      */
631 630
     public function save()
632 631
     {
@@ -690,7 +689,7 @@  discard block
 block discarded – undo
690 689
      *
691 690
      * @param OrderModifier $modifier
692 691
      *
693
-     * @return bool | null
692
+     * @return boolean|null | null
694 693
      */
695 694
     public function removeModifier(OrderModifier $modifier)
696 695
     {
@@ -722,8 +721,9 @@  discard block
 block discarded – undo
722 721
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
723 722
      *
724 723
      * @param Int/ OrderModifier
724
+     * @param integer $modifier
725 725
      *
726
-     * @return bool
726
+     * @return boolean|null
727 727
      */
728 728
     public function addModifier($modifier)
729 729
     {
@@ -857,7 +857,7 @@  discard block
 block discarded – undo
857 857
      *
858 858
      * @param string - $countryCode
859 859
      *
860
-     * @return bool
860
+     * @return boolean|null
861 861
      **/
862 862
     public function setCountry($countryCode)
863 863
     {
@@ -879,6 +879,7 @@  discard block
 block discarded – undo
879 879
      * sets region in order so that modifiers can be recalculated, etc...
880 880
      *
881 881
      * @param int | String - $regionID you can use the ID or the code.
882
+     * @param integer $regionID
882 883
      *
883 884
      * @return bool
884 885
      **/
@@ -1021,7 +1022,7 @@  discard block
 block discarded – undo
1021 1022
     /**
1022 1023
      * Stores a message that can later be returned via ajax or to $form->sessionMessage();.
1023 1024
      *
1024
-     * @param $message - the message, which could be a notification of successful action, or reason for failure
1025
+     * @param string $message - the message, which could be a notification of successful action, or reason for failure
1025 1026
      * @param $type - please use good, bad, warning
1026 1027
      */
1027 1028
     public function addMessage($message, $status = 'good')
@@ -1047,7 +1048,7 @@  discard block
 block discarded – undo
1047 1048
     /**
1048 1049
      * Gets an existing order item based on buyable and passed parameters.
1049 1050
      *
1050
-     * @param DataObject $buyable
1051
+     * @param BuyableModel $buyable
1051 1052
      * @param array      $parameters
1052 1053
      *
1053 1054
      * @return OrderItem | null
@@ -1073,7 +1074,7 @@  discard block
 block discarded – undo
1073 1074
     /**
1074 1075
      * Removes parameters that aren't in the default array, merges with default parameters, and converts raw2SQL.
1075 1076
      *
1076
-     * @param array $parameters
1077
+     * @param array $params
1077 1078
      *
1078 1079
      * @return cleaned array
1079 1080
      */
Please login to merge, or discard this patch.