ProductsAndGroupsModelAdmin::getEditForm() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a48538...a41cf8 )

by Nicolaas

created 2017-01-16 03:52 UTC

ProductsAndGroupsModelAdmin::getEditForm() B

↳ Parent: ProductsAndGroupsModelAdmin

Complexity

Conditions	5
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	7
nc	4
nop	2
dl	0
loc	13
rs	8.8571
c	0
b	0
f	0

<?php


/**
 * @description: for the management of Product and Product Groups only
 *
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: cms
 **/
class ProductsAndGroupsModelAdmin extends ModelAdminEcommerceBaseClass
namespace YourVendor;

class YourClass { }
{
    private static $menu_priority = 3.2;


    private static $url_segment = 'products';


    private static $menu_title = 'Products';


    private static $allowed_actions = array(

        'editinsitetree',
        'ItemEditForm',
    );

    /**
     * standard SS variable.
     *
     * @var string
     */
    private static $menu_icon = 'ecommerce/images/icons/product-file.gif';



    public function getEditForm($id = null, $fields = null)

    {
        $form = parent::getEditForm();
        if (is_subclass_of($this->modelClass, 'SiteTree') || $this->modelClass === 'SiteTree') {
            if ($gridField = $form->Fields()->dataFieldByName($this->sanitiseClassName($this->modelClass))) {
                if ($gridField instanceof GridField) {
                    $gridField->setConfig(GridFieldEditOriginalPageConfig::create());
                }
            }
        }

        return $form;
    }
}


1			<?php
2
3
4			/**
5			* @description: for the management of Product and Product Groups only
6			*
7			*
8			* @authors: Nicolaas [at] Sunny Side Up .co.nz
9			* @package: ecommerce
10			* @sub-package: cms
11			**/
12			class ProductsAndGroupsModelAdmin extends ModelAdminEcommerceBaseClass
			0 ignored issues – show Coding Style Compatibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
13			{
14			private static $menu_priority = 3.2;
			0 ignored issues – show Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$menu_priority` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
15
16			private static $url_segment = 'products';
			0 ignored issues – show Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$url_segment` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
17
18			private static $menu_title = 'Products';
			0 ignored issues – show Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$menu_title` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
19
20			private static $allowed_actions = array(
			0 ignored issues – show Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
21			'editinsitetree',
22			'ItemEditForm',
23			);
24
25			/**
26			* standard SS variable.
27			*
28			* @var string
29			*/
30			private static $menu_icon = 'ecommerce/images/icons/product-file.gif';
			0 ignored issues – show Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$menu_icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
31
32
33			public function getEditForm($id = null, $fields = null)
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
34			{
35			$form = parent::getEditForm();
36			if (is_subclass_of($this->modelClass, 'SiteTree') \|\| $this->modelClass === 'SiteTree') {
37			if ($gridField = $form->Fields()->dataFieldByName($this->sanitiseClassName($this->modelClass))) {
38			if ($gridField instanceof GridField) {
39			$gridField->setConfig(GridFieldEditOriginalPageConfig::create());
40			}
41			}
42			}
43
44			return $form;
45			}
46			}
47

sunnysideup / silverstripe-ecommerce

Push — master ( a48538...a41cf8 )

ProductsAndGroupsModelAdmin::getEditForm() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like