ProductsAndGroupsModelAdmin

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getEditForm()	0	13	5

<?php


/**
 * @description: for the management of Product and Product Groups only
 *
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: cms
 **/
class ProductsAndGroupsModelAdmin extends ModelAdminEcommerceBaseClass

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $menu_priority = 3.2;

The property $menu_priority is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $url_segment = 'products';

The property $url_segment is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $menu_title = 'Products';

The property $menu_title is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'editinsitetree',
        'ItemEditForm',
    );

    /**
     * standard SS variable.
     *
     * @var string
     */
    private static $menu_icon = 'ecommerce/images/icons/product-file.gif';

The property $menu_icon is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    public function getEditForm($id = null, $fields = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $form = parent::getEditForm();
        if (is_subclass_of($this->modelClass, 'SiteTree') || $this->modelClass === 'SiteTree') {
            if ($gridField = $form->Fields()->dataFieldByName($this->sanitiseClassName($this->modelClass))) {
                if ($gridField instanceof GridField) {
                    $gridField->setConfig(GridFieldEditOriginalPageConfig::create());
                }
            }
        }

        return $form;
    }
}