sunnysideup / silverstripe-columns

code/control/SilverstripeColumnsPageControllerExtension.php

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 *
 **/

class SilverstripeColumnsPageControllerExtension extends Extension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'myspecificpagemenuitems' => true
    ];

    /**
     * @return bool
     */
    public function HasFullWidthContent()

This method seems to be duplicated in your project.

    {
        if ($this->owner->hasMethod('HasFullWidthContentOverloaded')) {
            $v = $this->owner->HasFullWidthContentOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        if ($this->owner->owner->getFullWidthContent()) {
            return true;
        }
    }

    /**
     * @return bool
     */
    public function HasSideBar()
    {
        if ($this->owner->hasMethod('HasSideBarOverloaded')) {
            $v = $this->owner->HasSideBarOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        if (
            (
                $this->owner->UseDefaultSideBarContent() &&
                strlen($this->owner->getMyDefaultSidebarContent()) > 17
            )
            ||
            $this->owner->MySidebarImage()
        ) {
            return true;
        }
    }

    /**
     * @param boolean $asClassName
     *
     * @return string | int
     */
    public function NumberOfColumns($asClassName = true)
    {
        if ($this->owner->hasMethod('NumberOfColumnsOverloaded')) {
            return $this->owner->NumberOfColumnsOverloaded();
            if ($v !== null) {

if ($v !== null) { return $v; } does not seem to be reachable.

                return $v;
            }
        }
        $count = 1;
        if ($this->owner->HasSideBar()) {
            $count++;
        }
        if ($asClassName) {
            $array = array(
                1 => 'one',
                2 => 'two',
                3 => 'three'
            );
            return $array[$count];
        } else {
            return $count;
        }
    }


    /**
     * returns a data list of items that have been edited last - up to one day ago.
     * This ensures that we do not show stuff we have just fixed up...
     * @return DataList
     */
    public function RecentlyUpdated($limit = 5)
    {
        if ($this->owner->hasMethod('RecentlyUpdatedOverloaded')) {
            $v = $this->owner->RecentlyUpdatedOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        return Page::get()
            ->filter(
                array(
                    'ShowInSearch' => true,
                    'LastEdited:LessThan' => date('Y-m-d h:i:s', time() - 86400)
                )
            )
            ->sort(array('LastEdited' => 'DESC'))
            ->limit($limit);
    }

    /**
     *  Children Menu Items
     * @return null | DataList
     */
    public function InThisSection()

This method seems to be duplicated in your project.

    {
        if ($this->owner->hasMethod('InThisSectionOverloaded')) {
            $v = $this->owner->InThisSectionOverloaded();
            if ($v !== null) {
                return $v;
            }
        }

        return $this->owner->ChildrenShowInMenu();
    }

    /**
     * Sibling Menu Items
     * @return null | DataList
     */
    public function AlsoSee()
    {
        if ($this->owner->hasMethod('AlsoSeeOverloaded')) {
            $v = $this->owner->AlsoSeeOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        if ($this->owner->ParentID) {
            $list = Page::get()->filter(['ShowInMenus' => 1, 'ParentID' => $this->owner->dataRecord->ParentID]);
            $list = $list->exclude(['ID' => $this->owner->ID]);

            return $list;
        }
    }

    /**
     * returns relevant menus items for
     * @param  SS_Request
     * @return string (html)
     */
    public function myspecificpagemenuitems($request)

The parameter $request is not used and could be removed.

    {
        if ($this->owner->hasMethod('MySpecificPageMenuItemsOverloaded')) {
            $v = $this->owner->MySpecificPageMenuItemsOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        $id = intval($this->owner->request->param('ID'));
        $this->owner->setShowMenuItemsFor($id);
        return ArrayData::create(
            [
                'MyMenuItems' => $this->owner->MyMenuItems(),
                'MyMenuItemsParentPage' => $this->owner->MyMenuItemsParentPage(),
                'MyMenuItemsParentLink' => $this->owner->MyMenuItemsParentLink()
            ]
        )
        ->renderWith('MyMenuItems');
    }


    public function IsNotHome()
    {
        $link = $this->owner->Link();

        return  $link === 'home' || $link = '/';
    }
}