SilverstripeColumnsPageControllerExtension::HasFullWidthContent() - Code Metrics - sunnysideup/silverstripe-columns - Measure and Improve Code Quality continuously with Scrutinizer

HasFullWidthContent() A
last analyzed 2018-03-20 00:57 UTC

↳ Parent: SilverstripeColumnsPageControllerExtension

Complexity

Conditions	4
Paths	5

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes

Metric	Value
dl	12
loc	12
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	5
nop	0

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 *
 **/

class SilverstripeColumnsPageControllerExtension extends Extension
namespace YourVendor;

class YourClass { }
{
    private static $allowed_actions = [

        'myspecificpagemenuitems' => true
    ];

    /**
     * @return bool
     */
    public function HasFullWidthContent()

    {
        if ($this->owner->hasMethod('HasFullWidthContentOverloaded')) {
            $v = $this->owner->HasFullWidthContentOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        if ($this->owner->owner->getFullWidthContent()) {
            return true;
        }
    }

    /**
     * @return bool
     */
    public function HasSideBar()
    {
        if ($this->owner->hasMethod('HasSideBarOverloaded')) {
            $v = $this->owner->HasSideBarOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        if (
            (
                $this->owner->UseDefaultSideBarContent() &&
                strlen($this->owner->getMyDefaultSidebarContent()) > 17
            )
            ||
            $this->owner->MySidebarImage()
        ) {
            return true;
        }
    }

    /**
     * @param boolean $asClassName
     *
     * @return string | int
     */
    public function NumberOfColumns($asClassName = true)
    {
        if ($this->owner->hasMethod('NumberOfColumnsOverloaded')) {
            return $this->owner->NumberOfColumnsOverloaded();
            if ($v !== null) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                return $v;
            }
        }
        $count = 1;
        if ($this->owner->HasSideBar()) {
            $count++;
        }
        if ($asClassName) {
            $array = array(
                1 => 'one',
                2 => 'two',
                3 => 'three'
            );
            return $array[$count];
        } else {
            return $count;
        }
    }


    /**
     * returns a data list of items that have been edited last - up to one day ago.
     * This ensures that we do not show stuff we have just fixed up...
     * @return DataList
     */
    public function RecentlyUpdated($limit = 5)
    {
        if ($this->owner->hasMethod('RecentlyUpdatedOverloaded')) {
            $v = $this->owner->RecentlyUpdatedOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        return Page::get()
            ->filter(
                array(
                    'ShowInSearch' => true,
                    'LastEdited:LessThan' => date('Y-m-d h:i:s', time() - 86400)
                )
            )
            ->sort(array('LastEdited' => 'DESC'))
            ->limit($limit);
    }

    /**
     *  Children Menu Items
     * @return null | DataList
     */
    public function InThisSection()

    {
        if ($this->owner->hasMethod('InThisSectionOverloaded')) {
            $v = $this->owner->InThisSectionOverloaded();
            if ($v !== null) {
                return $v;
            }
        }

        return $this->owner->ChildrenShowInMenu();
    }

    /**
     * Sibling Menu Items
     * @return null | DataList
     */
    public function AlsoSee()
    {
        if ($this->owner->hasMethod('AlsoSeeOverloaded')) {
            $v = $this->owner->AlsoSeeOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        if ($this->owner->ParentID) {
            $list = Page::get()->filter(['ShowInMenus' => 1, 'ParentID' => $this->owner->dataRecord->ParentID]);
            $list = $list->exclude(['ID' => $this->owner->ID]);

            return $list;
        }
    }

    /**
     * returns relevant menus items for
     * @param  SS_Request
     * @return string (html)
     */
    public function myspecificpagemenuitems($request)

    {
        if ($this->owner->hasMethod('MySpecificPageMenuItemsOverloaded')) {
            $v = $this->owner->MySpecificPageMenuItemsOverloaded();
            if ($v !== null) {
                return $v;
            }
        }
        $id = intval($this->owner->request->param('ID'));
        $this->owner->setShowMenuItemsFor($id);
        return ArrayData::create(
            [
                'MyMenuItems' => $this->owner->MyMenuItems(),
                'MyMenuItemsParentPage' => $this->owner->MyMenuItemsParentPage(),
                'MyMenuItemsParentLink' => $this->owner->MyMenuItemsParentLink()
            ]
        )
        ->renderWith('MyMenuItems');
    }


    public function IsNotHome()
    {
        $link = $this->owner->Link();

        return  $link === 'home' || $link = '/';
    }
}


1		<?php
2
3		/**
4		*@author nicolaas [at] sunnysideup.co.nz
5		*
6		*
7		**/
8
9		class SilverstripeColumnsPageControllerExtension extends Extension
		0 ignored issues – show Coding Style Compatibility introduced 2017-08-30 04:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10		{
11		private static $allowed_actions = [
		0 ignored issues – show Comprehensibility introduced 2017-09-11 01:38 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-09-11 01:38 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12		'myspecificpagemenuitems' => true
13		];
14
15		/**
16		* @return bool
17		*/
18	View Code Duplication	public function HasFullWidthContent()
		0 ignored issues – show Duplication introduced 2017-08-30 04:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		if ($this->owner->hasMethod('HasFullWidthContentOverloaded')) {
21		$v = $this->owner->HasFullWidthContentOverloaded();
22		if ($v !== null) {
23		return $v;
24		}
25		}
26		if ($this->owner->owner->getFullWidthContent()) {
27		return true;
28		}
29		}
30
31		/**
32		* @return bool
33		*/
34		public function HasSideBar()
35		{
36		if ($this->owner->hasMethod('HasSideBarOverloaded')) {
37		$v = $this->owner->HasSideBarOverloaded();
38		if ($v !== null) {
39		return $v;
40		}
41		}
42		if (
43		(
44		$this->owner->UseDefaultSideBarContent() &&
45		strlen($this->owner->getMyDefaultSidebarContent()) > 17
46		)
47		\|\|
48		$this->owner->MySidebarImage()
49		) {
50		return true;
51		}
52		}
53
54		/**
55		* @param boolean $asClassName
56		*
57		* @return string \| int
58		*/
59		public function NumberOfColumns($asClassName = true)
60		{
61		if ($this->owner->hasMethod('NumberOfColumnsOverloaded')) {
62		return $this->owner->NumberOfColumnsOverloaded();
63		if ($v !== null) {
		0 ignored issues – show Unused Code introduced 2017-08-30 04:19 UTC by Report Bug Copy Issue Report `if ($v !== null) { return $v; }` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
64		return $v;
65		}
66		}
67		$count = 1;
68		if ($this->owner->HasSideBar()) {
69		$count++;
70		}
71		if ($asClassName) {
72		$array = array(
73		1 => 'one',
74		2 => 'two',
75		3 => 'three'
76		);
77		return $array[$count];
78		} else {
79		return $count;
80		}
81		}
82
83
84		/**
85		* returns a data list of items that have been edited last - up to one day ago.
86		* This ensures that we do not show stuff we have just fixed up...
87		* @return DataList
88		*/
89		public function RecentlyUpdated($limit = 5)
90		{
91		if ($this->owner->hasMethod('RecentlyUpdatedOverloaded')) {
92		$v = $this->owner->RecentlyUpdatedOverloaded();
93		if ($v !== null) {
94		return $v;
95		}
96		}
97		return Page::get()
98		->filter(
99		array(
100		'ShowInSearch' => true,
101		'LastEdited:LessThan' => date('Y-m-d h:i:s', time() - 86400)
102		)
103		)
104		->sort(array('LastEdited' => 'DESC'))
105		->limit($limit);
106		}
107
108		/**
109		* Children Menu Items
110		* @return null \| DataList
111		*/
112	View Code Duplication	public function InThisSection()
		0 ignored issues – show Duplication introduced 2017-09-11 01:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		{
114		if ($this->owner->hasMethod('InThisSectionOverloaded')) {
115		$v = $this->owner->InThisSectionOverloaded();
116		if ($v !== null) {
117		return $v;
118		}
119		}
120
121		return $this->owner->ChildrenShowInMenu();
122		}
123
124		/**
125		* Sibling Menu Items
126		* @return null \| DataList
127		*/
128		public function AlsoSee()
129		{
130		if ($this->owner->hasMethod('AlsoSeeOverloaded')) {
131		$v = $this->owner->AlsoSeeOverloaded();
132		if ($v !== null) {
133		return $v;
134		}
135		}
136		if ($this->owner->ParentID) {
137		$list = Page::get()->filter(['ShowInMenus' => 1, 'ParentID' => $this->owner->dataRecord->ParentID]);
138		$list = $list->exclude(['ID' => $this->owner->ID]);
139
140		return $list;
141		}
142		}
143
144		/**
145		* returns relevant menus items for
146		* @param SS_Request
147		* @return string (html)
148		*/
149		public function myspecificpagemenuitems($request)
		0 ignored issues – show Unused Code introduced 2017-09-28 07:27 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
150		{
151		if ($this->owner->hasMethod('MySpecificPageMenuItemsOverloaded')) {
152		$v = $this->owner->MySpecificPageMenuItemsOverloaded();
153		if ($v !== null) {
154		return $v;
155		}
156		}
157		$id = intval($this->owner->request->param('ID'));
158		$this->owner->setShowMenuItemsFor($id);
159		return ArrayData::create(
160		[
161		'MyMenuItems' => $this->owner->MyMenuItems(),
162		'MyMenuItemsParentPage' => $this->owner->MyMenuItemsParentPage(),
163		'MyMenuItemsParentLink' => $this->owner->MyMenuItemsParentLink()
164		]
165		)
166		->renderWith('MyMenuItems');
167		}
168
169
170		public function IsNotHome()
171		{
172		$link = $this->owner->Link();
173
174		return $link === 'home' \|\| $link = '/';
175		}
176		}
177

sunnysideup / silverstripe-columns

HasFullWidthContent() A last analyzed 2018-03-20 00:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

HasFullWidthContent() A
last analyzed 2018-03-20 00:57 UTC