CampaignMonitorAddOldCampaigns::run() - Code Metrics - sunnysideup/silverstripe-campaignmonitor - Measure and Improve Code Quality continuously with Scrutinizer

CampaignMonitorAddOldCampaigns::run() C
last analyzed 2018-06-20 01:09 UTC

↳ Parent: CampaignMonitorAddOldCampaigns

Complexity

Conditions	11
Paths	12

Size

Total Lines	47
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	47
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	34
nc	12
nop	1

How to fix Complexity

	<?php




class CampaignMonitorAddOldCampaigns extends BuildTask
namespace YourVendor;

class YourClass { }
{
    protected $title = "Retrieves a list of campaigns from Campaign Monitor.";

    protected $description = "Retrieves a list of campaigns from Campaign Monitor for future display.";

    protected $verbose = true;

    public function setVerbose($b)
    {
        $this->verbose = $b;
    }

    /**
     * @param SS_HTTP_Request
     * standard method
     */
    public function run($request)
    {
        $faultyOnes = CampaignMonitorCampaign::get()->where("(\"CampaignID\" = '' OR \"CampaignID\" IS NULL) AND (\"WebVersionURL\" IS NOT NULL && \"WebVersionURL\" <> '')");
        foreach ($faultyOnes as $faultyOne) {
            $faultyOne->delete();
        }
        $api = CampaignMonitorAPIConnector::create();
        $api->init();
        $campaigns = $api->getCampaigns();
        if (is_array($campaigns)) {
            foreach ($campaigns as $campaign) {
                if ($campaign->SentDate) {
                    $campaignMonitorCampaign = CampaignMonitorCampaign::get()->filter(array("CampaignID" => $campaign->CampaignID))->first();
                    if (!$campaignMonitorCampaign) {
                        if ($this->verbose) {
                            DB::alteration_message("Adding ".$campaign->Subject." sent ".$campaign->SentDate, "created");
                        }
                        $campaignMonitorCampaign = CampaignMonitorCampaign::create();
                    } else {
                        if ($this->verbose) {
                            DB::alteration_message("already added ".$campaign->Subject, "edited");
                        }
                    }
                    $campaignMonitorCampaign->HasBeenSent = true;
                    $campaignMonitorCampaign->CampaignID = $campaign->CampaignID;
                    $campaignMonitorCampaign->Subject = $campaign->Subject;
                    $campaignMonitorCampaign->Name = $campaign->Name;
                    $campaignMonitorCampaign->SentDate = $campaign->SentDate;
                    $campaignMonitorCampaign->WebVersionURL = $campaign->WebVersionURL;
                    $campaignMonitorCampaign->WebVersionTextURL = $campaign->WebVersionTextURL;
                    //$CampaignMonitorCampaign->ParentID = $this->ID;

                    $campaignMonitorCampaign->write();
                } else {
                    if ($this->verbose) {
                        DB::alteration_message("not adding ".$campaign->Subject." because it has not been sent yet...", "edited");
                    }
                }
            }
        } else {
            if ($this->verbose) {
                DB::alteration_message("there are no campaigns to be added", "edited");
            }
        }
        if ($this->verbose) {
            DB::alteration_message("<hr /><hr /><hr />Completed", "edited");
        }
    }
}


1			<?php
			0 ignored issues – show Security Bug introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report It is not recommended to output anything before PHP's opening tag in non-template files. Loading history... Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 5 and the first side effect is on line 1. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3
4
5			class CampaignMonitorAddOldCampaigns extends BuildTask
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7			protected $title = "Retrieves a list of campaigns from Campaign Monitor.";
8
9			protected $description = "Retrieves a list of campaigns from Campaign Monitor for future display.";
10
11			protected $verbose = true;
12
13			public function setVerbose($b)
14			{
15			$this->verbose = $b;
16			}
17
18			/**
19			* @param SS_HTTP_Request
20			* standard method
21			*/
22			public function run($request)
23			{
24			$faultyOnes = CampaignMonitorCampaign::get()->where("(\"CampaignID\" = '' OR \"CampaignID\" IS NULL) AND (\"WebVersionURL\" IS NOT NULL && \"WebVersionURL\" <> '')");
25			foreach ($faultyOnes as $faultyOne) {
26			$faultyOne->delete();
27			}
28			$api = CampaignMonitorAPIConnector::create();
29			$api->init();
30			$campaigns = $api->getCampaigns();
31			if (is_array($campaigns)) {
32			foreach ($campaigns as $campaign) {
33			if ($campaign->SentDate) {
34			$campaignMonitorCampaign = CampaignMonitorCampaign::get()->filter(array("CampaignID" => $campaign->CampaignID))->first();
35			if (!$campaignMonitorCampaign) {
36			if ($this->verbose) {
37			DB::alteration_message("Adding ".$campaign->Subject." sent ".$campaign->SentDate, "created");
38			}
39			$campaignMonitorCampaign = CampaignMonitorCampaign::create();
40			} else {
41			if ($this->verbose) {
42			DB::alteration_message("already added ".$campaign->Subject, "edited");
43			}
44			}
45			$campaignMonitorCampaign->HasBeenSent = true;
46			$campaignMonitorCampaign->CampaignID = $campaign->CampaignID;
47			$campaignMonitorCampaign->Subject = $campaign->Subject;
48			$campaignMonitorCampaign->Name = $campaign->Name;
49			$campaignMonitorCampaign->SentDate = $campaign->SentDate;
50			$campaignMonitorCampaign->WebVersionURL = $campaign->WebVersionURL;
51			$campaignMonitorCampaign->WebVersionTextURL = $campaign->WebVersionTextURL;
52			//$CampaignMonitorCampaign->ParentID = $this->ID;
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53			$campaignMonitorCampaign->write();
54			} else {
55			if ($this->verbose) {
56			DB::alteration_message("not adding ".$campaign->Subject." because it has not been sent yet...", "edited");
57			}
58			}
59			}
60			} else {
61			if ($this->verbose) {
62			DB::alteration_message("there are no campaigns to be added", "edited");
63			}
64			}
65			if ($this->verbose) {
66			DB::alteration_message("<hr /><hr /><hr />Completed", "edited");
67			}
68			}
69			}
70

sunnysideup / silverstripe-campaignmonitor

CampaignMonitorAddOldCampaigns::run() C last analyzed 2018-06-20 01:09 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

CampaignMonitorAddOldCampaigns::run() C
last analyzed 2018-06-20 01:09 UTC