CampaignMonitorAddOldCampaigns

Complexity

Total Complexity

12

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setVerbose()	0	4	1
C	run()	0	47	11

	<?php

It is not recommended to output anything before PHP's opening tag in non-template files.

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 5 and the first side effect is on line 1.

class CampaignMonitorAddOldCampaigns extends BuildTask

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $title = "Retrieves a list of campaigns from Campaign Monitor.";

    protected $description = "Retrieves a list of campaigns from Campaign Monitor for future display.";

    protected $verbose = true;

    public function setVerbose($b)
    {
        $this->verbose = $b;
    }

    /**
     * @param SS_HTTP_Request
     * standard method
     */
    public function run($request)
    {
        $faultyOnes = CampaignMonitorCampaign::get()->where("(\"CampaignID\" = '' OR \"CampaignID\" IS NULL) AND (\"WebVersionURL\" IS NOT NULL && \"WebVersionURL\" <> '')");
        foreach ($faultyOnes as $faultyOne) {
            $faultyOne->delete();
        }
        $api = CampaignMonitorAPIConnector::create();
        $api->init();
        $campaigns = $api->getCampaigns();
        if (is_array($campaigns)) {
            foreach ($campaigns as $campaign) {
                if ($campaign->SentDate) {
                    $campaignMonitorCampaign = CampaignMonitorCampaign::get()->filter(array("CampaignID" => $campaign->CampaignID))->first();
                    if (!$campaignMonitorCampaign) {
                        if ($this->verbose) {
                            DB::alteration_message("Adding ".$campaign->Subject." sent ".$campaign->SentDate, "created");
                        }
                        $campaignMonitorCampaign = CampaignMonitorCampaign::create();
                    } else {
                        if ($this->verbose) {
                            DB::alteration_message("already added ".$campaign->Subject, "edited");
                        }
                    }
                    $campaignMonitorCampaign->HasBeenSent = true;
                    $campaignMonitorCampaign->CampaignID = $campaign->CampaignID;
                    $campaignMonitorCampaign->Subject = $campaign->Subject;
                    $campaignMonitorCampaign->Name = $campaign->Name;
                    $campaignMonitorCampaign->SentDate = $campaign->SentDate;
                    $campaignMonitorCampaign->WebVersionURL = $campaign->WebVersionURL;
                    $campaignMonitorCampaign->WebVersionTextURL = $campaign->WebVersionTextURL;
                    //$CampaignMonitorCampaign->ParentID = $this->ID;

50% of this comment could be valid code. Did you maybe forget this after debugging?

                    $campaignMonitorCampaign->write();
                } else {
                    if ($this->verbose) {
                        DB::alteration_message("not adding ".$campaign->Subject." because it has not been sent yet...", "edited");
                    }
                }
            }
        } else {
            if ($this->verbose) {
                DB::alteration_message("there are no campaigns to be added", "edited");
            }
        }
        if ($this->verbose) {
            DB::alteration_message("<hr /><hr /><hr />Completed", "edited");
        }
    }
}