CallToAction::getCMSFields() - Code Metrics - sunnysideup/silverstripe-call_to_action - Measure and Improve Code Quality continuously with Scrutinizer

CallToAction::getCMSFields() B
last analyzed 2018-03-20 00:56 UTC

↳ Parent: CallToAction

Complexity

Conditions	1
Paths	1

Size

Total Lines	45
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	45
c	0
b	0
f	0
rs	8.8571
cc	1
eloc	39
nc	1
nop	0

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 *
 **/

class CallToAction extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = [

        'Title' => 'Varchar(100)',
        'Text' => 'Varchar(255)',
        'FontColour' => 'enum("white,black", "white")',
        'ImageFocusPoint' => 'enum("Centre,N,NW,W,SW,S,SE,E,NE", "Centre")',
        'CallToAction' => 'Varchar(50)',
        'VideoBackground' => 'Varchar(255)'
    ];

    private static $has_one = [

        'Image' => 'Image',
        'Link' => 'SiteTree'
    ];

    private static $summary_fields = [

        'Title' => 'Title',
        'Text' => 'Text',
        'Link.Title' => 'Link',
        'Image.CMSThumbNail' => 'Image'
    ];

    private static $has_many = [

        'Pages' => 'Page'
    ];

    private static $default_sort = [

        'Title' => 'ASC'
    ];

    private static $singular_name  = 'Call To Action';


    private static $plural_name = 'Calls To Action';


    private static $field_labels = [

        'Title' => 'Title',
        'Text' => 'Text',
        'FontColour' => 'Text Colour',
        'ImageFocusPoint' => 'Focus Point',
        'CallToAction' => 'Call to Action',
        'Image' => 'Image',
        'Link' => 'Link'
    ];

    private static $colour_font_options = [

        'white' => 'white',
        'black' => 'black'
    ];

    private static $field_labels_right = [

        'Title' => 'A few words.',
        'Text' => 'A short sentence showing as the main text on the image.',
        'FontColour' => 'Text colour',
        'ImageFocusPoint' => 'What part of the image should be visible no matter what?',
        'Image' => 'Please ensure it is at least 2800px wide, but preferably a highly compressed image of 4800px wide',
        'CallToAction' => 'The text on the button - e.g. Sign Up Now (Optional)',
        'VideoBackground' => 'A link to a video anywhere on the internet. This takes priority over the image below.',
        'Link' => 'Optional link on button, if left blank users will simply scroll down.'
    ];

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fieldLabels = $this->FieldLabels();
        $fieldLabelsRight = Config::inst()->get('CallToAction', 'field_labels_right');
        $fields->addFieldsToTab(
            'Root.Main',
            [
                UploadField::create(
                    'Image',
                    $fieldLabels['Image']
                )->setRightTitle($fieldLabelsRight['Image']),
                TextField::create(
                    'Title',
                    $fieldLabels['Title']
                )->setRightTitle($fieldLabelsRight['Title']),
                TextareaField::create(
                    'Text',
                    $fieldLabels['Text']
                )->setRightTitle($fieldLabelsRight['Text']),
                DropdownField::create(
                    'FontColour',
                    $fieldLabels['FontColour'],
                    Config::inst()->get('CallToAction', 'colour_font_options')
                )->setRightTitle($fieldLabelsRight['FontColour']),
                TextField::create(
                    'CallToAction',
                    $fieldLabels['CallToAction']
                )->setRightTitle($fieldLabelsRight['CallToAction']),
                TreeDropdownField::create(
                    'LinkID',
                    $fieldLabels['Link'],
                    'SiteTree'
                )->setRightTitle($fieldLabelsRight['Link']),
                DropdownField::create(
                    'ImageFocusPoint',
                    $fieldLabels['ImageFocusPoint'],
                    $this->dbObject('ImageFocusPoint')->enumValues()
                )->setRightTitle($fieldLabelsRight['ImageFocusPoint'])
            ]
        );
        $fields->removeByName('Pages');

        return $fields;
    }

    function CMSEditLink()

    {
        return Director::absoluteBaseURL('/').'admin/calltoaction/CallToAction/EditForm/field/CallToAction/item/'.$this->ID.'/edit/';

    }

    function CMSAddLink()

    {
        return Director::absoluteBaseURL('/').'/admin/calltoaction/CallToAction/EditForm/field/CallToAction/item/new';

    }

    /**
     * left top
     */
    function BackgroundPosition()

    {
        $str = 'center';
        switch($this->ImageFocusPoint) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            case 'Centre': $str = 'center'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'NE': $str = 'top right'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'E': $str = 'center right'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'SE': $str = 'bottom right'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'S': $str = 'bottom center'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'SW': $str = 'bottom left'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'W': $str = 'bottom left'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'NW': $str = 'top left'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'N': $str = 'top center'; break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }

        return $str;
    }
}


1			<?php
2
3			/**
4			*@author nicolaas [at] sunnysideup.co.nz
5			*
6			*
7			**/
8
9			class CallToAction extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			private static $db = [
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12			'Title' => 'Varchar(100)',
13			'Text' => 'Varchar(255)',
14			'FontColour' => 'enum("white,black", "white")',
15			'ImageFocusPoint' => 'enum("Centre,N,NW,W,SW,S,SE,E,NE", "Centre")',
16			'CallToAction' => 'Varchar(50)',
17			'VideoBackground' => 'Varchar(255)'
18			];
19
20			private static $has_one = [
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21			'Image' => 'Image',
22			'Link' => 'SiteTree'
23			];
24
25			private static $summary_fields = [
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26			'Title' => 'Title',
27			'Text' => 'Text',
28			'Link.Title' => 'Link',
29			'Image.CMSThumbNail' => 'Image'
30			];
31
32			private static $has_many = [
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$has_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33			'Pages' => 'Page'
34			];
35
36			private static $default_sort = [
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
37			'Title' => 'ASC'
38			];
39
40			private static $singular_name = 'Call To Action';
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
41
42			private static $plural_name = 'Calls To Action';
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
43
44			private static $field_labels = [
			0 ignored issues – show Comprehensibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
45			'Title' => 'Title',
46			'Text' => 'Text',
47			'FontColour' => 'Text Colour',
48			'ImageFocusPoint' => 'Focus Point',
49			'CallToAction' => 'Call to Action',
50			'Image' => 'Image',
51			'Link' => 'Link'
52			];
53
54			private static $colour_font_options = [
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$colour_font_options` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
55			'white' => 'white',
56			'black' => 'black'
57			];
58
59			private static $field_labels_right = [
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$field_labels_right` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
60			'Title' => 'A few words.',
61			'Text' => 'A short sentence showing as the main text on the image.',
62			'FontColour' => 'Text colour',
63			'ImageFocusPoint' => 'What part of the image should be visible no matter what?',
64			'Image' => 'Please ensure it is at least 2800px wide, but preferably a highly compressed image of 4800px wide',
65			'CallToAction' => 'The text on the button - e.g. Sign Up Now (Optional)',
66			'VideoBackground' => 'A link to a video anywhere on the internet. This takes priority over the image below.',
67			'Link' => 'Optional link on button, if left blank users will simply scroll down.'
68			];
69
70			public function getCMSFields()
71			{
72			$fields = parent::getCMSFields();
73			$fieldLabels = $this->FieldLabels();
74			$fieldLabelsRight = Config::inst()->get('CallToAction', 'field_labels_right');
75			$fields->addFieldsToTab(
76			'Root.Main',
77			[
78			UploadField::create(
79			'Image',
80			$fieldLabels['Image']
81			)->setRightTitle($fieldLabelsRight['Image']),
82			TextField::create(
83			'Title',
84			$fieldLabels['Title']
85			)->setRightTitle($fieldLabelsRight['Title']),
86			TextareaField::create(
87			'Text',
88			$fieldLabels['Text']
89			)->setRightTitle($fieldLabelsRight['Text']),
90			DropdownField::create(
91			'FontColour',
92			$fieldLabels['FontColour'],
93			Config::inst()->get('CallToAction', 'colour_font_options')
94			)->setRightTitle($fieldLabelsRight['FontColour']),
95			TextField::create(
96			'CallToAction',
97			$fieldLabels['CallToAction']
98			)->setRightTitle($fieldLabelsRight['CallToAction']),
99			TreeDropdownField::create(
100			'LinkID',
101			$fieldLabels['Link'],
102			'SiteTree'
103			)->setRightTitle($fieldLabelsRight['Link']),
104			DropdownField::create(
105			'ImageFocusPoint',
106			$fieldLabels['ImageFocusPoint'],
107			$this->dbObject('ImageFocusPoint')->enumValues()
108			)->setRightTitle($fieldLabelsRight['ImageFocusPoint'])
109			]
110			);
111			$fields->removeByName('Pages');
112
113			return $fields;
114			}
115
116			function CMSEditLink()
			0 ignored issues – show Best Practice introduced 2017-08-24 08:39 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
117			{
118			return Director::absoluteBaseURL('/').'admin/calltoaction/CallToAction/EditForm/field/CallToAction/item/'.$this->ID.'/edit/';
			0 ignored issues – show Unused Code introduced 2017-08-24 08:39 UTC by Report Bug Copy Issue Report The call to `Director::absoluteBaseURL()` has too many arguments starting with `'/'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
119			}
120
121			function CMSAddLink()
			0 ignored issues – show Best Practice introduced 2017-08-24 08:39 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
122			{
123			return Director::absoluteBaseURL('/').'/admin/calltoaction/CallToAction/EditForm/field/CallToAction/item/new';
			0 ignored issues – show Unused Code introduced 2017-08-24 08:39 UTC by Report Bug Copy Issue Report The call to `Director::absoluteBaseURL()` has too many arguments starting with `'/'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
124			}
125
126			/**
127			* left top
128			*/
129			function BackgroundPosition()
			0 ignored issues – show Best Practice introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
130			{
131			$str = 'center';
132			switch($this->ImageFocusPoint) {
			0 ignored issues – show Documentation introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `ImageFocusPoint` does not exist on `object<CallToAction>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
133			case 'Centre': $str = 'center'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
134			case 'NE': $str = 'top right'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
135			case 'E': $str = 'center right'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
136			case 'SE': $str = 'bottom right'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
137			case 'S': $str = 'bottom center'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
138			case 'SW': $str = 'bottom left'; break;
			0 ignored issues – show Coding Style introduced 2017-10-11 01:31 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-10-11 01:31 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-10-11 01:31 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
139			case 'W': $str = 'bottom left'; break;
			0 ignored issues – show Coding Style introduced 2017-10-11 01:31 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-10-11 01:31 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-10-11 01:31 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
140			case 'NW': $str = 'top left'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
141			case 'N': $str = 'top center'; break;
			0 ignored issues – show Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
142			}
143
144			return $str;
145			}
146			}
147

sunnysideup / silverstripe-call_to_action

CallToAction::getCMSFields() B last analyzed 2018-03-20 00:56 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CallToAction::getCMSFields() B
last analyzed 2018-03-20 00:56 UTC