CallToAction

Complexity

Total Complexity

13

Size/Duplication

Total Lines	138
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	45	1
A	CMSEditLink()	0	4	1
A	CMSAddLink()	0	4	1
B	BackgroundPosition()	0	17	10

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 *
 **/

class CallToAction extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title' => 'Varchar(100)',
        'Text' => 'Varchar(255)',
        'FontColour' => 'enum("white,black", "white")',
        'ImageFocusPoint' => 'enum("Centre,N,NW,W,SW,S,SE,E,NE", "Centre")',
        'CallToAction' => 'Varchar(50)',
        'VideoBackground' => 'Varchar(255)'
    ];

    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Image' => 'Image',
        'Link' => 'SiteTree'
    ];

    private static $summary_fields = [

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'Title' => 'Title',
        'Text' => 'Text',
        'Link.Title' => 'Link',
        'Image.CMSThumbNail' => 'Image'
    ];

    private static $has_many = [

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'Pages' => 'Page'
    ];

    private static $default_sort = [

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

        'Title' => 'ASC'
    ];

    private static $singular_name  = 'Call To Action';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = 'Calls To Action';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    private static $field_labels = [

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        'Title' => 'Title',
        'Text' => 'Text',
        'FontColour' => 'Text Colour',
        'ImageFocusPoint' => 'Focus Point',
        'CallToAction' => 'Call to Action',
        'Image' => 'Image',
        'Link' => 'Link'
    ];

    private static $colour_font_options = [

The property $colour_font_options is not used and could be removed.

        'white' => 'white',
        'black' => 'black'
    ];

    private static $field_labels_right = [

The property $field_labels_right is not used and could be removed.

        'Title' => 'A few words.',
        'Text' => 'A short sentence showing as the main text on the image.',
        'FontColour' => 'Text colour',
        'ImageFocusPoint' => 'What part of the image should be visible no matter what?',
        'Image' => 'Please ensure it is at least 2800px wide, but preferably a highly compressed image of 4800px wide',
        'CallToAction' => 'The text on the button - e.g. Sign Up Now (Optional)',
        'VideoBackground' => 'A link to a video anywhere on the internet. This takes priority over the image below.',
        'Link' => 'Optional link on button, if left blank users will simply scroll down.'
    ];

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fieldLabels = $this->FieldLabels();
        $fieldLabelsRight = Config::inst()->get('CallToAction', 'field_labels_right');
        $fields->addFieldsToTab(
            'Root.Main',
            [
                UploadField::create(
                    'Image',
                    $fieldLabels['Image']
                )->setRightTitle($fieldLabelsRight['Image']),
                TextField::create(
                    'Title',
                    $fieldLabels['Title']
                )->setRightTitle($fieldLabelsRight['Title']),
                TextareaField::create(
                    'Text',
                    $fieldLabels['Text']
                )->setRightTitle($fieldLabelsRight['Text']),
                DropdownField::create(
                    'FontColour',
                    $fieldLabels['FontColour'],
                    Config::inst()->get('CallToAction', 'colour_font_options')
                )->setRightTitle($fieldLabelsRight['FontColour']),
                TextField::create(
                    'CallToAction',
                    $fieldLabels['CallToAction']
                )->setRightTitle($fieldLabelsRight['CallToAction']),
                TreeDropdownField::create(
                    'LinkID',
                    $fieldLabels['Link'],
                    'SiteTree'
                )->setRightTitle($fieldLabelsRight['Link']),
                DropdownField::create(
                    'ImageFocusPoint',
                    $fieldLabels['ImageFocusPoint'],
                    $this->dbObject('ImageFocusPoint')->enumValues()
                )->setRightTitle($fieldLabelsRight['ImageFocusPoint'])
            ]
        );
        $fields->removeByName('Pages');

        return $fields;
    }

    function CMSEditLink()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return Director::absoluteBaseURL('/').'admin/calltoaction/CallToAction/EditForm/field/CallToAction/item/'.$this->ID.'/edit/';

The call to Director::absoluteBaseURL() has too many arguments starting with '/'.

    }

    function CMSAddLink()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return Director::absoluteBaseURL('/').'/admin/calltoaction/CallToAction/EditForm/field/CallToAction/item/new';

The call to Director::absoluteBaseURL() has too many arguments starting with '/'.

    }

    /**
     * left top
     */
    function BackgroundPosition()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $str = 'center';
        switch($this->ImageFocusPoint) {

The property ImageFocusPoint does not exist on object<CallToAction>. Since you implemented __get, maybe consider adding a @property annotation.

            case 'Centre': $str = 'center'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'NE': $str = 'top right'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'E': $str = 'center right'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'SE': $str = 'bottom right'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'S': $str = 'bottom center'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'SW': $str = 'bottom left'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'W': $str = 'bottom left'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'NW': $str = 'top left'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'N': $str = 'top center'; break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

        }

        return $str;
    }
}