Issues in CalendarTime.php (master) - Issues in master - sunnysideup/silverstripe-calendar - Measure and Improve Code Quality continuously with Scrutinizer

Issues (156)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/time/CalendarTime.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class CalendarTime
namespace YourVendor;

class YourClass { }
{

    // Constants

    private static $hours_max = 23;
    private static $minutes_max = 59;
    private static $seconds_max = 59;

    // Attributes

    private $hours;
    private $minutes;
    private $seconds;

    // Constructor

    public function __construct($hours = 0, $minutes = 0, $seconds = 0)
    {
        $this->setHours($hours);
        $this->setMinutes($minutes);
        $this->setSeconds($seconds);
    }
    
    // Functions

    public function getHours()

    {
        return $this->hours;
    }
    
    public function getMinutes()

    {
        return $this->minutes;
    }
    
    public function getSeconds()

    {
        return $this->seconds;
    }
    
    public function setHours($hours)
    {
        $this->setAttribute('hours', $hours, self::$hours_max);
    }
    
    public function setMinutes($minutes)
    {
        $this->setAttribute('minutes', $minutes, self::$minutes_max);
    }
    
    public function setSeconds($seconds)
    {
        $this->setAttribute('seconds', $seconds, self::$seconds_max);
    }
    
    public function __less(CalendarTime $time)
    {
        return $this->hours < $time->hours || ($this->hours == $time->hours && ($this->minutes < $time->minutes || ($this->minutes == $time->minutes && $this->seconds < $time->seconds)));
    }
    
    public function add(CalendarTime $time)
    {
        $hours = $this->hours + $time->hours;
        $minutes = $this->minutes + $time->minutes;
        $seconds = $this->seconds + $time->seconds;
        
        if ($seconds > self::$seconds_max) {

            $factor = self::$seconds_max + 1;
            $minutes += intval($seconds / $factor);
            $seconds %= $factor;
        }
        if ($minutes > self::$minutes_max) {

            $factor = self::$minutes_max + 1;
            $hours += intval($minutes / $factor);
            $minutes %= $factor;
        }
        $factor = self::$hours_max + 1;
        $hours %= $factor;
        
        return new CalendarTime($hours, $minutes, $seconds);
    }
    
    // Private Functions

    private function setAttribute($name, $value, $max)
    {
        if (is_numeric($value)) {
            if (is_int($value + 0)) {
                if ($value >= 0 && $value <= $max) {
                    $this->$name = $value;
                } elseif ($value < 0) {
                    user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a negative value", E_USER_ERROR);
                } else {
                    user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a value more important than $max", E_USER_ERROR);
                }
            } else {
                user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a non integer value", E_USER_ERROR);
            }
        } else {
            user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a non numeric value", E_USER_ERROR);
        }
    }
}


1		<?php
2
3		class CalendarTime
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5
6		// Constants
7
8		private static $hours_max = 23;
9		private static $minutes_max = 59;
10		private static $seconds_max = 59;
11
12		// Attributes
13
14		private $hours;
15		private $minutes;
16		private $seconds;
17
18		// Constructor
19
20		public function __construct($hours = 0, $minutes = 0, $seconds = 0)
21		{
22		$this->setHours($hours);
23		$this->setMinutes($minutes);
24		$this->setSeconds($seconds);
25		}
26
27		// Functions
28
29		public function getHours()
		0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
30		{
31		return $this->hours;
32		}
33
34		public function getMinutes()
		0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
35		{
36		return $this->minutes;
37		}
38
39		public function getSeconds()
		0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
40		{
41		return $this->seconds;
42		}
43
44		public function setHours($hours)
45		{
46		$this->setAttribute('hours', $hours, self::$hours_max);
47		}
48
49		public function setMinutes($minutes)
50		{
51		$this->setAttribute('minutes', $minutes, self::$minutes_max);
52		}
53
54		public function setSeconds($seconds)
55		{
56		$this->setAttribute('seconds', $seconds, self::$seconds_max);
57		}
58
59		public function __less(CalendarTime $time)
60		{
61		return $this->hours < $time->hours \|\| ($this->hours == $time->hours && ($this->minutes < $time->minutes \|\| ($this->minutes == $time->minutes && $this->seconds < $time->seconds)));
62		}
63
64		public function add(CalendarTime $time)
65		{
66		$hours = $this->hours + $time->hours;
67		$minutes = $this->minutes + $time->minutes;
68		$seconds = $this->seconds + $time->seconds;
69
70	View Code Duplication	if ($seconds > self::$seconds_max) {
		0 ignored issues – show Duplication introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		$factor = self::$seconds_max + 1;
72		$minutes += intval($seconds / $factor);
73		$seconds %= $factor;
74		}
75	View Code Duplication	if ($minutes > self::$minutes_max) {
		0 ignored issues – show Duplication introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		$factor = self::$minutes_max + 1;
77		$hours += intval($minutes / $factor);
78		$minutes %= $factor;
79		}
80		$factor = self::$hours_max + 1;
81		$hours %= $factor;
82
83		return new CalendarTime($hours, $minutes, $seconds);
84		}
85
86		// Private Functions
87
88		private function setAttribute($name, $value, $max)
89		{
90		if (is_numeric($value)) {
91		if (is_int($value + 0)) {
92		if ($value >= 0 && $value <= $max) {
93		$this->$name = $value;
94		} elseif ($value < 0) {
95		user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a negative value", E_USER_ERROR);
96		} else {
97		user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a value more important than $max", E_USER_ERROR);
98		}
99		} else {
100		user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a non integer value", E_USER_ERROR);
101		}
102		} else {
103		user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a non numeric value", E_USER_ERROR);
104		}
105		}
106		}
107

sunnysideup / silverstripe-calendar

Issues (156)

Security Analysis not enabled

code/time/CalendarTime.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like