CalendarTime

Complexity

Total Complexity

21

Size/Duplication

Total Lines	104
Duplicated Lines	9.62 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getHours()	0	4	1
A	getMinutes()	0	4	1
A	getSeconds()	0	4	1
A	setHours()	0	4	1
A	setMinutes()	0	4	1
A	setSeconds()	0	4	1
B	__less()	0	4	5
A	add()	10	21	3
B	setAttribute()	0	18	6

<?php

class CalendarTime

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    // Constants

    private static $hours_max = 23;
    private static $minutes_max = 59;
    private static $seconds_max = 59;

    // Attributes

    private $hours;
    private $minutes;
    private $seconds;

    // Constructor

    public function __construct($hours = 0, $minutes = 0, $seconds = 0)
    {
        $this->setHours($hours);
        $this->setMinutes($minutes);
        $this->setSeconds($seconds);
    }
    
    // Functions

    public function getHours()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->hours;
    }
    
    public function getMinutes()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->minutes;
    }
    
    public function getSeconds()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->seconds;
    }
    
    public function setHours($hours)
    {
        $this->setAttribute('hours', $hours, self::$hours_max);
    }
    
    public function setMinutes($minutes)
    {
        $this->setAttribute('minutes', $minutes, self::$minutes_max);
    }
    
    public function setSeconds($seconds)
    {
        $this->setAttribute('seconds', $seconds, self::$seconds_max);
    }
    
    public function __less(CalendarTime $time)
    {
        return $this->hours < $time->hours || ($this->hours == $time->hours && ($this->minutes < $time->minutes || ($this->minutes == $time->minutes && $this->seconds < $time->seconds)));
    }
    
    public function add(CalendarTime $time)
    {
        $hours = $this->hours + $time->hours;
        $minutes = $this->minutes + $time->minutes;
        $seconds = $this->seconds + $time->seconds;
        
        if ($seconds > self::$seconds_max) {

This code seems to be duplicated across your project.

            $factor = self::$seconds_max + 1;
            $minutes += intval($seconds / $factor);
            $seconds %= $factor;
        }
        if ($minutes > self::$minutes_max) {

This code seems to be duplicated across your project.

            $factor = self::$minutes_max + 1;
            $hours += intval($minutes / $factor);
            $minutes %= $factor;
        }
        $factor = self::$hours_max + 1;
        $hours %= $factor;
        
        return new CalendarTime($hours, $minutes, $seconds);
    }
    
    // Private Functions

    private function setAttribute($name, $value, $max)
    {
        if (is_numeric($value)) {
            if (is_int($value + 0)) {
                if ($value >= 0 && $value <= $max) {
                    $this->$name = $value;
                } elseif ($value < 0) {
                    user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a negative value", E_USER_ERROR);
                } else {
                    user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a value more important than $max", E_USER_ERROR);
                }
            } else {
                user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a non integer value", E_USER_ERROR);
            }
        } else {
            user_error("CalendarTime::setAttribute() : you cannot set the \$$name attribute with a non numeric value", E_USER_ERROR);
        }
    }
}