stwalkerster / waca

includes/Router/RequestRouter.php

Doc Comments +1 added lines, -1 removed lines

@@ -423,7 +423,7 @@
 	}
 
 	/**
-	 * @return callable
+	 * @return string[]
 	 */
 	protected function getDefaultRoute()
 	{

includes/Router/PublicRequestRouter.php

Doc Comments +1 added lines, -1 removed lines

@@ -423,7 +423,7 @@
 	}
 
 	/**
-	 * @return callable
+	 * @return string[]
 	 */
 	protected function getDefaultRoute()
 	{

redir.php

Spacing +2 added lines, -2 removed lines

@@ -20,11 +20,11 @@
 	$data = $_GET['data'];
 	$tool = $_GET['tool'];
 
-	if($tool === 'link')
+	if ($tool === 'link')
 	{
 		// quick security check - if you want to exploit something, you better be sure your exploit resolves via dns.
 		// this is not intended to catch everything, just as a quick sanity check.
-		if(gethostbyname($data) == $data){
+		if (gethostbyname($data) == $data) {
 			echo 'Error resolving hostname, it doesn\'t look like this domain exists.';
 			die();
 		}

Braces +2 added lines, -3 removed lines

@@ -20,11 +20,10 @@
 	$data = $_GET['data'];
 	$tool = $_GET['tool'];
 
-	if($tool === 'link')
-	{
+	if($tool === 'link') {
 		// quick security check - if you want to exploit something, you better be sure your exploit resolves via dns.
 		// this is not intended to catch everything, just as a quick sanity check.
-		if(gethostbyname($data) == $data){
+		if(gethostbyname($data) == $data) {
 			echo 'Error resolving hostname, it doesn\'t look like this domain exists.';
 			die();
 		}

includes/Pages/Request/PageConfirmEmail.php

Spacing +2 added lines, -2 removed lines

@@ -56,14 +56,14 @@
 		try {
 			$request->save();
 		}
-		catch(OptimisticLockFailedException $ex){
+		catch (OptimisticLockFailedException $ex) {
 			// Okay. Someone's edited this in the time between us loading this page and doing the checks, and us getting
 			// to saving the page. We *do not* want to show an optimistic lock failure, the most likely problem is they
 			// double-loaded this page (see #255). Let's confirm this, and bomb out with a success message if it's the
 			// case.
 
 			$request = Request::getById($id, $this->getDatabase());
-			if($request->getEmailConfirm() === 'Confirmed') {
+			if ($request->getEmailConfirm() === 'Confirmed') {
 				// we've already done the sanity checks above
 
 				$this->redirect('requestSubmitted');

Braces +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 		try {
 			$request->save();
 		}
-		catch(OptimisticLockFailedException $ex){
+		catch(OptimisticLockFailedException $ex) {
 			// Okay. Someone's edited this in the time between us loading this page and doing the checks, and us getting
 			// to saving the page. We *do not* want to show an optimistic lock failure, the most likely problem is they
 			// double-loaded this page (see #255). Let's confirm this, and bomb out with a success message if it's the

includes/Tasks/ITask.php

Doc Comments +1 added lines

@@ -164,6 +164,7 @@
 
 	/**
 	 * @param TorExitProvider $torExitProvider
+	 * @return void
 	 */
 	public function setTorExitProvider($torExitProvider);
 }
\ No newline at end of file

includes/DataObjects/Request.php

Spacing +1 added lines, -1 removed lines

@@ -414,7 +414,7 @@
 			. '|' . $this->forwardedip  // } private data not known to those without access
 			. '|' . $this->useragent    // }
 			. '|' . $this->email        // }
-			. '|' . $this->status;      // to rudimentarily invalidate the token on status change
+			. '|' . $this->status; // to rudimentarily invalidate the token on status change
 
 		return hash('sha256', $data);
 	}

includes/Helpers/IrcNotificationHelper.php

Spacing +2 added lines, -2 removed lines

@@ -57,11 +57,11 @@
 	) {
 		$this->primaryDatabase = $primaryDatabase;
 
-		if(true){
+		if (true) {
 			$this->notificationsDatabase = $notificationsDatabase;
 			$this->notificationsEnabled = $siteConfiguration->getIrcNotificationsEnabled();
 		}
-		else{
+		else {
 			$this->notificationsEnabled = false;
 		}
 

Braces +2 added lines, -2 removed lines

@@ -57,11 +57,11 @@
 	) {
 		$this->primaryDatabase = $primaryDatabase;
 
-		if(true){
+		if(true) {
 			$this->notificationsDatabase = $notificationsDatabase;
 			$this->notificationsEnabled = $siteConfiguration->getIrcNotificationsEnabled();
 		}
-		else{
+		else {
 			$this->notificationsEnabled = false;
 		}
 

includes/Helpers/LogHelper.php

Spacing +1 added lines, -1 removed lines

@@ -273,7 +273,7 @@
 				$welcomeTemplate = WelcomeTemplate::getById($objectId, $database);
 
 				// some old templates have been completely deleted and lost to the depths of time.
-				if($welcomeTemplate === false){
+				if ($welcomeTemplate === false) {
 					return "Welcome template #{$objectId}";
 				} else {
 					$userCode = htmlentities($welcomeTemplate->getUserCode(), ENT_COMPAT, 'UTF-8');

Braces +3 added lines, -2 removed lines

@@ -273,9 +273,10 @@
 				$welcomeTemplate = WelcomeTemplate::getById($objectId, $database);
 
 				// some old templates have been completely deleted and lost to the depths of time.
-				if($welcomeTemplate === false){
+				if($welcomeTemplate === false) {
 					return "Welcome template #{$objectId}";
-				} else {
+				}
+				else {
 					$userCode = htmlentities($welcomeTemplate->getUserCode(), ENT_COMPAT, 'UTF-8');
 					return "<a href=\"{$baseurl}/internal.php/welcomeTemplates/view?template={$objectId}\">{$userCode}</a>";
 				}