studieren-ohne-grenzen / dashboard

app/sog/Dashboard/Authentication/LdapUserProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
      *
      * @param string $user_dn The user DN for which to infer the rules
      * @param array $ownerships The owned groups for the user DN
-     * @return array The roles of the given user
+     * @return string[] The roles of the given user
      */
     private function getRoles($user_dn, $ownerships)
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
 use Zend\Ldap\Exception\LdapException;
-use Zend\Ldap\Ldap;
 
 /**
  * This class maps a requested user to its LDAP entry.

Indentation +3 added lines, -3 removed lines

@@ -54,9 +54,9 @@
             $roles = $this->getRoles($dn, $ownerships);
             return new LdapUser($username, null, $attributes, $roles, $memberships, $ownerships);
         } catch (LdapException $ex) {
-          throw new UsernameNotFoundException($ex->getMessage().'Der Login war nicht erfolgreich, bitte überprüfe deinen Benutzernamen und Passwort.');
-          $logger = $this->get('logger');
-          $logger->error(($ex->getMessage()));
+            throw new UsernameNotFoundException($ex->getMessage().'Der Login war nicht erfolgreich, bitte überprüfe deinen Benutzernamen und Passwort.');
+            $logger = $this->get('logger');
+            $logger->error(($ex->getMessage()));
         }
     }
 

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
             $roles = $this->getRoles($dn, $ownerships);
             return new LdapUser($username, null, $attributes, $roles, $memberships, $ownerships);
         } catch (LdapException $ex) {
-          throw new UsernameNotFoundException($ex->getMessage().'Der Login war nicht erfolgreich, bitte überprüfe deinen Benutzernamen und Passwort.');
+          throw new UsernameNotFoundException($ex->getMessage() . 'Der Login war nicht erfolgreich, bitte überprüfe deinen Benutzernamen und Passwort.');
           $logger = $this->get('logger');
           $logger->error(($ex->getMessage()));
         }

app/sog/Dashboard/Authentication/LdapUser.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
         $this->attributes = $attributes;
         $this->roles = $roles;
         $this->memberships = $memberships;
-        $this->ownerships = array_map(function($group) {
+        $this->ownerships = array_map(function ($group) {
             return $group['ou'][0];
         }, $ownerships);
     }

app/sog/Dashboard/LdapAdapter.php

Doc Comments +2 added lines, -2 removed lines

@@ -150,7 +150,7 @@ 
      * Retrieves all members for the given group CN
      *
      * @param string $group_ou The common name of the group for which we want to retrieve the members
-     * @param array $fields A list of fields we want to return from the search
+     * @param string[] $fields A list of fields we want to return from the search
      * @return bool|\Zend\Ldap\Collection
      * @throws LdapException
      */
@@ -219,7 +219,7 @@ 
      * Retrieves all memberships for the given DN
      *
      * @param string $user_dn The DN for which to get the memberships
-     * @param array $fields A list of fields we want to return from the search
+     * @param string[] $fields A list of fields we want to return from the search
      * @param string $attribute The attribute which we use for filtering
      * @return bool|\Zend\Ldap\Collection
      * @throws LdapException

Braces +5 added lines, -4 removed lines

@@ -183,10 +183,11 @@
             ['dn', 'uid', 'cn', 'displayName', $attribute],
             'dn'
         );
-        if ($results->count() > 0)
-            return $results->getFirst();
-        else
-            return false;
+        if ($results->count() > 0) {
+                    return $results->getFirst();
+        } else {
+                    return false;
+        }
     }
 
     /**

Spacing +5 added lines, -5 removed lines

@@ -352,17 +352,17 @@
      */
     public function createGuest($name, $mail)
     {
-        $username = 'guest'.$this->generateUsername($name);
+        $username = 'guest' . $this->generateUsername($name);
         $dn = sprintf('uid=%s,ou=guests,ou=people,o=sog-de,dc=sog', $username);
         $info = [];
 
         // core data
         Attribute::setAttribute($info, 'dn', $dn);
         Attribute::setAttribute($info, 'uid', $username);
-        Attribute::setAttribute($info, 'cn', "Guest ".$name);
-        Attribute::setAttribute($info, 'displayName', "Guest ".$name);
-        Attribute::setAttribute($info, 'sn', "Guest ".$name);
-        Attribute::setAttribute($info, 'cn', "Guest ".$name);
+        Attribute::setAttribute($info, 'cn', "Guest " . $name);
+        Attribute::setAttribute($info, 'displayName', "Guest " . $name);
+        Attribute::setAttribute($info, 'sn', "Guest " . $name);
+        Attribute::setAttribute($info, 'cn', "Guest " . $name);
 
         // meta data
         Attribute::setAttribute($info, 'mail', $mail);

public/index.php

Braces +31 added lines, -11 removed lines

@@ -65,7 +65,8 @@ 
             $groupDN = sprintf('ou=%s,ou=groups,o=sog-de,dc=sog', $groupOU);
             $groupAttr = $app['ldap']->getEntry($groupDN, ['cn', 'owner']);
 
-            switch ($action) {
+            switch ($action)
+            {
                 case 'quit':
                     try {
                         if (in_array($userDN, $groupAttr['owner'])) {
@@ -112,15 +113,23 @@ 
         $groupList = [];
         foreach ($groups as $g) {
             $roles = [];
-            if (isset($g['owner']) && in_array($userDN, $g['owner'])) $roles[] = 'owner';
-            if (isset($g['member']) && in_array($userDN, $g['member'])) $roles[] = 'member';
-            if (isset($g['pending']) && in_array($userDN, $g['pending'])) $roles[] = 'pending';
+            if (isset($g['owner']) && in_array($userDN, $g['owner'])) {
+                $roles[] = 'owner';
+            }
+            if (isset($g['member']) && in_array($userDN, $g['member'])) {
+                $roles[] = 'member';
+            }
+            if (isset($g['pending']) && in_array($userDN, $g['pending'])) {
+                $roles[] = 'pending';
+            }
 
             $owners = [];
             if (isset($g['owner'])) {
                 for ($j = 0; $j < count($g['owner']); $j++) {
                     $o = $app['ldap']->getEntry($g['owner'][$j], ['cn', 'mail']);
-                    if (isset($o)) $owners[] = $o;
+                    if (isset($o)) {
+                        $owners[] = $o;
+                    }
                 }
             }
 
@@ -155,7 +164,9 @@ 
             return new \Symfony\Component\HttpFoundation\RedirectResponse('/members/Benutzerdaten');
         }
 
-        if (!isset($selGroup)) $selGroup = $ownedGroups[0]['ou'][0];
+        if (!isset($selGroup)) {
+            $selGroup = $ownedGroups[0]['ou'][0];
+        }
         $selGroupDN = sprintf('ou=%s,ou=groups,o=sog-de,dc=sog', $selGroup);
 
         $action = $request->request->get('manage-action');
@@ -178,7 +189,8 @@ 
 
                 $groupAttr = $app['ldap']->getEntry($selGroupDN, ['owner']);
 
-                switch ($action) {
+                switch ($action)
+                {
                     case 'activate':
                         try {
                             $app['ldap']->activateMember($userID);
@@ -231,11 +243,19 @@ 
         $memberList = [];
         foreach ($allUsers as $u) {
             $roles = [];
-            if (isset($groupAttr['owner']) && in_array($u['dn'], $groupAttr['owner'])) $roles[] = 'owner';
-            if (isset($groupAttr['member']) && in_array($u['dn'], $groupAttr['member'])) $roles[] = 'member';
-            if (isset($groupAttr['pending']) && in_array($u['dn'], $groupAttr['pending'])) $roles[] = 'pending';
+            if (isset($groupAttr['owner']) && in_array($u['dn'], $groupAttr['owner'])) {
+                $roles[] = 'owner';
+            }
+            if (isset($groupAttr['member']) && in_array($u['dn'], $groupAttr['member'])) {
+                $roles[] = 'member';
+            }
+            if (isset($groupAttr['pending']) && in_array($u['dn'], $groupAttr['pending'])) {
+                $roles[] = 'pending';
+            }
             // we handle inactive members like the other cases, the UI is just so similar
-            if (strstr($u['dn'], 'ou=inactive')) $roles[] = 'inactive';
+            if (strstr($u['dn'], 'ou=inactive')) {
+                $roles[] = 'inactive';
+            }
 
             $listentry = array(
                 'name' => $u['cn'][0],

app/sog/Dashboard/GuestControllerProvider.php

Braces +8 added lines, -5 removed lines

@@ -85,7 +85,9 @@ 
             $ownedGroups = $app['ldap']->getOwnedGroups($user->getAttributes()['dn'])->toArray();
 
             $selGroup = $request->request->get('ou');
-            if (!isset($selGroup)) $selGroup = $ownedGroups[0]['ou'][0];
+            if (!isset($selGroup)) {
+                $selGroup = $ownedGroups[0]['ou'][0];
+            }
             $selGroupDN = sprintf('ou=%s,ou=groups,o=sog-de,dc=sog', $selGroup);
 
             foreach ($ownedGroups as $og) {
@@ -151,9 +153,10 @@ 
     private function retrieveGuestByMail($mail)
     {
         $info = $this->app['ldap']->getMemberByMail($mail, 'mail');
-        if (is_array($info))
-            return $info['dn'];
-        else
-            return false;
+        if (is_array($info)) {
+                    return $info['dn'];
+        } else {
+                    return false;
+        }
     }
 }
\ No newline at end of file