studieren-ohne-grenzen / dashboard

app/sog/Dashboard/Authentication/LdapUserProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
      *
      * @param string $user_dn The user DN for which to infer the rules
      * @param array $ownerships The owned groups for the user DN
-     * @return array The roles of the given user
+     * @return string[] The roles of the given user
      */
     private function getRoles($user_dn, $ownerships)
     {

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
             $roles = $this->getRoles($dn, $ownerships);
             return new LdapUser($username, null, $attributes, $roles, $memberships, $ownerships);
         } catch (LdapException $ex) {
-          throw new UsernameNotFoundException($ex->getMessage().'Der Login war nicht erfolgreich, bitte überprüfe deinen Benutzernamen und Passwort.');
+          throw new UsernameNotFoundException($ex->getMessage() . 'Der Login war nicht erfolgreich, bitte überprüfe deinen Benutzernamen und Passwort.');
           $logger = $this->get('logger');
           $logger->error(($ex->getMessage()));
         }

app/sog/Dashboard/Authentication/LdapUser.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
         $this->attributes = $attributes;
         $this->roles = $roles;
         $this->memberships = $memberships;
-        $this->ownerships = array_map(function($group) {
+        $this->ownerships = array_map(function ($group) {
             return $group['ou'][0];
         }, $ownerships);
     }

app/sog/Dashboard/LdapAdapter.php

Doc Comments +2 added lines, -2 removed lines

@@ -150,7 +150,7 @@ 
      * Retrieves all members for the given group CN
      *
      * @param string $group_ou The common name of the group for which we want to retrieve the members
-     * @param array $fields A list of fields we want to return from the search
+     * @param string[] $fields A list of fields we want to return from the search
      * @return bool|\Zend\Ldap\Collection
      * @throws LdapException
      */
@@ -219,7 +219,7 @@ 
      * Retrieves all memberships for the given DN
      *
      * @param string $user_dn The DN for which to get the memberships
-     * @param array $fields A list of fields we want to return from the search
+     * @param string[] $fields A list of fields we want to return from the search
      * @param string $attribute The attribute which we use for filtering
      * @return bool|\Zend\Ldap\Collection
      * @throws LdapException

Spacing +5 added lines, -5 removed lines

@@ -352,17 +352,17 @@
      */
     public function createGuest($name, $mail)
     {
-        $username = 'guest'.$this->generateUsername($name);
+        $username = 'guest' . $this->generateUsername($name);
         $dn = sprintf('uid=%s,ou=guests,ou=people,o=sog-de,dc=sog', $username);
         $info = [];
 
         // core data
         Attribute::setAttribute($info, 'dn', $dn);
         Attribute::setAttribute($info, 'uid', $username);
-        Attribute::setAttribute($info, 'cn', "Guest ".$name);
-        Attribute::setAttribute($info, 'displayName', "Guest ".$name);
-        Attribute::setAttribute($info, 'sn', "Guest ".$name);
-        Attribute::setAttribute($info, 'cn', "Guest ".$name);
+        Attribute::setAttribute($info, 'cn', "Guest " . $name);
+        Attribute::setAttribute($info, 'displayName', "Guest " . $name);
+        Attribute::setAttribute($info, 'sn', "Guest " . $name);
+        Attribute::setAttribute($info, 'cn', "Guest " . $name);
 
         // meta data
         Attribute::setAttribute($info, 'mail', $mail);