GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Test Failed
Push — develop ( 99571d...4cb748 )
by Steven
03:40
created
src/HtpasswdManager/Controller/UserController.php 3 patches
Indentation   +183 added lines, -183 removed lines patch added patch discarded remove patch
@@ -11,188 +11,188 @@
 block discarded – undo
11 11
 use Zend\View\Model\ViewModel;
12 12
 
13 13
 class UserController extends AbstractActionController {
14
-    private $htpasswdService = NULL;
15
-    private $userService = NULL;
16
-
17
-    /**
18
-     * Check Login
19
-     *
20
-     * @see \Zend\Mvc\Controller\AbstractActionController::onDispatch()
21
-     */
22
-    public function onDispatch(\Zend\Mvc\MvcEvent $e) {
23
-        $username = $this->getUserService()->getCurrentUser();
24
-
25
-        if (false === $this->getUserService()->isUserAllowedToManageUsers($username)) {
26
-            $this->getResponse()->setStatusCode(401);
27
-
28
-            return;
29
-        }
30
-
31
-        return parent::onDispatch($e);
32
-    }
33
-
34
-    public function indexAction() {
35
-        $htpasswdService = $this->getHtpasswdService();
36
-        $userList        = $htpasswdService->getUserList();
37
-
38
-        $result = array();
39
-        foreach ($userList as $username => $pass) {
40
-
41
-            $result [] = array(
42
-                'username'    => $username,
43
-                'paswd'       => $pass,
44
-                'isAdmin'     => $this->getUserService()->isUserAllowedToManageUsers($username),
45
-                'isDeletable' => $this->getUserService()->isUserDeleteable($username)
46
-            );
47
-        }
48
-
49
-        $userService = $this->getServiceLocator()->get('HtpasswdManager\Service\UserService');
50
-
51
-        $model = new ViewModel (array(
52
-            'userList'    => $result,
53
-            'currentUser' => $userService->getCurrentUser()
54
-        ));
55
-
56
-        return $model;
57
-    }
58
-
59
-    public function deleteAction() {
60
-        $user     = $this->params('user');
61
-        $messages = array();
62
-
63
-        if (true === $this->getUserService()->isUserDeleteable($user)) {
64
-            $this->getHtpasswdService()->deleteUser($user);
65
-            $messages [] = "Der Benutzer '{$user}' wurde gelöscht.";
66
-        } else {
67
-            $messages [] = "Der Benutzer '{$user}' steht auf einer Sperrliste und kann nicht gelöscht werden.";
68
-        }
69
-
70
-        $model = $this->indexAction();
71
-        $model->setTemplate('htpasswd-manager/user/index');
72
-        $model->setVariable('messages', $messages);
73
-
74
-        return $model;
75
-    }
76
-
77
-    public function editAction() {
78
-        $user     = $this->params('user');
79
-        $messages = array();
80
-        $htpasswd = $this->getHtpasswdService();
81
-
82
-        $model = new ViewModel ();
83
-        $model->setVariable('user', $user);
84
-
85
-        $post = $this->getRequest()->getPost();
86
-        if (!isset ($post ['password'])) {
87
-            // Formular initialisieren
88
-            if (false === $htpasswd->userExists($user)) {
89
-                $this->redirect()->toRoute('htpasswdmanager', array(
90
-                    'action' => 'index'
91
-                ));
92
-            }
93
-        } else {
94
-            // Formular speichern
95
-            $password = $post ['password'];
96
-            $htpasswd->updateUser($user, $password);
97
-            $messages [] = "Passwort für '{$user}' wurde aktualisiert.";
98
-
99
-            $model = $this->indexAction();
100
-            $model->setTemplate('htpasswd-manager/user/index');
101
-        }
102
-
103
-        $model->setVariable('messages', $messages);
104
-
105
-        return $model;
106
-    }
107
-
108
-    public function addAction() {
109
-        $username = $this->getRequest()->getPost('username', '');
110
-        $password = $this->getRequest()->getPost('password', '');
111
-        $messages = array();
112
-        $model    = new ViewModel ();
113
-
114
-        $post = $this->getRequest()->getPost();
115
-        if (!isset ($post ['username'])) {
116
-            return new ViewModel (array(
117
-                'username' => $username,
118
-                'password' => $password,
119
-                'messages' => $messages
120
-            ));
121
-        }
122
-
123
-        $model->setVariable('username', $username);
124
-        $uValid = $this->isUsernameValid($username);
125
-        if (true !== $uValid) {
126
-            $messages [] = $uValid;
127
-        }
128
-
129
-        $model->setVariable('password', $password);
130
-        $pValid = $this->isPasswordValid($password);
131
-        if (true !== $pValid) {
132
-            $messages [] = $pValid;
133
-        }
134
-
135
-        if (true === $uValid && true === $pValid) {
136
-            if (true === $this->getHtpasswdService()->userExists($username)) {
137
-                $this->getHtpasswdService()->updateUser($username, $password);
138
-                $messages [] = "Benutzer '{$username}' wurde aktualisiert.";
139
-            } else {
140
-                $this->getHtpasswdService()->addUser($username, $password);
141
-                $messages [] = "Benutzer '{$username}' wurde hinzugefügt.";
142
-            }
143
-
144
-            $model = $this->indexAction();
145
-            $model->setTemplate('htpasswd-manager/user/index');
146
-        }
147
-
148
-        $model->setVariable('messages', $messages);
149
-
150
-        return $model;
151
-    }
152
-
153
-    /**
154
-     * Returns true if valid, of not it returns a string with information about the reason
155
-     *
156
-     * @param string $username
157
-     * @return boolean string
158
-     */
159
-    private function isUsernameValid($username) {
160
-        if (strlen($username) <= 2)
161
-            return "Benutzername ist zu kurz.";
162
-        else if (preg_match('~[a-zäöo][a-zäöu_0-9-]+~i', $username) !== 1)
163
-            return "Benutzername enthält ungültige Zeichen";
164
-        else if (strpos($username, ' ') !== false)
165
-            return "Leerzeichen sind im Benutzernamen nicht erlaubt";
166
-
167
-        return true;
168
-    }
169
-
170
-    /**
171
-     * Returns true if valid, of not it returns a string with information about the reason
172
-     *
173
-     * @param string $password
174
-     * @return boolean string
175
-     */
176
-    private function isPasswordValid($password) {
177
-        return true;
178
-    }
179
-
180
-    private function getHtpasswdService() {
181
-        if ($this->htpasswdService === NULL) {
182
-            $sl                    = $this->getServiceLocator();
183
-            $this->htpasswdService = $sl->get('HtpasswdManager\Service\HtpasswdService');
184
-        }
185
-
186
-        return $this->htpasswdService;
187
-    }
188
-
189
-    private function getUserService() {
190
-        if ($this->userService === NULL) {
191
-            $sl                = $this->getServiceLocator();
192
-            $this->userService = $sl->get('HtpasswdManager\Service\UserService');
193
-        }
194
-
195
-        return $this->userService;
196
-    }
14
+	private $htpasswdService = NULL;
15
+	private $userService = NULL;
16
+
17
+	/**
18
+	 * Check Login
19
+	 *
20
+	 * @see \Zend\Mvc\Controller\AbstractActionController::onDispatch()
21
+	 */
22
+	public function onDispatch(\Zend\Mvc\MvcEvent $e) {
23
+		$username = $this->getUserService()->getCurrentUser();
24
+
25
+		if (false === $this->getUserService()->isUserAllowedToManageUsers($username)) {
26
+			$this->getResponse()->setStatusCode(401);
27
+
28
+			return;
29
+		}
30
+
31
+		return parent::onDispatch($e);
32
+	}
33
+
34
+	public function indexAction() {
35
+		$htpasswdService = $this->getHtpasswdService();
36
+		$userList        = $htpasswdService->getUserList();
37
+
38
+		$result = array();
39
+		foreach ($userList as $username => $pass) {
40
+
41
+			$result [] = array(
42
+				'username'    => $username,
43
+				'paswd'       => $pass,
44
+				'isAdmin'     => $this->getUserService()->isUserAllowedToManageUsers($username),
45
+				'isDeletable' => $this->getUserService()->isUserDeleteable($username)
46
+			);
47
+		}
48
+
49
+		$userService = $this->getServiceLocator()->get('HtpasswdManager\Service\UserService');
50
+
51
+		$model = new ViewModel (array(
52
+			'userList'    => $result,
53
+			'currentUser' => $userService->getCurrentUser()
54
+		));
55
+
56
+		return $model;
57
+	}
58
+
59
+	public function deleteAction() {
60
+		$user     = $this->params('user');
61
+		$messages = array();
62
+
63
+		if (true === $this->getUserService()->isUserDeleteable($user)) {
64
+			$this->getHtpasswdService()->deleteUser($user);
65
+			$messages [] = "Der Benutzer '{$user}' wurde gelöscht.";
66
+		} else {
67
+			$messages [] = "Der Benutzer '{$user}' steht auf einer Sperrliste und kann nicht gelöscht werden.";
68
+		}
69
+
70
+		$model = $this->indexAction();
71
+		$model->setTemplate('htpasswd-manager/user/index');
72
+		$model->setVariable('messages', $messages);
73
+
74
+		return $model;
75
+	}
76
+
77
+	public function editAction() {
78
+		$user     = $this->params('user');
79
+		$messages = array();
80
+		$htpasswd = $this->getHtpasswdService();
81
+
82
+		$model = new ViewModel ();
83
+		$model->setVariable('user', $user);
84
+
85
+		$post = $this->getRequest()->getPost();
86
+		if (!isset ($post ['password'])) {
87
+			// Formular initialisieren
88
+			if (false === $htpasswd->userExists($user)) {
89
+				$this->redirect()->toRoute('htpasswdmanager', array(
90
+					'action' => 'index'
91
+				));
92
+			}
93
+		} else {
94
+			// Formular speichern
95
+			$password = $post ['password'];
96
+			$htpasswd->updateUser($user, $password);
97
+			$messages [] = "Passwort für '{$user}' wurde aktualisiert.";
98
+
99
+			$model = $this->indexAction();
100
+			$model->setTemplate('htpasswd-manager/user/index');
101
+		}
102
+
103
+		$model->setVariable('messages', $messages);
104
+
105
+		return $model;
106
+	}
107
+
108
+	public function addAction() {
109
+		$username = $this->getRequest()->getPost('username', '');
110
+		$password = $this->getRequest()->getPost('password', '');
111
+		$messages = array();
112
+		$model    = new ViewModel ();
113
+
114
+		$post = $this->getRequest()->getPost();
115
+		if (!isset ($post ['username'])) {
116
+			return new ViewModel (array(
117
+				'username' => $username,
118
+				'password' => $password,
119
+				'messages' => $messages
120
+			));
121
+		}
122
+
123
+		$model->setVariable('username', $username);
124
+		$uValid = $this->isUsernameValid($username);
125
+		if (true !== $uValid) {
126
+			$messages [] = $uValid;
127
+		}
128
+
129
+		$model->setVariable('password', $password);
130
+		$pValid = $this->isPasswordValid($password);
131
+		if (true !== $pValid) {
132
+			$messages [] = $pValid;
133
+		}
134
+
135
+		if (true === $uValid && true === $pValid) {
136
+			if (true === $this->getHtpasswdService()->userExists($username)) {
137
+				$this->getHtpasswdService()->updateUser($username, $password);
138
+				$messages [] = "Benutzer '{$username}' wurde aktualisiert.";
139
+			} else {
140
+				$this->getHtpasswdService()->addUser($username, $password);
141
+				$messages [] = "Benutzer '{$username}' wurde hinzugefügt.";
142
+			}
143
+
144
+			$model = $this->indexAction();
145
+			$model->setTemplate('htpasswd-manager/user/index');
146
+		}
147
+
148
+		$model->setVariable('messages', $messages);
149
+
150
+		return $model;
151
+	}
152
+
153
+	/**
154
+	 * Returns true if valid, of not it returns a string with information about the reason
155
+	 *
156
+	 * @param string $username
157
+	 * @return boolean string
158
+	 */
159
+	private function isUsernameValid($username) {
160
+		if (strlen($username) <= 2)
161
+			return "Benutzername ist zu kurz.";
162
+		else if (preg_match('~[a-zäöo][a-zäöu_0-9-]+~i', $username) !== 1)
163
+			return "Benutzername enthält ungültige Zeichen";
164
+		else if (strpos($username, ' ') !== false)
165
+			return "Leerzeichen sind im Benutzernamen nicht erlaubt";
166
+
167
+		return true;
168
+	}
169
+
170
+	/**
171
+	 * Returns true if valid, of not it returns a string with information about the reason
172
+	 *
173
+	 * @param string $password
174
+	 * @return boolean string
175
+	 */
176
+	private function isPasswordValid($password) {
177
+		return true;
178
+	}
179
+
180
+	private function getHtpasswdService() {
181
+		if ($this->htpasswdService === NULL) {
182
+			$sl                    = $this->getServiceLocator();
183
+			$this->htpasswdService = $sl->get('HtpasswdManager\Service\HtpasswdService');
184
+		}
185
+
186
+		return $this->htpasswdService;
187
+	}
188
+
189
+	private function getUserService() {
190
+		if ($this->userService === NULL) {
191
+			$sl                = $this->getServiceLocator();
192
+			$this->userService = $sl->get('HtpasswdManager\Service\UserService');
193
+		}
194
+
195
+		return $this->userService;
196
+	}
197 197
 
198 198
 }
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
         $result = array();
39 39
         foreach ($userList as $username => $pass) {
40 40
 
41
-            $result [] = array(
41
+            $result [ ] = array(
42 42
                 'username'    => $username,
43 43
                 'paswd'       => $pass,
44 44
                 'isAdmin'     => $this->getUserService()->isUserAllowedToManageUsers($username),
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
         $userService = $this->getServiceLocator()->get('HtpasswdManager\Service\UserService');
50 50
 
51
-        $model = new ViewModel (array(
51
+        $model = new ViewModel(array(
52 52
             'userList'    => $result,
53 53
             'currentUser' => $userService->getCurrentUser()
54 54
         ));
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
 
63 63
         if (true === $this->getUserService()->isUserDeleteable($user)) {
64 64
             $this->getHtpasswdService()->deleteUser($user);
65
-            $messages [] = "Der Benutzer '{$user}' wurde gelöscht.";
65
+            $messages [ ] = "Der Benutzer '{$user}' wurde gelöscht.";
66 66
         } else {
67
-            $messages [] = "Der Benutzer '{$user}' steht auf einer Sperrliste und kann nicht gelöscht werden.";
67
+            $messages [ ] = "Der Benutzer '{$user}' steht auf einer Sperrliste und kann nicht gelöscht werden.";
68 68
         }
69 69
 
70 70
         $model = $this->indexAction();
@@ -79,11 +79,11 @@  discard block
 block discarded – undo
79 79
         $messages = array();
80 80
         $htpasswd = $this->getHtpasswdService();
81 81
 
82
-        $model = new ViewModel ();
82
+        $model = new ViewModel();
83 83
         $model->setVariable('user', $user);
84 84
 
85 85
         $post = $this->getRequest()->getPost();
86
-        if (!isset ($post ['password'])) {
86
+        if (!isset ($post [ 'password' ])) {
87 87
             // Formular initialisieren
88 88
             if (false === $htpasswd->userExists($user)) {
89 89
                 $this->redirect()->toRoute('htpasswdmanager', array(
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
92 92
             }
93 93
         } else {
94 94
             // Formular speichern
95
-            $password = $post ['password'];
95
+            $password = $post [ 'password' ];
96 96
             $htpasswd->updateUser($user, $password);
97
-            $messages [] = "Passwort für '{$user}' wurde aktualisiert.";
97
+            $messages [ ] = "Passwort für '{$user}' wurde aktualisiert.";
98 98
 
99 99
             $model = $this->indexAction();
100 100
             $model->setTemplate('htpasswd-manager/user/index');
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
         $username = $this->getRequest()->getPost('username', '');
110 110
         $password = $this->getRequest()->getPost('password', '');
111 111
         $messages = array();
112
-        $model    = new ViewModel ();
112
+        $model    = new ViewModel();
113 113
 
114 114
         $post = $this->getRequest()->getPost();
115
-        if (!isset ($post ['username'])) {
116
-            return new ViewModel (array(
115
+        if (!isset ($post [ 'username' ])) {
116
+            return new ViewModel(array(
117 117
                 'username' => $username,
118 118
                 'password' => $password,
119 119
                 'messages' => $messages
@@ -123,22 +123,22 @@  discard block
 block discarded – undo
123 123
         $model->setVariable('username', $username);
124 124
         $uValid = $this->isUsernameValid($username);
125 125
         if (true !== $uValid) {
126
-            $messages [] = $uValid;
126
+            $messages [ ] = $uValid;
127 127
         }
128 128
 
129 129
         $model->setVariable('password', $password);
130 130
         $pValid = $this->isPasswordValid($password);
131 131
         if (true !== $pValid) {
132
-            $messages [] = $pValid;
132
+            $messages [ ] = $pValid;
133 133
         }
134 134
 
135 135
         if (true === $uValid && true === $pValid) {
136 136
             if (true === $this->getHtpasswdService()->userExists($username)) {
137 137
                 $this->getHtpasswdService()->updateUser($username, $password);
138
-                $messages [] = "Benutzer '{$username}' wurde aktualisiert.";
138
+                $messages [ ] = "Benutzer '{$username}' wurde aktualisiert.";
139 139
             } else {
140 140
                 $this->getHtpasswdService()->addUser($username, $password);
141
-                $messages [] = "Benutzer '{$username}' wurde hinzugefügt.";
141
+                $messages [ ] = "Benutzer '{$username}' wurde hinzugefügt.";
142 142
             }
143 143
 
144 144
             $model = $this->indexAction();
Please login to merge, or discard this patch.
Braces   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -157,12 +157,13 @@
 block discarded – undo
157 157
      * @return boolean string
158 158
      */
159 159
     private function isUsernameValid($username) {
160
-        if (strlen($username) <= 2)
161
-            return "Benutzername ist zu kurz.";
162
-        else if (preg_match('~[a-zäöo][a-zäöu_0-9-]+~i', $username) !== 1)
163
-            return "Benutzername enthält ungültige Zeichen";
164
-        else if (strpos($username, ' ') !== false)
165
-            return "Leerzeichen sind im Benutzernamen nicht erlaubt";
160
+        if (strlen($username) <= 2) {
161
+                    return "Benutzername ist zu kurz.";
162
+        } else if (preg_match('~[a-zäöo][a-zäöu_0-9-]+~i', $username) !== 1) {
163
+                    return "Benutzername enthält ungültige Zeichen";
164
+        } else if (strpos($username, ' ') !== false) {
165
+                    return "Leerzeichen sind im Benutzernamen nicht erlaubt";
166
+        }
166 167
 
167 168
         return true;
168 169
     }
Please login to merge, or discard this patch.
src/HtpasswdManager/Service/HtpasswdService.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -18,20 +18,20 @@  discard block
 block discarded – undo
18 18
 
19 19
 	public function __construct($htpasswd_filename) {
20 20
 		$this->filename = $htpasswd_filename;
21
-		$this->createFileIfNotExistant ();
21
+		$this->createFileIfNotExistant();
22 22
 	}
23 23
 
24 24
 	private function createFileIfNotExistant() {
25
-		if (true === file_exists ( $this->filename )) {
25
+		if (true === file_exists($this->filename)) {
26 26
 		} else {
27
-			touch ( $this->filename );
27
+			touch($this->filename);
28 28
 		}
29 29
 	}
30 30
 
31 31
 	private function getHtpasswdContent() {
32 32
 		if ($this->htpasswdCache === null) {
33 33
 			
34
-			$this->htpasswdCache = file_get_contents ( $this->filename );
34
+			$this->htpasswdCache = file_get_contents($this->filename);
35 35
 		}
36 36
 		
37 37
 		return $this->htpasswdCache;
@@ -40,18 +40,18 @@  discard block
 block discarded – undo
40 40
 	private function updateHtpasswdContent() {
41 41
 		$this->htpasswdCache = null;
42 42
 		$this->userListCache = null;
43
-		$this->getUserList ();
43
+		$this->getUserList();
44 44
 	}
45 45
 
46 46
 	public function getUserList() {
47 47
 		if ($this->userListCache === null) {
48 48
 			$result = array();
49 49
 			
50
-			$content = $this->getHtpasswdContent ();
50
+			$content = $this->getHtpasswdContent();
51 51
 			
52
-			if (preg_match_all ( $this::$REGULAR_USER_PASSWORD, $content, $matches, PREG_PATTERN_ORDER ) !== false) {
53
-				foreach ( $matches [1] as $i => $user ) {
54
-					$result [$user] = $matches [2] [$i];
52
+			if (preg_match_all($this::$REGULAR_USER_PASSWORD, $content, $matches, PREG_PATTERN_ORDER) !== false) {
53
+				foreach ($matches [ 1 ] as $i => $user) {
54
+					$result [ $user ] = $matches [ 2 ] [ $i ];
55 55
 				}
56 56
 			}
57 57
 			
@@ -62,43 +62,43 @@  discard block
 block discarded – undo
62 62
 	}
63 63
 
64 64
 	private function encodePassword($password) {
65
-		return crypt ( $password, substr ( str_replace ( '+', '.', base64_encode ( pack ( 'N4', mt_rand (), mt_rand (), mt_rand (), mt_rand () ) ) ), 0, 22 ) );
65
+		return crypt($password, substr(str_replace('+', '.', base64_encode(pack('N4', mt_rand(), mt_rand(), mt_rand(), mt_rand()))), 0, 22));
66 66
 	}
67 67
 
68 68
 	private function getNewUserEncodedString($username, $password) {
69
-		return $username . ':' . $this->encodePassword ( $password ) . "\n";
69
+		return $username . ':' . $this->encodePassword($password) . "\n";
70 70
 	}
71 71
 
72 72
 	public function addUser($username, $password) {
73
-		$newContent = $this->getHtpasswdContent ();
74
-		$newContent .= $this->getNewUserEncodedString ( $username, $password );
73
+		$newContent = $this->getHtpasswdContent();
74
+		$newContent .= $this->getNewUserEncodedString($username, $password);
75 75
 		
76
-		$this->replaceHtPasswdContent ( $newContent );
76
+		$this->replaceHtPasswdContent($newContent);
77 77
 	}
78 78
 
79 79
 	public function updateUser($username, $password) {
80
-		if ($this->userExists ( $username )) {
81
-			$this->deleteUser ( $username );
80
+		if ($this->userExists($username)) {
81
+			$this->deleteUser($username);
82 82
 		}
83 83
 		
84
-		$this->addUser ( $username, $password );
84
+		$this->addUser($username, $password);
85 85
 	}
86 86
 
87 87
 	public function deleteUser($username) {
88 88
 		$newContent = '';
89 89
 		$usernameDeleted = false;
90 90
 		
91
-		if (preg_match_all ( $this::$REGULAR_USER_PASSWORD, $this->getHtpasswdContent (), $match ) > 0) {
92
-			foreach ( $match [1] as $i => $user ) {
91
+		if (preg_match_all($this::$REGULAR_USER_PASSWORD, $this->getHtpasswdContent(), $match) > 0) {
92
+			foreach ($match [ 1 ] as $i => $user) {
93 93
 				if ($user == $username) {
94 94
 					$usernameDeleted = true;
95 95
 				} else {
96
-					$newContent .= $match [0] [$i] . "\n";
96
+					$newContent .= $match [ 0 ] [ $i ] . "\n";
97 97
 				}
98 98
 			}
99 99
 			
100 100
 			if (true === $usernameDeleted) {
101
-				$this->replaceHtPasswdContent ( $newContent );
101
+				$this->replaceHtPasswdContent($newContent);
102 102
 			}
103 103
 		}
104 104
 		
@@ -107,17 +107,17 @@  discard block
 block discarded – undo
107 107
 
108 108
 	private function replaceHtPasswdContent($newContent) {
109 109
 		// Alternative: file_put_contents ( $this->filename, $newContent );
110
-		$fp = fopen ( $this->filename, 'w' );
111
-		fwrite ( $fp, $newContent );
112
-		fclose ( $fp );
110
+		$fp = fopen($this->filename, 'w');
111
+		fwrite($fp, $newContent);
112
+		fclose($fp);
113 113
 		
114
-		$this->updateHtpasswdContent ();
114
+		$this->updateHtpasswdContent();
115 115
 	}
116 116
 
117 117
 	public function userExists($username) {
118
-		$userList = $this->getUserList ();
118
+		$userList = $this->getUserList();
119 119
 		
120
-		if (isset ( $userList [$username] ))
120
+		if (isset ($userList [ $username ]))
121 121
 			return true;
122 122
 		
123 123
 		return false;
Please login to merge, or discard this patch.
src/HtpasswdManager/Test/HtpasswdServiceTest.php 1 patch
Indentation   +106 added lines, -106 removed lines patch added patch discarded remove patch
@@ -5,150 +5,150 @@
 block discarded – undo
5 5
 
6 6
 class HtpasswdServiceTest extends \PHPUnit_Framework_TestCase {
7 7
 
8
-    protected $testDataDir;
8
+	protected $testDataDir;
9 9
 
10
-    public function setUp() {
11
-        $this->testDataDir = __DIR__ . '/TestData';
10
+	public function setUp() {
11
+		$this->testDataDir = __DIR__ . '/TestData';
12 12
 
13
-        parent::setUp();
14
-    }
13
+		parent::setUp();
14
+	}
15 15
 
16 16
 
17
-    public function testCreateFileIfNotExistant() {
18
-        $testFile = $this->testDataDir . '/notExistant';
17
+	public function testCreateFileIfNotExistant() {
18
+		$testFile = $this->testDataDir . '/notExistant';
19 19
 
20
-        if (true === file_exists($testFile)) {
21
-            unlink($testFile);
22
-        }
20
+		if (true === file_exists($testFile)) {
21
+			unlink($testFile);
22
+		}
23 23
 
24
-        $this->assertFileNotExists($testFile);
25
-        $this->assertFileExists($testFile);
24
+		$this->assertFileNotExists($testFile);
25
+		$this->assertFileExists($testFile);
26 26
 
27
-        // Cleanup
28
-        unlink($testFile);
29
-    }
27
+		// Cleanup
28
+		unlink($testFile);
29
+	}
30 30
 
31
-    public function testGetUserList_Empty() {
32
-        $testFile = $this->testDataDir . '/htaccess_UserServiceTest_empty';
31
+	public function testGetUserList_Empty() {
32
+		$testFile = $this->testDataDir . '/htaccess_UserServiceTest_empty';
33 33
 
34
-        if (true === file_exists($testFile)) {
35
-            unlink($testFile);
36
-        }
37
-        $this->assertFileNotExists($testFile);
38
-        touch($testFile);
39
-        $this->assertFileExists($testFile);
34
+		if (true === file_exists($testFile)) {
35
+			unlink($testFile);
36
+		}
37
+		$this->assertFileNotExists($testFile);
38
+		touch($testFile);
39
+		$this->assertFileExists($testFile);
40 40
 
41
-        $service = new HtpasswdService($testFile);
41
+		$service = new HtpasswdService($testFile);
42 42
 
43
-        $userList = $service->getUserList();
44
-        $this->assertEquals($expected = [ ], $userList, "UserList");
43
+		$userList = $service->getUserList();
44
+		$this->assertEquals($expected = [ ], $userList, "UserList");
45 45
 
46
-        // Cleanup
47
-        unlink($testFile);
48
-    }
46
+		// Cleanup
47
+		unlink($testFile);
48
+	}
49 49
 
50
-    public function testGetUserList_Filled() {
51
-        $testFile = $this->testDataDir . '/htaccess_UserServiceTest';
52
-        $this->assertFileExists($testFile);
50
+	public function testGetUserList_Filled() {
51
+		$testFile = $this->testDataDir . '/htaccess_UserServiceTest';
52
+		$this->assertFileExists($testFile);
53 53
 
54
-        $service = new HtpasswdService($testFile);
54
+		$service = new HtpasswdService($testFile);
55 55
 
56
-        $userList = $service->getUserList();
57
-        $this->assertEquals(
58
-            $expected = [ 'steven' => '$apr1$UF1l/6iv$tT3IJUH.QL82HAraXetNo0',
59
-                          'blub'   => '$apr1$jVosh5nC$q6KJ5EZNU6thOPETMQw8O/'
60
-            ], $userList, "UserList");
61
-    }
56
+		$userList = $service->getUserList();
57
+		$this->assertEquals(
58
+			$expected = [ 'steven' => '$apr1$UF1l/6iv$tT3IJUH.QL82HAraXetNo0',
59
+						  'blub'   => '$apr1$jVosh5nC$q6KJ5EZNU6thOPETMQw8O/'
60
+			], $userList, "UserList");
61
+	}
62 62
 
63
-    public function testAddUser() {
64
-        $testFileTemplate = $this->testDataDir . '/htaccess_UserServiceTest';
65
-        $testFile         = $this->testDataDir . '/htaccess_UserServiceTest_addUser';
66
-        $this->assertFileExists($testFileTemplate);
63
+	public function testAddUser() {
64
+		$testFileTemplate = $this->testDataDir . '/htaccess_UserServiceTest';
65
+		$testFile         = $this->testDataDir . '/htaccess_UserServiceTest_addUser';
66
+		$this->assertFileExists($testFileTemplate);
67 67
 
68
-        if (true === file_exists($testFile)) {
69
-            unlink($testFile);
70
-        }
71
-        $this->assertFileNotExists($testFile);
68
+		if (true === file_exists($testFile)) {
69
+			unlink($testFile);
70
+		}
71
+		$this->assertFileNotExists($testFile);
72 72
 
73
-        copy($testFileTemplate, $testFile);
74
-        $this->assertFileExists($testFile);
73
+		copy($testFileTemplate, $testFile);
74
+		$this->assertFileExists($testFile);
75 75
 
76
-        $service  = new HtpasswdService($testFile);
77
-        $userList = $service->getUserList();
78
-        $this->assertCount(2, $userList);
79
-        $this->assertEquals(2, $this->getNumberOfLines($testFile), "Number of Lines");
76
+		$service  = new HtpasswdService($testFile);
77
+		$userList = $service->getUserList();
78
+		$this->assertCount(2, $userList);
79
+		$this->assertEquals(2, $this->getNumberOfLines($testFile), "Number of Lines");
80 80
 
81 81
 
82
-        $service->addUser('test', 'test');
82
+		$service->addUser('test', 'test');
83 83
 
84
-        $userList = $service->getUserList();
85
-        $this->assertCount(3, $userList);
86
-        $this->assertEquals($expected = [ 'steven', 'blub', 'test' ],
87
-            array_keys($userList));
88
-        $this->assertEquals(3, $this->getNumberOfLines($testFile), "Number of Lines");
84
+		$userList = $service->getUserList();
85
+		$this->assertCount(3, $userList);
86
+		$this->assertEquals($expected = [ 'steven', 'blub', 'test' ],
87
+			array_keys($userList));
88
+		$this->assertEquals(3, $this->getNumberOfLines($testFile), "Number of Lines");
89 89
 
90 90
 
91
-        // Cleanup
92
-        unlink($testFile);
93
-    }
91
+		// Cleanup
92
+		unlink($testFile);
93
+	}
94 94
 
95 95
 
96
-    public function testdeleteUser() {
97
-        $testFileTemplate = $this->testDataDir . '/htaccess_UserServiceTest';
98
-        $testFile         = $this->testDataDir . '/htaccess_UserServiceTest_addUser';
99
-        $this->assertFileExists($testFileTemplate);
96
+	public function testdeleteUser() {
97
+		$testFileTemplate = $this->testDataDir . '/htaccess_UserServiceTest';
98
+		$testFile         = $this->testDataDir . '/htaccess_UserServiceTest_addUser';
99
+		$this->assertFileExists($testFileTemplate);
100 100
 
101
-        if (true === file_exists($testFile)) {
102
-            unlink($testFile);
103
-        }
104
-        $this->assertFileNotExists($testFile);
101
+		if (true === file_exists($testFile)) {
102
+			unlink($testFile);
103
+		}
104
+		$this->assertFileNotExists($testFile);
105 105
 
106
-        copy($testFileTemplate, $testFile);
107
-        $this->assertFileExists($testFile);
106
+		copy($testFileTemplate, $testFile);
107
+		$this->assertFileExists($testFile);
108 108
 
109
-        $service  = new HtpasswdService($testFile);
110
-        $userList = $service->getUserList();
111
-        $this->assertCount(2, $userList);
112
-        $this->assertEquals(2, $this->getNumberOfLines($testFile), "Number of Lines");
109
+		$service  = new HtpasswdService($testFile);
110
+		$userList = $service->getUserList();
111
+		$this->assertCount(2, $userList);
112
+		$this->assertEquals(2, $this->getNumberOfLines($testFile), "Number of Lines");
113 113
 
114 114
 
115
-        $service->deleteUser('steven');
116
-        $userList = $service->getUserList();
117
-        $this->assertCount(1, $userList);
118
-        $this->assertEquals($expected = [ 'blub' ],
119
-            array_keys($userList));
120
-        $this->assertEquals(1, $this->getNumberOfLines($testFile), "Number of Lines");
115
+		$service->deleteUser('steven');
116
+		$userList = $service->getUserList();
117
+		$this->assertCount(1, $userList);
118
+		$this->assertEquals($expected = [ 'blub' ],
119
+			array_keys($userList));
120
+		$this->assertEquals(1, $this->getNumberOfLines($testFile), "Number of Lines");
121 121
 
122 122
 
123
-        // Cleanup
124
-        unlink($testFile);
125
-    }
123
+		// Cleanup
124
+		unlink($testFile);
125
+	}
126 126
 
127
-    public function testUserExists() {
128
-        $testFile = $this->testDataDir . '/htaccess_UserServiceTest';
129
-        $this->assertFileExists($testFile);
127
+	public function testUserExists() {
128
+		$testFile = $this->testDataDir . '/htaccess_UserServiceTest';
129
+		$this->assertFileExists($testFile);
130 130
 
131
-        $service  = new HtpasswdService($testFile);
131
+		$service  = new HtpasswdService($testFile);
132 132
 
133
-        $this->assertTrue($service->userExists('steven'), 'User should exist');
134
-        $this->assertTrue($service->userExists('blub'), 'User should exist');
135
-        $this->assertFalse($service->userExists(''), "User '' should not exist");
136
-        $this->assertFalse($service->userExists('notExistant'), "User 'notExistant' should not exist");
137
-        $this->assertFalse($service->userExists('not Existant'), "User 'not Existant' should not exist");
138
-    }
133
+		$this->assertTrue($service->userExists('steven'), 'User should exist');
134
+		$this->assertTrue($service->userExists('blub'), 'User should exist');
135
+		$this->assertFalse($service->userExists(''), "User '' should not exist");
136
+		$this->assertFalse($service->userExists('notExistant'), "User 'notExistant' should not exist");
137
+		$this->assertFalse($service->userExists('not Existant'), "User 'not Existant' should not exist");
138
+	}
139 139
 
140
-    protected function getNumberOfLines($filename) {
141
-        $cont  = file_get_contents($filename);
142
-        $lines = explode("\n", $cont);
140
+	protected function getNumberOfLines($filename) {
141
+		$cont  = file_get_contents($filename);
142
+		$lines = explode("\n", $cont);
143 143
 
144
-        // Remove emtpy lines
145
-        foreach ($lines as $i => $line) {
146
-            if (empty(trim($line))) {
147
-                unset($lines[$i]);
148
-            }
149
-        }
144
+		// Remove emtpy lines
145
+		foreach ($lines as $i => $line) {
146
+			if (empty(trim($line))) {
147
+				unset($lines[$i]);
148
+			}
149
+		}
150 150
 
151
-        return count($lines);
152
-    }
151
+		return count($lines);
152
+	}
153 153
 
154 154
 }
155 155
\ No newline at end of file
Please login to merge, or discard this patch.