staudenmeir / eloquent-json-relations

src/Relations/Postgres/HasOneOrMany.php

<?php

namespace Staudenmeir\EloquentJsonRelations\Relations\Postgres;

use Illuminate\Database\Eloquent\Builder;

trait HasOneOrMany
{
    use IsPostgresRelation;

    /**
     * Add the constraints for a relationship query.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \Illuminate\Database\Eloquent\Builder $parentQuery
     * @param array|mixed $columns
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function getRelationExistenceQuery(Builder $query, Builder $parentQuery, $columns = ['*'])
    {
        if ($query->getQuery()->from == $parentQuery->getQuery()->from) {
            return $this->getRelationExistenceQueryForSelfRelation($query, $parentQuery, $columns);
        }

        $second = $this->jsonColumn($query, $this->parent, $this->getExistenceCompareKey(), $this->localKey);

It seems like getExistenceCompareKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $query->select($columns)->whereColumn(

The expression return $query->select($columns)->whereColumn($this->getQualifiedParentKeyName(), '=', $second) also could return the type Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

            $this->getQualifiedParentKeyName(),

It seems like getQualifiedParentKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            '=',
            $second

$second of type Illuminate\Database\Query\Expression is incompatible with the type null|string expected by parameter $second of Illuminate\Database\Query\Builder::whereColumn().

        );
    }

    /**
     * Add the constraints for a relationship query on the same table.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \Illuminate\Database\Eloquent\Builder $parentQuery
     * @param array|mixed $columns
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function getRelationExistenceQueryForSelfRelation(Builder $query, Builder $parentQuery, $columns = ['*'])

The parameter $parentQuery is not used and could be removed.

    {
        $query->from($query->getModel()->getTable().' as '.$hash = $this->getRelationCountHash());

It seems like getRelationCountHash() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $query->getModel()->setTable($hash);

        $second = $this->jsonColumn($query, $this->parent, $hash.'.'.$this->getForeignKeyName(), $this->localKey);

It seems like getForeignKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $query->select($columns)->whereColumn(

The expression return $query->select($columns)->whereColumn($this->getQualifiedParentKeyName(), '=', $second) also could return the type Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

            $this->getQualifiedParentKeyName(),
            '=',
            $second

$second of type Illuminate\Database\Query\Expression is incompatible with the type null|string expected by parameter $second of Illuminate\Database\Query\Builder::whereColumn().

        );
    }
}