HasOneOrMany::getRelationExistenceQueryForSelfRelation()

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getRelationExistenceQueryForSelfRelation(Builder $query, Builder $parentQuery, $columns = ['*'])

The parameter $parentQuery is not used and could be removed.

    {
        $query->from($query->getModel()->getTable().' as '.$hash = $this->getRelationCountHash());

It seems like getRelationCountHash() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $query->getModel()->setTable($hash);

        $second = $this->jsonColumn($query, $this->parent, $hash.'.'.$this->getForeignKeyName(), $this->localKey);

It seems like getForeignKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $query->select($columns)->whereColumn(

The expression return $query->select($columns)->whereColumn($this->getQualifiedParentKeyName(), '=', $second) also could return the type Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

            $this->getQualifiedParentKeyName(),
            '=',
            $second

$second of type Illuminate\Database\Query\Expression is incompatible with the type null|string expected by parameter $second of Illuminate\Database\Query\Builder::whereColumn().

        );