Staudenmeir\DuskUpdater\DetectsChromeVersion::chromeVersion()

Complexity

Conditions	5
Paths	7

Size

Total Lines	37
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	5.0291

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function chromeVersion($os)
    {
        $path = $this->option('detect');

It seems like option() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($path) {
            if ($os === 'win') {
                $this->error('Chrome version cannot be detected in custom installation path on Windows.');

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return false;
            }

            $commands = [$path.' --version'];
        } else {
            $commands = $this->chromeCommands[$os];
        }

        foreach ($commands as $command) {
            $process = Process::fromShellCommandline($command);

            $process->run();

            preg_match('/(\d+)(\.\d+){3}/', $process->getOutput(), $matches);

            if (!isset($matches[1])) {
                continue;
            }

            $this->comment(

It seems like comment() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                sprintf('Chrome version %s detected.', $matches[0])
            );

            return (int) $matches[1];
        }

        $this->error('Chrome version could not be detected. Please submit an issue: https://github.com/staudenmeir/dusk-updater');

        return false;
    }