Staudenmeir\DuskUpdater\DetectsChromeVersion

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

89.47%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	chromeVersion()	0	37	5

<?php

namespace Staudenmeir\DuskUpdater;

use Symfony\Component\Process\Process;

trait DetectsChromeVersion
{
    /**
     * The default commands to detect the installed Chrome/Chromium version.
     *
     * @var array
     */
    protected $chromeCommands = [
        'linux' => [
            '/usr/bin/google-chrome --version',
            '/usr/bin/chromium-browser --version',
            '/usr/bin/google-chrome-stable --version',
        ],
        'mac' => [
            '/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version',
        ],
        'win' => [
            'reg query "HKEY_CURRENT_USER\Software\Google\Chrome\BLBeacon" /v version',
        ],
    ];

    /**
     * Detect the installed Chrome/Chromium version.
     *
     * @param string $os
     * @return int|bool
     */
    protected function chromeVersion($os)
    {
        $path = $this->option('detect');

It seems like option() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($path) {
            if ($os === 'win') {
                $this->error('Chrome version cannot be detected in custom installation path on Windows.');

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return false;
            }

            $commands = [$path.' --version'];
        } else {
            $commands = $this->chromeCommands[$os];
        }

        foreach ($commands as $command) {
            $process = Process::fromShellCommandline($command);

            $process->run();

            preg_match('/(\d+)(\.\d+){3}/', $process->getOutput(), $matches);

            if (!isset($matches[1])) {
                continue;
            }

            $this->comment(

It seems like comment() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                sprintf('Chrome version %s detected.', $matches[0])
            );

            return (int) $matches[1];
        }

        $this->error('Chrome version could not be detected. Please submit an issue: https://github.com/staudenmeir/dusk-updater');

        return false;
    }
}