View GitHub Repository core

Schedule Inspection
Subscribe
Passed
Pull Request — master (#1984)
by Nico
20:34 queued 10:19
created

19,199 +15 Covered Lines

52,102 +23 Total Lines

36.8 % +0.013% Code Coverage

PHP Classes Changes

73.68%
 ↗
100%
 SpacecraftAttackCauseEnum improved
100%
 ↘
80%
 ColonyMember got worse
0%
 ↗
16.91%
 SpacecraftRepository improved
77.78%
 ↘
63.64%
 TrumfieldMember got worse
11.11%
 ↗
22.22%
 ConstructionProgress improved
44.27%
 ↘
37.06%
 ShipRepository got worse
81.48%
 ↘
75%
 SpacecraftMember got worse
40.15%
 ↗
44.53%
 StationRepository improved
1.64%
 ↗
5.88%
 TholianWebUtil improved
47.89%
 ↗
51.43%
 StationShowStrategy improved
⋮ view more  
97.22%
 ↛
 
 GameTwigRenderer removed

CRAP Changes

 
 ⇢
30
TholianWebUtil::isTargetInsideFinishedTholianWeb() added
 
 ⇢
5.0729
TholianWebUtil::isTargetOutsideFinishedTholianWeb(... added
 
 ⇢
2
SpacecraftRepository::getSingleSpacecraftScannerRe... added
 
 ⇢
2
SpacecraftWrapper::isSelectable() added
 
 ⇢
2
LotteryWinnerBuildplan::getFactionId() added
 
 ⇢
2
LotteryWinnerBuildplanRepository::findByFactionId(... added
 
 ⇢
2
SpacecraftMember::get() added
 
 ⇢
2
ColonyMember::get() added
 
 ⇢
2
TrumfieldMember::get() added
 
 ⇢
2
ShipNfsItem::isSelectable() added
⋮ view more  
1.1715
 ↘
1
 SpacecraftAttackCauseEnum::getDestructionCause() improved
2
 ↘
1
 ConstructionProgress::getRemainingTicks() improved
1
 ↗
2
 TradePost::isNpcTradepost() got worse
1
 ↗
2.0054
 Spacecraft::getHref() got worse
10.0158
 ↗
11.051
 ManagementProvider::setTemplateVariables() got worse
1
 ↗
3.072
 ColonyMember::canBeAccessedFrom() got worse
1
 ↗
3.576
 StationShowStrategy::setTemplateVariables() got worse
6.5625
 ↗
9.2978
 SpacecraftMember::canBeAccessedFrom() got worse
52.9509
 ↘
18.4094
 StationShowStrategy::doConstructionStuff() improved
3
 ↛
 
 FightLib::isTargetOutsideFinishedTholianWeb() removed
2.004
 ↛
 
 GameTwigRenderer::setUserVariables() removed
2
 ↛
 
 ShipRepository::getSingleSpacecraftScannerResults(... removed
2
 ↛
 
 StationRepository::isStationOnLocation() removed
2
 ↛
 
 GameTwigRenderer::setGameVariables() removed
1
 ↛
 
 ShipNfsItem::isOwnedByCurrentUser() removed
1
 ↛
 
 SpacecraftWrapper::isOwnedByCurrentUser() removed
1
 ↛
 
 GameTwigRenderer::render() removed
1
 ↛
 
 GameTwigRenderer::__construct() removed