TakeBuoy::handle() - Code Metrics - Inspection of "Dev" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#1764)

by Nico

created 2024-03-29 22:25 UTC

TakeBuoy::handle() B

↳ Parent: TakeBuoy

Complexity

Conditions	10
Paths	11

Size

Total Lines	70
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	46
c	1
b	0
f	0
nc	11
nop	1
dl	0
loc	70
rs	7.3115

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Stu\Module\Ship\Action\TakeBuoy;

use request;
use Stu\Module\Control\ActionControllerInterface;
use Stu\Module\Control\GameControllerInterface;
use Stu\Orm\Repository\BuoyRepositoryInterface;
use Stu\Module\Ship\Lib\ShipLoaderInterface;
use Stu\Module\Ship\View\ShowShip\ShowShip;
use Stu\Component\Ship\Storage\ShipStorageManagerInterface;
use Stu\Module\Message\Lib\PrivateMessageFolderSpecialEnum;
use Stu\Orm\Repository\CommodityRepositoryInterface;
use Stu\Module\Commodity\CommodityTypeEnum;
use Stu\Module\Message\Lib\PrivateMessageSenderInterface;



final class TakeBuoy implements ActionControllerInterface
{
    public const ACTION_IDENTIFIER = 'B_TAKE_BUOY';

    private ShipLoaderInterface $shipLoader;
    private BuoyRepositoryInterface $buoyRepository;
    private CommodityRepositoryInterface $commodityRepository;
    private ShipStorageManagerInterface $shipStorageManager;
    private PrivateMessageSenderInterface $privateMessageSender;

    public function __construct(
        ShipLoaderInterface $shipLoader,
        BuoyRepositoryInterface $buoyRepository,
        CommodityRepositoryInterface $commodityRepository,
        ShipStorageManagerInterface $shipStorageManager,
        PrivateMessageSenderInterface $privateMessageSender
    ) {
        $this->shipLoader = $shipLoader;
        $this->buoyRepository = $buoyRepository;
        $this->commodityRepository = $commodityRepository;
        $this->shipStorageManager = $shipStorageManager;
        $this->privateMessageSender = $privateMessageSender;
    }

    public function handle(GameControllerInterface $game): void
    {
        $game->setView(ShowShip::VIEW_IDENTIFIER);
        $userId = $game->getUser()->getId();
        $wrapper = $this->shipLoader->getWrapperByIdAndUser(
            request::indInt('id'),
            $userId
        );
        $ship = $wrapper->get();
        $buoyId = request::indInt('buoy_id');
        $epsSystem = $wrapper->getEpsSystemData();

        if ($epsSystem === null || $epsSystem->getEps() == 0) {
            $game->addInformation(_("Keine Energie vorhanden"));
            return;
        }
        if ($ship->getCloakState()) {
            $game->addInformation(_("Die Tarnung ist aktiviert"));
            return;
        }
        if ($ship->getWarpState()) {
            $game->addInformation(_("Der Warpantrieb ist aktiviert"));
            return;
        }
        if ($ship->getShieldState()) {
            $game->addInformation(_("Die Schilde sind aktiviert"));
            return;
        }

        if ($epsSystem->getEps() < 1) {
            $game->addInformation(_('Es wird 1 Energie für den Start der Boje benötigt'));
            return;
        }

        $commodity = $this->commodityRepository->find(CommodityTypeEnum::BASE_ID_BUOY);

        if ($commodity !== null) {
            $this->shipStorageManager->upperStorage(
                $ship,
                $commodity,
                1
            );
        }

        $buoy = $this->buoyRepository->find($buoyId);
        if ($buoy === null) {
            $game->addInformation(_("Die Boje existiert nicht"));
            return;
        }

        if ($buoy->getUserId() !== $userId) {
            $this->privateMessageSender->send(
                $game->getUser()->getId(),
                $buoy->getUserId(),
                sprintf(
                    _('Deine Boje %s wurde von der %s bei %s aufgebracht.'),
                    $buoy->getText(),
                    $ship->getName(),
                    $ship->getSectorString()
                ),
                PrivateMessageFolderSpecialEnum::PM_SPECIAL_SHIP,
                null
            );
        }

        $this->buoyRepository->delete($buoy);

        $epsSystem->lowerEps(1)->update();

        $game->addInformation(_('Die Boje wurde erfolgreich eingesammelt'));
    }

    public function performSessionCheck(): bool
    {
        return true;
    }
}

1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stu\Module\Ship\Action\TakeBuoy;
6
7			use request;
8			use Stu\Module\Control\ActionControllerInterface;
9			use Stu\Module\Control\GameControllerInterface;
10			use Stu\Orm\Repository\BuoyRepositoryInterface;
11			use Stu\Module\Ship\Lib\ShipLoaderInterface;
12			use Stu\Module\Ship\View\ShowShip\ShowShip;
13			use Stu\Component\Ship\Storage\ShipStorageManagerInterface;
14			use Stu\Module\Message\Lib\PrivateMessageFolderSpecialEnum;
15			use Stu\Orm\Repository\CommodityRepositoryInterface;
16			use Stu\Module\Commodity\CommodityTypeEnum;
17			use Stu\Module\Message\Lib\PrivateMessageSenderInterface;
18
19
20
21			final class TakeBuoy implements ActionControllerInterface
22			{
23			public const ACTION_IDENTIFIER = 'B_TAKE_BUOY';
24
25			private ShipLoaderInterface $shipLoader;
26			private BuoyRepositoryInterface $buoyRepository;
27			private CommodityRepositoryInterface $commodityRepository;
28			private ShipStorageManagerInterface $shipStorageManager;
29			private PrivateMessageSenderInterface $privateMessageSender;
30
31			public function __construct(
32			ShipLoaderInterface $shipLoader,
33			BuoyRepositoryInterface $buoyRepository,
34			CommodityRepositoryInterface $commodityRepository,
35			ShipStorageManagerInterface $shipStorageManager,
36			PrivateMessageSenderInterface $privateMessageSender
37			) {
38			$this->shipLoader = $shipLoader;
39			$this->buoyRepository = $buoyRepository;
40			$this->commodityRepository = $commodityRepository;
41			$this->shipStorageManager = $shipStorageManager;
42			$this->privateMessageSender = $privateMessageSender;
43			}
44
45			public function handle(GameControllerInterface $game): void
46			{
47			$game->setView(ShowShip::VIEW_IDENTIFIER);
48			$userId = $game->getUser()->getId();
49			$wrapper = $this->shipLoader->getWrapperByIdAndUser(
50			request::indInt('id'),
51			$userId
52			);
53			$ship = $wrapper->get();
54			$buoyId = request::indInt('buoy_id');
55			$epsSystem = $wrapper->getEpsSystemData();
56
57			if ($epsSystem === null \|\| $epsSystem->getEps() == 0) {
58			$game->addInformation(_("Keine Energie vorhanden"));
59			return;
60			}
61			if ($ship->getCloakState()) {
62			$game->addInformation(_("Die Tarnung ist aktiviert"));
63			return;
64			}
65			if ($ship->getWarpState()) {
66			$game->addInformation(_("Der Warpantrieb ist aktiviert"));
67			return;
68			}
69			if ($ship->getShieldState()) {
70			$game->addInformation(_("Die Schilde sind aktiviert"));
71			return;
72			}
73
74			if ($epsSystem->getEps() < 1) {
75			$game->addInformation(_('Es wird 1 Energie für den Start der Boje benötigt'));
76			return;
77			}
78
79			$commodity = $this->commodityRepository->find(CommodityTypeEnum::BASE_ID_BUOY);
80
81			if ($commodity !== null) {
82			$this->shipStorageManager->upperStorage(
83			$ship,
84			$commodity,
85			1
86			);
87			}
88
89			$buoy = $this->buoyRepository->find($buoyId);
90			if ($buoy === null) {
91			$game->addInformation(_("Die Boje existiert nicht"));
92			return;
93			}
94
95			if ($buoy->getUserId() !== $userId) {
96			$this->privateMessageSender->send(
97			$game->getUser()->getId(),
98			$buoy->getUserId(),
99			sprintf(
100			_('Deine Boje %s wurde von der %s bei %s aufgebracht.'),
101			$buoy->getText(),
102			$ship->getName(),
103			$ship->getSectorString()
104			),
105			PrivateMessageFolderSpecialEnum::PM_SPECIAL_SHIP,
106			null
107			);
108			}
109
110			$this->buoyRepository->delete($buoy);
111
112			$epsSystem->lowerEps(1)->update();
113
114			$game->addInformation(_('Die Boje wurde erfolgreich eingesammelt'));
115			}
116
117			public function performSessionCheck(): bool
118			{
119			return true;
120			}
121			}

st-universe / core

Pull Request — master (#1764)

TakeBuoy::handle() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like