View GitHub Repository core

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — master (#2358)
by Nico
10:36 queued 05:05
created

29,260 +167 Covered Lines

60,575 +365 Total Lines

48.3 % -0.015% Code Coverage

PHP Classes Changes

 
 ⇢
0%
AllianceJobPermissionRepository added
 
 ⇢
16.66%
AllianceJobPermission added
 
 ⇢
45.76%
AllianceJobPermissionEnum added
24.44%
 ↗
71.19%
 AllianceActionManager improved
57.14%
 ↗
64.29%
 RandomSystemEntry improved
37.25%
 ↘
30.16%
 AllianceJobManager got worse
57.69%
 ↗
64.44%
 AllianceJob improved
100%
 ↘
95.35%
 RageBehaviour got worse
75.61%
 ↗
79.19%
 AllianceProvider improved
0%
 ↗
3.03%
 RefactorRunner improved
11.29%
 ↘
9.72%
 PirateReaction got worse
32.99%
 ↘
32%
 Alliance got worse

CRAP Changes

 
 ⇢
72
RefactorRunner::migrateJobPermissions() added
 
 ⇢
16.7246
AllianceJobManager::hasUserPermission() added
 
 ⇢
7
AllianceActionManager::mayManageAlliance() added
 
 ⇢
4
AllianceActionManager::mayEditDiplomaticDocuments(... added
 
 ⇢
4
AllianceActionManager::mayCreateAgreements() added
 
 ⇢
3
AllianceJob::hasPermission() added
 
 ⇢
2
AllianceJobPermissionRepository::deleteByJob() added
 
 ⇢
2
AllianceJobPermissionRepository::delete() added
 
 ⇢
2
AllianceJobPermissionRepository::getByJob() added
 
 ⇢
2
AllianceJobPermissionRepository::prototype() added
⋮ view more  
8
 ↗
8.0074
 RageBehaviour::action() got worse
11.1736
 ↘
8.8343
 RandomSystemEntry::getDestinationCoordinates() improved
13.2243
 ↗
17.2462
 AllianceProvider::setTemplateVariablesForAlliance(... got worse
3.0416
 ↗
12
 AllianceJobManager::hasUserDiplomaticPermission() got worse
2
 ↛
 
 AllianceJob::setIsFounderPermission() removed
2
 ↛
 
 AllianceJob::setIsDiplomaticPermission() removed
2
 ↛
 
 AllianceJob::setIsSuccessorPermission() removed
2
 ↛
 
 AllianceJobRepository::getJobsWithFounderPermissio... removed
2
 ↛
 
 AllianceJobRepository::getJobsWithDiplomaticPermis... removed
2
 ↛
 
 AllianceJobRepository::getJobsWithSuccessorPermiss... removed
1
 ↛
 
 AllianceJob::hasDiplomaticPermission() removed
1
 ↛
 
 AllianceJob::hasSuccessorPermission() removed
1
 ↛
 
 AllianceJob::hasFounderPermission() removed